feat: unconstraining keys in unconstrained encryption #7912

benesjan · 2024-08-12T11:33:37Z

Token::transfer

before: 38441
after: 35464

diff: 2977

Note for the reviewer

This PR was blocked for a long time by this issue. On Friday Maxim did a change and he thought the issue got resolved. In most of the tests in this PR it really seemed like that but it reoccurred in token blacklist contract. I managed to find a workaround so I think this PR is ready to be reviewed and hopefully merged.

benesjan · 2024-08-12T11:33:51Z

feat: unconstraining keys in unconstrained encryption #7912 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

AztecBot · 2024-08-12T13:33:51Z

Benchmark results

Metrics with a significant change:

proof_construction_time_sha256_30_ms (16): 1,363 (-20%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,435 (+81%)
avm_simulation_time_ms (Token:mint_public): 245 (+458%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 51.0 (-80%)
avm_simulation_time_ms (AuthRegistry:set_authorized): 46.8 (+31%)
avm_simulation_time_ms (Token:transfer_public): 26.1 (+69%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,774 (+1%)	1,551	707 (+1%)	768	775 (+1%)
proof_construction_time_sha256_30_ms	11,501	3,050 (-1%)	⚠️ 1,363 (-20%)	1,438 (-9%)	1,445 (-7%)
proof_construction_time_sha256_100_ms	45,301	11,784	5,423	5,930	5,364 (-5%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	58.0	89.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,530	416	198	219 (-1%)	269 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,645	1,506 (+1%)	666	720	751 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,768	97,618	186,908
l1_rollup_execution_gas	819,454	1,555,712	3,346,437
l2_block_processing_time_in_ms	250 (-3%)	438 (+2%)	810
l2_block_building_time_in_ms	9,360	18,433 (+1%)	36,778
l2_block_rollup_simulation_time_in_ms	9,359	18,433 (+1%)	36,777
l2_block_public_tx_process_time_in_ms	7,964	17,002	35,323

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,107 (+6%)	3,902 (+1%)
node_database_size_in_bytes	14,246,128	18,252,016
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	75.1 (+5%)	378 (-1%)	20,975	44,933	N/A
private-kernel-inner	142 (+1%)	696	71,787	45,067	N/A
private-kernel-reset-tiny	333 (-1%)	699 (-3%)	64,273	44,922	N/A
private-kernel-tail	152 (-1%)	132 (-1%)	50,551	57,178	N/A
base-parity	5.55	N/A	160	96.0	N/A
root-parity	35.2	N/A	73,964	96.0	N/A
base-rollup	2,141 (+1%)	N/A	189,128	664	N/A
block-root-rollup	41.1	N/A	58,217	2,448	N/A
public-kernel-setup	86.7 (-1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	99.8	N/A	114,251	79,670	N/A
public-kernel-tail	583	N/A	487,098	16,414	N/A
private-kernel-reset-small	303 (-3%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,435 (+81%)	599 (-1%)	448,120	1,825	N/A
public-kernel-teardown	85.0 (-1%)	N/A	114,697	79,670	N/A
merge-rollup	20.2 (+2%)	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	103,118 (-5%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	347 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	423 (-1%)
FeeJuice:deploy	1,376	11,731	390 (-3%)
SchnorrAccount:constructor	1,312	11,731	61.2
SchnorrAccount:entrypoint	2,336	11,731	367 (-1%)
FeeJuice:claim	1,344	11,731	36.2 (+1%)
Token:privately_mint_private_note	1,280	11,731	70.9 (-3%)
FPC:fee_entrypoint_public	1,344	11,731	24.2 (+3%)
Token:transfer	1,312	11,731	196 (-5%)
Benchmarking:create_note	1,344	11,731	73.2 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	29.0 (+9%)
Token:unshield	1,376	11,731	482 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	649 (+1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	135 (-1%)	1,188
FeeJuice:set_portal	10.7 (-1%)	1,170
Token:constructor	252 (-3%)	10,378
FPC:constructor	68.5 (-4%)	7,877
FeeJuice:check_balance	35.6 (-1%)	995
Token:mint_public	⚠️ 245 (+458%)	2,123
Token:assert_minter_and_mint	⚠️ 51.0 (-80%)	1,435
AuthRegistry:set_authorized	⚠️ 46.8 (+31%)	515
FPC:prepare_fee	88.6	1,588
Token:transfer_public	⚠️ 26.1 (+69%)	8,603
FPC:pay_refund	40.1 (-2%)	2,090
Benchmarking:increment_balance	1,004 (+1%)	1,516
Token:_increase_public_balance	38.9 (+5%)	1,159
FPC:pay_refund_with_shielded_rebate	49.7 (-4%)	2,090

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.163 (-3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18 (+1%)	3.87	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114	0.109 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1	17.6	31.4	58.6	118 (+5%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106	0.102	0.101	0.101 (+1%)	0.104 (+4%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.1 (-2%)	26.2	44.5 (-1%)	81.7	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-2%)	0.106	0.106 (-2%)	0.101	0.101
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	15.9 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,419	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

benesjan · 2024-09-09T18:12:46Z

noir-projects/noir-contracts/contracts/token_blacklist_contract/src/main.nr

-        storage.balances.sub(from, amount).emit(encode_and_encrypt_note(&mut context, from, from));
-        storage.balances.add(to, amount).emit(encode_and_encrypt_note(&mut context, from, to));
+        storage.balances.sub(from, amount).emit(encode_and_encrypt_note_unconstrained(&mut context, from, from));
+        storage.balances.add(to, amount).emit(encode_and_encrypt_note_unconstrained(&mut context, from, to));


Did this change because it worked as a workaround around the Noir issue which reoccurred in this function (see here for context). I didn't want this PR to be blocked no more and we did this change in the standard token so I think it's an ok change to do.

So if we do constrained encryption this breaks?

Yes, it's a house of cards

yarn-project/sequencer-client/src/tx_validator/metadata_validator.ts

sklppy88

Nice ! 🚀

noir-projects/aztec-nr/aztec/src/encrypted_logs/encrypted_note_emission.nr

nventuro · 2024-09-10T21:43:14Z

noir-projects/noir-contracts/contracts/token_blacklist_contract/src/main.nr

-        storage.balances.sub(from, amount).emit(encode_and_encrypt_note(&mut context, from, from));
-        storage.balances.add(to, amount).emit(encode_and_encrypt_note(&mut context, from, to));
+        storage.balances.sub(from, amount).emit(encode_and_encrypt_note_unconstrained(&mut context, from, from));
+        storage.balances.add(to, amount).emit(encode_and_encrypt_note_unconstrained(&mut context, from, to));


So if we do constrained encryption this breaks?

noir-projects/aztec-nr/aztec/src/keys/getters/mod.nr

yarn-project/sequencer-client/src/tx_validator/metadata_validator.ts

yarn-project/end-to-end/src/e2e_keys.test.ts

noir-projects/aztec-nr/aztec/src/encrypted_logs/encrypted_note_emission.nr

github-actions · 2024-09-17T06:09:36Z

Changes to circuit sizes

Generated at commit: 2c71b660a5eaff4f8e9f46188f4ba740ed08d4cd, compared to commit: e0185e75e65df08b5334856f8bf63fa3aed7049a

🧾 Summary (100% most significant diffs)

Program	%	Circuit size (+/-)	%
parity_root	0.00%	+87,732 ❌	+1.63%
rollup_block_root	0.00%	+65,799 ❌	+1.62%
rollup_merge	0.00%	+43,866 ❌	+1.62%
rollup_root	0.00%	+43,866 ❌	+1.60%
rollup_block_merge	0.00%	+43,866 ❌	+1.60%
public_kernel_app_logic	0.00%	+21,933 ❌	+1.12%
public_kernel_teardown	0.00%	+21,933 ❌	+1.12%
public_kernel_setup	0.00%	+21,933 ❌	+1.12%
public_kernel_tail	0.00%	+21,933 ❌	+0.81%
rollup_base	0.00%	+21,933 ❌	+0.61%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
parity_root	374 (0)	0.00%	5,481,623 (+87,732)	+1.63%
rollup_block_root	803 (0)	0.00%	4,117,756 (+65,799)	+1.62%
rollup_merge	319 (0)	0.00%	2,748,043 (+43,866)	+1.62%
rollup_root	18,188 (0)	0.00%	2,785,852 (+43,866)	+1.60%
rollup_block_merge	18,204 (0)	0.00%	2,785,884 (+43,866)	+1.60%
public_kernel_app_logic	246,381 (0)	0.00%	1,983,861 (+21,933)	+1.12%
public_kernel_teardown	247,012 (0)	0.00%	1,984,645 (+21,933)	+1.12%
public_kernel_setup	246,841 (0)	0.00%	1,987,064 (+21,933)	+1.12%
public_kernel_tail	259,775 (0)	0.00%	2,726,963 (+21,933)	+0.81%
rollup_base	347,688 (0)	0.00%	3,629,648 (+21,933)	+0.61%

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.55.1</summary> ## [0.55.1](aztec-package-v0.55.0...aztec-package-v0.55.1) (2024-09-17) ### Features * CI deploy on sepolia ([#8514](#8514)) ([54f0344](54f0344)) * Tx verification & peer scoring on p2p layer. bot support for EasyPrivateToken ([#8298](#8298)) ([beb651f](beb651f)) ### Miscellaneous * Remove ARCHIVER_L1_START_BLOCK ([#8554](#8554)) ([bc8d461](bc8d461)) </details> <details><summary>barretenberg.js: 0.55.1</summary> ## [0.55.1](barretenberg.js-v0.55.0...barretenberg.js-v0.55.1) (2024-09-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.55.1</summary> ## [0.55.1](aztec-packages-v0.55.0...aztec-packages-v0.55.1) (2024-09-17) ### Features * `TXE::store_note_in_cache` --> `TXE::add_note` ([#8547](#8547)) ([5a6aaeb](5a6aaeb)) * Add a `comptime` string type for string handling at compile-time (noir-lang/noir#6026) ([cd7983a](cd7983a)) * CI deploy on sepolia ([#8514](#8514)) ([54f0344](54f0344)) * Default to outputting witness with file named after package (noir-lang/noir#6031) ([cd7983a](cd7983a)) * Let LSP suggest trait impl methods as you are typing them (noir-lang/noir#6029) ([cd7983a](cd7983a)) * NFT with "transient" storage shield flow ([#8129](#8129)) ([578f67c](578f67c)) * Optimize allocating immediate amounts of memory ([#8579](#8579)) ([e0185e7](e0185e7)) * Spartan iac ([#8455](#8455)) ([16fba46](16fba46)) * Sync from aztec-packages (noir-lang/noir#6028) ([cd7983a](cd7983a)) * Tx verification & peer scoring on p2p layer. bot support for EasyPrivateToken ([#8298](#8298)) ([beb651f](beb651f)) * Unconstraining keys in unconstrained encryption ([#7912](#7912)) ([eb9275a](eb9275a)) * Update args hash to be a flat poseidon ([#8571](#8571)) ([0c54224](0c54224)) * Use poseidon for fn selectors ([#8239](#8239)) ([41891db](41891db)) ### Bug Fixes * Disable side-effects for no_predicates functions (noir-lang/noir#6027) ([cd7983a](cd7983a)) * Native world state test issues ([#8546](#8546)) ([aab8773](aab8773)) * Remove special case for epoch 0 ([#8549](#8549)) ([b035d01](b035d01)) * Serialize AvmVerificationKeyData ([#8529](#8529)) ([78c94a4](78c94a4)) ### Miscellaneous * 7791: Disable world_state test suite ([#8594](#8594)) ([ee21583](ee21583)) * Add jq to aztec image ([#8542](#8542)) ([a7fb791](a7fb791)) * Add sync suite ([#8550](#8550)) ([ce0a9db](ce0a9db)) * **ci:** Action to redo typo PRs ([#8553](#8553)) ([3ed5879](3ed5879)) * **ci:** Fix master ([#8534](#8534)) ([47c368f](47c368f)) * **ci:** Fix redo-typo-pr.yml ([abf9802](abf9802)) * **ci:** Fix redo-typo-pr.yml ([#8555](#8555)) ([7f1673c](7f1673c)) * **ci:** Hotfix ([ffd31aa](ffd31aa)) * **ci:** Hotfix arm ci ([979f267](979f267)) * **ci:** Optimize disk usage in arm run ([#8564](#8564)) ([33e6aa4](33e6aa4)) * **ci:** Use labels and if branch=master to control jobs ([#8508](#8508)) ([68a2226](68a2226)) * GitHub Actions Deployments to Amazon EKS ([#8563](#8563)) ([6fae8f0](6fae8f0)) * Moves add gate out of aux ([#8541](#8541)) ([c3ad163](c3ad163)) * Protogalaxy verifier matches prover 2 ([#8477](#8477)) ([58882b1](58882b1)) * Redo typo PR by ankushgoel27 ([#8595](#8595)) ([7ca6d24](7ca6d24)) * Redo typo PR by Ocheretovich ([#8559](#8559)) ([c4296ba](c4296ba)) * Redo typo PR by Olexandr88 ([#8560](#8560)) ([e35d148](e35d148)) * Redo typo PR by skaunov ([#8557](#8557)) ([8a1e7c3](8a1e7c3)) * Release Noir(0.34.0) (noir-lang/noir#5692) ([cd7983a](cd7983a)) * Remove ARCHIVER_L1_START_BLOCK ([#8554](#8554)) ([bc8d461](bc8d461)) * Remove redundant e2e tests and organize ([#8561](#8561)) ([de2b775](de2b775)) * Remove unused imports ([#8556](#8556)) ([e11242e](e11242e)) * Replace relative paths to noir-protocol-circuits ([2336986](2336986)) * Replace relative paths to noir-protocol-circuits ([9668ed5](9668ed5)) </details> <details><summary>barretenberg: 0.55.1</summary> ## [0.55.1](barretenberg-v0.55.0...barretenberg-v0.55.1) (2024-09-17) ### Bug Fixes * Native world state test issues ([#8546](#8546)) ([aab8773](aab8773)) ### Miscellaneous * 7791: Disable world_state test suite ([#8594](#8594)) ([ee21583](ee21583)) * Moves add gate out of aux ([#8541](#8541)) ([c3ad163](c3ad163)) * Protogalaxy verifier matches prover 2 ([#8477](#8477)) ([58882b1](58882b1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.55.1</summary> ## [0.55.1](AztecProtocol/aztec-packages@aztec-package-v0.55.0...aztec-package-v0.55.1) (2024-09-17) ### Features * CI deploy on sepolia ([#8514](AztecProtocol/aztec-packages#8514)) ([54f0344](AztecProtocol/aztec-packages@54f0344)) * Tx verification & peer scoring on p2p layer. bot support for EasyPrivateToken ([#8298](AztecProtocol/aztec-packages#8298)) ([beb651f](AztecProtocol/aztec-packages@beb651f)) ### Miscellaneous * Remove ARCHIVER_L1_START_BLOCK ([#8554](AztecProtocol/aztec-packages#8554)) ([bc8d461](AztecProtocol/aztec-packages@bc8d461)) </details> <details><summary>barretenberg.js: 0.55.1</summary> ## [0.55.1](AztecProtocol/aztec-packages@barretenberg.js-v0.55.0...barretenberg.js-v0.55.1) (2024-09-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.55.1</summary> ## [0.55.1](AztecProtocol/aztec-packages@aztec-packages-v0.55.0...aztec-packages-v0.55.1) (2024-09-17) ### Features * `TXE::store_note_in_cache` --> `TXE::add_note` ([#8547](AztecProtocol/aztec-packages#8547)) ([5a6aaeb](AztecProtocol/aztec-packages@5a6aaeb)) * Add a `comptime` string type for string handling at compile-time (noir-lang/noir#6026) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * CI deploy on sepolia ([#8514](AztecProtocol/aztec-packages#8514)) ([54f0344](AztecProtocol/aztec-packages@54f0344)) * Default to outputting witness with file named after package (noir-lang/noir#6031) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * Let LSP suggest trait impl methods as you are typing them (noir-lang/noir#6029) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * NFT with "transient" storage shield flow ([#8129](AztecProtocol/aztec-packages#8129)) ([578f67c](AztecProtocol/aztec-packages@578f67c)) * Optimize allocating immediate amounts of memory ([#8579](AztecProtocol/aztec-packages#8579)) ([e0185e7](AztecProtocol/aztec-packages@e0185e7)) * Spartan iac ([#8455](AztecProtocol/aztec-packages#8455)) ([16fba46](AztecProtocol/aztec-packages@16fba46)) * Sync from aztec-packages (noir-lang/noir#6028) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * Tx verification & peer scoring on p2p layer. bot support for EasyPrivateToken ([#8298](AztecProtocol/aztec-packages#8298)) ([beb651f](AztecProtocol/aztec-packages@beb651f)) * Unconstraining keys in unconstrained encryption ([#7912](AztecProtocol/aztec-packages#7912)) ([eb9275a](AztecProtocol/aztec-packages@eb9275a)) * Update args hash to be a flat poseidon ([#8571](AztecProtocol/aztec-packages#8571)) ([0c54224](AztecProtocol/aztec-packages@0c54224)) * Use poseidon for fn selectors ([#8239](AztecProtocol/aztec-packages#8239)) ([41891db](AztecProtocol/aztec-packages@41891db)) ### Bug Fixes * Disable side-effects for no_predicates functions (noir-lang/noir#6027) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * Native world state test issues ([#8546](AztecProtocol/aztec-packages#8546)) ([aab8773](AztecProtocol/aztec-packages@aab8773)) * Remove special case for epoch 0 ([#8549](AztecProtocol/aztec-packages#8549)) ([b035d01](AztecProtocol/aztec-packages@b035d01)) * Serialize AvmVerificationKeyData ([#8529](AztecProtocol/aztec-packages#8529)) ([78c94a4](AztecProtocol/aztec-packages@78c94a4)) ### Miscellaneous * 7791: Disable world_state test suite ([#8594](AztecProtocol/aztec-packages#8594)) ([ee21583](AztecProtocol/aztec-packages@ee21583)) * Add jq to aztec image ([#8542](AztecProtocol/aztec-packages#8542)) ([a7fb791](AztecProtocol/aztec-packages@a7fb791)) * Add sync suite ([#8550](AztecProtocol/aztec-packages#8550)) ([ce0a9db](AztecProtocol/aztec-packages@ce0a9db)) * **ci:** Action to redo typo PRs ([#8553](AztecProtocol/aztec-packages#8553)) ([3ed5879](AztecProtocol/aztec-packages@3ed5879)) * **ci:** Fix master ([#8534](AztecProtocol/aztec-packages#8534)) ([47c368f](AztecProtocol/aztec-packages@47c368f)) * **ci:** Fix redo-typo-pr.yml ([abf9802](AztecProtocol/aztec-packages@abf9802)) * **ci:** Fix redo-typo-pr.yml ([#8555](AztecProtocol/aztec-packages#8555)) ([7f1673c](AztecProtocol/aztec-packages@7f1673c)) * **ci:** Hotfix ([ffd31aa](AztecProtocol/aztec-packages@ffd31aa)) * **ci:** Hotfix arm ci ([979f267](AztecProtocol/aztec-packages@979f267)) * **ci:** Optimize disk usage in arm run ([#8564](AztecProtocol/aztec-packages#8564)) ([33e6aa4](AztecProtocol/aztec-packages@33e6aa4)) * **ci:** Use labels and if branch=master to control jobs ([#8508](AztecProtocol/aztec-packages#8508)) ([68a2226](AztecProtocol/aztec-packages@68a2226)) * GitHub Actions Deployments to Amazon EKS ([#8563](AztecProtocol/aztec-packages#8563)) ([6fae8f0](AztecProtocol/aztec-packages@6fae8f0)) * Moves add gate out of aux ([#8541](AztecProtocol/aztec-packages#8541)) ([c3ad163](AztecProtocol/aztec-packages@c3ad163)) * Protogalaxy verifier matches prover 2 ([#8477](AztecProtocol/aztec-packages#8477)) ([58882b1](AztecProtocol/aztec-packages@58882b1)) * Redo typo PR by ankushgoel27 ([#8595](AztecProtocol/aztec-packages#8595)) ([7ca6d24](AztecProtocol/aztec-packages@7ca6d24)) * Redo typo PR by Ocheretovich ([#8559](AztecProtocol/aztec-packages#8559)) ([c4296ba](AztecProtocol/aztec-packages@c4296ba)) * Redo typo PR by Olexandr88 ([#8560](AztecProtocol/aztec-packages#8560)) ([e35d148](AztecProtocol/aztec-packages@e35d148)) * Redo typo PR by skaunov ([#8557](AztecProtocol/aztec-packages#8557)) ([8a1e7c3](AztecProtocol/aztec-packages@8a1e7c3)) * Release Noir(0.34.0) (noir-lang/noir#5692) ([cd7983a](AztecProtocol/aztec-packages@cd7983a)) * Remove ARCHIVER_L1_START_BLOCK ([#8554](AztecProtocol/aztec-packages#8554)) ([bc8d461](AztecProtocol/aztec-packages@bc8d461)) * Remove redundant e2e tests and organize ([#8561](AztecProtocol/aztec-packages#8561)) ([de2b775](AztecProtocol/aztec-packages@de2b775)) * Remove unused imports ([#8556](AztecProtocol/aztec-packages#8556)) ([e11242e](AztecProtocol/aztec-packages@e11242e)) * Replace relative paths to noir-protocol-circuits ([2336986](AztecProtocol/aztec-packages@2336986)) * Replace relative paths to noir-protocol-circuits ([9668ed5](AztecProtocol/aztec-packages@9668ed5)) </details> <details><summary>barretenberg: 0.55.1</summary> ## [0.55.1](AztecProtocol/aztec-packages@barretenberg-v0.55.0...barretenberg-v0.55.1) (2024-09-17) ### Bug Fixes * Native world state test issues ([#8546](AztecProtocol/aztec-packages#8546)) ([aab8773](AztecProtocol/aztec-packages@aab8773)) ### Miscellaneous * 7791: Disable world_state test suite ([#8594](AztecProtocol/aztec-packages#8594)) ([ee21583](AztecProtocol/aztec-packages@ee21583)) * Moves add gate out of aux ([#8541](AztecProtocol/aztec-packages#8541)) ([c3ad163](AztecProtocol/aztec-packages@c3ad163)) * Protogalaxy verifier matches prover 2 ([#8477](AztecProtocol/aztec-packages#8477)) ([58882b1](AztecProtocol/aztec-packages@58882b1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from 7039205 to c00e21c Compare August 12, 2024 12:47

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch 3 times, most recently from d9051c0 to f6593cf Compare August 16, 2024 10:22

benesjan changed the title ~~feat: keys hash optimization~~ feat: unconstraining keys in unconstrained encryption Aug 16, 2024

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from f6593cf to 5941979 Compare August 19, 2024 09:15

benesjan mentioned this pull request Aug 20, 2024

Content of a struct gets "destroyed" noir-lang/noir#5771

Closed

benesjan added the S-blocked Status: Blocked label Aug 23, 2024

benesjan marked this pull request as ready for review September 9, 2024 13:27

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from 5941979 to 14d5b8b Compare September 9, 2024 13:27

benesjan removed the S-blocked Status: Blocked label Sep 9, 2024

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from fc40044 to 932dcf5 Compare September 9, 2024 18:10

benesjan commented Sep 9, 2024

View reviewed changes

yarn-project/sequencer-client/src/tx_validator/metadata_validator.ts Show resolved Hide resolved

benesjan requested review from nventuro and sklppy88 September 9, 2024 18:47

sklppy88 approved these changes Sep 10, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/encrypted_logs/encrypted_note_emission.nr Show resolved Hide resolved

nventuro reviewed Sep 10, 2024

View reviewed changes

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from 932dcf5 to 6661067 Compare September 12, 2024 09:09

benesjan requested a review from nventuro September 12, 2024 09:33

nventuro approved these changes Sep 16, 2024

View reviewed changes

benesjan added 7 commits September 17, 2024 05:48

feat: keys hash optimization

f16a8e9

WIP

bd0a81c

cleanup

a77896d

fixes after rebase

5b18af0

cleanup after rebase

7ff6752

cleanup

2864c1e

more helpful error message

cf530e6

benesjan added 5 commits September 17, 2024 05:49

workaround

d1ad0a8

comment

116f281

documenting helper funcs

90a4f8f

import fix

3b3336d

linking issue

6cd407f

benesjan force-pushed the 08-12-feat_keys_hash_optimization branch from 103e6d3 to 6cd407f Compare September 17, 2024 06:00

benesjan enabled auto-merge (squash) September 17, 2024 06:00

benesjan merged commit eb9275a into master Sep 17, 2024
50 checks passed

benesjan deleted the 08-12-feat_keys_hash_optimization branch September 17, 2024 06:32

AztecBot mentioned this pull request Sep 17, 2024

chore(master): Release 0.55.1 #8533

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: unconstraining keys in unconstrained encryption #7912

feat: unconstraining keys in unconstrained encryption #7912

benesjan commented Aug 12, 2024 •

edited

Loading

benesjan commented Aug 12, 2024

AztecBot commented Aug 12, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

benesjan Sep 9, 2024

nventuro Sep 10, 2024

benesjan Sep 12, 2024

sklppy88 left a comment

nventuro Sep 10, 2024

github-actions bot commented Sep 17, 2024

feat: unconstraining keys in unconstrained encryption #7912

feat: unconstraining keys in unconstrained encryption #7912

Conversation

benesjan commented Aug 12, 2024 • edited Loading

Note for the reviewer

benesjan commented Aug 12, 2024

AztecBot commented Aug 12, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

benesjan Sep 9, 2024

Choose a reason for hiding this comment

nventuro Sep 10, 2024

Choose a reason for hiding this comment

benesjan Sep 12, 2024

Choose a reason for hiding this comment

sklppy88 left a comment

Choose a reason for hiding this comment

nventuro Sep 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

benesjan commented Aug 12, 2024 •

edited

Loading

AztecBot commented Aug 12, 2024 •

edited

Loading