Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: breaking e2e tests with initial siloing impl #7755

Conversation

sklppy88
Copy link
Contributor

@sklppy88 sklppy88 commented Aug 2, 2024

Please read contributing guidelines and remove this line.

Copy link
Contributor Author

sklppy88 commented Aug 2, 2024

@sklppy88 sklppy88 changed the title init feat: breaking e2e tests with initial siloing impl Aug 2, 2024
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/use-scopes-in-wallet-calls branch from 232bb14 to 15e775d Compare August 4, 2024 09:49
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch from 6df9517 to 175771e Compare August 4, 2024 09:50
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/use-scopes-in-wallet-calls branch from 15e775d to d784b8b Compare August 5, 2024 14:42
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch from 175771e to b0675aa Compare August 5, 2024 14:42
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/use-scopes-in-wallet-calls branch from d784b8b to cb5bfc6 Compare August 5, 2024 15:07
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch from b0675aa to 0813329 Compare August 5, 2024 15:08
@sklppy88 sklppy88 marked this pull request as ready for review August 5, 2024 16:12
@AztecBot
Copy link
Collaborator

AztecBot commented Aug 5, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 70.3 (-49%)
  • protocol_circuit_proving_time_in_ms (base-parity): 1,102 (-35%)
  • l2_block_processing_time_in_ms (8): 441 (-22%)
  • node_history_sync_time_in_ms (5): 3,739 (-28%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,717 (+1%) 1,544 710 (+1%) 730 (-3%) 761 (-1%)
proof_construction_time_sha256_30_ms 11,729 (+1%) 3,161 (+1%) 1,411 (+1%) 1,454 (+1%) 1,474
proof_construction_time_sha256_100_ms 43,837 (+1%) 12,468 (+1%) 5,718 (+1%) 5,600 (+1%) 5,550 (+1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 60.0 (+2%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,516 (+1%) 416 200 229 (-1%) 269 (+1%)
proof_construction_time_poseidon_hash_100_ms 5,611 (+2%) 1,515 (-1%) 678 740 747 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 740 740 740
l1_rollup_calldata_gas 6,692 6,718 6,704
l1_rollup_execution_gas 611,959 612,136 612,273
l2_block_processing_time_in_ms 251 (+2%) ⚠️ 441 (-22%) 820 (-5%)
l2_block_building_time_in_ms 9,395 18,532 (-3%) 36,466 (-1%)
l2_block_rollup_simulation_time_in_ms 9,394 18,532 (-3%) 36,466 (-1%)
l2_block_public_tx_process_time_in_ms 7,845 16,762 (-3%) 34,637 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 2,748 ⚠️ 3,739 (-28%)
node_database_size_in_bytes 12,718,160 16,912,464
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 100 (-2%) 447 (+9%) 21,846 44,858 N/A N/A N/A N/A
private-kernel-inner 168 738 (+2%) 72,545 45,005 N/A N/A N/A N/A
private-kernel-tail 690 (+1%) 877 53,523 49,801 N/A N/A N/A N/A
base-parity 5.91 (+1%) 277 (-6%) 160 96.0 ⚠️ 1,102 (-35%) 13,188 19.0 65,536
root-parity 111 (+1%) 115 (+3%) 69,084 96.0 28,167 (+1%) 13,188 19.0 4,194,304
base-rollup 2,954 (-1%) 5,429 182,288 664 86,581 14,020 45.0 16,777,216
root-rollup 97.7 104 (-1%) 54,525 716 25,349 13,988 44.0 4,194,304
public-kernel-setup 91.7 (+2%) 2,731 (-1%) 102,617 69,814 15,423 (+1%) 127,172 3,581 2,097,152
public-kernel-app-logic 105 (-2%) 4,139 (-1%) 102,617 69,814 9,060 (-1%) 127,172 3,581 1,048,576
public-kernel-tail 579 (-1%) 29,223 (+9%) 402,342 10,878 93,025 (+1%) 26,436 433 16,777,216
private-kernel-reset-tiny 194 (+1%) 891 (+2%) 68,621 44,750 N/A N/A N/A N/A
private-kernel-tail-to-public 3,335 (-6%) 1,649 (-2%) 977,330 1,697 N/A N/A N/A N/A
public-kernel-teardown 85.5 (+1%) 4,202 (+2%) 102,617 69,814 16,254 127,172 3,581 2,097,152
merge-rollup 60.2 (-1%) N/A 35,742 664 N/A N/A N/A N/A
undefined N/A N/A N/A N/A 148,703 N/A N/A N/A

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms
ContractClassRegisterer:register 1,344 11,731 338 (-1%) N/A N/A
ContractInstanceDeployer:deploy 1,408 11,731 18.2 N/A N/A
MultiCallEntrypoint:entrypoint 1,920 11,731 472 N/A N/A
GasToken:deploy 1,376 11,731 388 N/A N/A
SchnorrAccount:constructor 1,312 11,731 176 N/A N/A
SchnorrAccount:entrypoint 2,304 11,731 570 N/A N/A
Token:privately_mint_private_note 1,280 11,731 224 N/A N/A
FPC:fee_entrypoint_public 1,344 11,731 30.4 (+3%) N/A N/A
Token:transfer 1,312 11,731 807 N/A N/A
AuthRegistry:set_authorized (avm) 18,491 N/A N/A 147,456 2,705 (+4%)
FPC:prepare_fee (avm) 22,958 N/A N/A 147,520 3,304 (-1%)
Token:transfer_public (avm) 61,614 N/A N/A 147,520 17,459 (-2%)
AuthRegistry:consume (avm) 41,719 N/A N/A 147,488 7,595
FPC:pay_refund (avm) 26,227 N/A N/A 147,488 7,450
Benchmarking:create_note 1,344 11,731 171 (-2%) N/A N/A
SchnorrAccount:verify_private_authwit 1,280 11,731 27.4 (+2%) N/A N/A
Token:unshield 1,376 11,731 749 (+3%) N/A N/A
FPC:fee_entrypoint_private 1,376 11,731 976 (+1%) N/A N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
GasToken:_increase_public_balance 92.2 (+1%) 8,139
GasToken:set_portal 11.1 (+10%) 2,362
Token:constructor 119 (+3%) 31,107
FPC:constructor 92.5 24,011
GasToken:mint_public 78.9 (+3%) 6,150
Token:mint_public 90.1 (+10%) 11,720
Token:assert_minter_and_mint 82.8 (-13%) 8,028
AuthRegistry:set_authorized 9.22 (-3%) 4,537
FPC:prepare_fee 279 (-4%) 8,812
Token:transfer_public 25.3 (-20%) 47,374
FPC:pay_refund 60.9 (-8%) 12,114
Benchmarking:increment_balance 985 (-1%) 7,450
Token:_increase_public_balance 77.4 (+28%) 8,960
FPC:pay_refund_with_shielded_rebate ⚠️ 70.3 (-49%) 12,663

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.150 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.12 (-6%) 3.88 (-6%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.111 (-6%) 0.111 (-6%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 10.9 17.9 (-12%) 32.0 (+8%) 58.9 (-27%) 117 (-11%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.105 0.105 (-12%) 0.105 (+7%) 0.102 (-28%) 0.104 (-10%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.2 (+2%) 25.8 (-14%) 44.4 (+6%) 81.9 (-26%) 167 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.108 (+2%) 0.105 (-14%) 0.108 (+6%) 0.101 (-28%) 0.106 (-1%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.5 (-10%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 133 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.105 (-10%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 62,729 664,455

Transaction size based on fee payment method

| Metric | |
| - | |

@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/use-scopes-in-wallet-calls branch from cb5bfc6 to 84c3c3b Compare August 5, 2024 21:18
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch from 0813329 to 0656cbe Compare August 5, 2024 21:19
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/use-scopes-in-wallet-calls branch from 84c3c3b to 14a181b Compare August 6, 2024 09:17
@sklppy88 sklppy88 force-pushed the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch from 0656cbe to 745fba4 Compare August 6, 2024 09:17
Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.
@sklppy88 sklppy88 merged commit 58e1fd2 into ek/feat/silo-notes/use-scopes-in-wallet-calls Aug 6, 2024
1 check passed
@sklppy88 sklppy88 deleted the ek/feat/silo-notes/break-e2e-tests-with-initial-impl branch August 6, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants