Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(barretenberg): use a single bberg header & cleanup includes #720

Merged
merged 12 commits into from
Jun 1, 2023
Merged

chore(barretenberg): use a single bberg header & cleanup includes #720

merged 12 commits into from
Jun 1, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented May 30, 2023 •
edited
Loading

Description

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 changed the title Draft: chore: use a single bberg header & include cleanup Draft: chore(barretenberg): use a single bberg header & include cleanup May 31, 2023
@dbanks12 dbanks12 changed the title Draft: chore(barretenberg): use a single bberg header & include cleanup Draft: chore(barretenberg): use a single bberg header & cleanup includes May 31, 2023
@dbanks12 dbanks12 mentioned this pull request May 31, 2023
Merged
11 tasks
ludamad
ludamad approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once ready, thanks

@dbanks12 dbanks12 marked this pull request as ready for review June 1, 2023 19:12
@dbanks12 dbanks12 changed the title Draft: chore(barretenberg): use a single bberg header & cleanup includes chore(barretenberg): use a single bberg header & cleanup includes Jun 1, 2023
@dbanks12 dbanks12 merged commit 2453b25 into master Jun 1, 2023
@dbanks12 dbanks12 deleted the db/single-bberg-header-and-cleanup branch June 1, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circuits should only use a single bberg header
2 participants
@dbanks12 @ludamad