chore: enable skipped ordering tests since AVM properly updates side-effect counter for nested calls

[dbanks12]

Enabling set_value_with_two_nested_calls

Resolves #6502
Resolves #6471

[dbanks12]

• chore: enable skipped ordering tests since AVM properly updates side-effect counter for nested calls #7064 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dbanks12 and the rest of your teammates on Graphite

[dbanks12]

@MirandaWood is this still true? And if so, where can I find the hack? It's not immediately clear to me looking in tail_phase_manager.ts

[MirandaWood]

@MirandaWood is this still true? And if so, where can I find the hack? It's not immediately clear to me looking in tail_phase_manager.ts

It appears to no longer be true! The 'hack' I added was sortLogsHashes in tail_phase_manager. It was required when we didn't sort logs in the public tail. We now do this, so I assume the ts sorting has been replaced by hints and that comment should have been removed.

The issue pre-AVM with set_value_with_two_nested_calls was #6052 (possibly a duplicate of #6471?)- even if we sorted the logs, we could have duplicate side effect counters meaning the test you re-enabled failed. With the AVM this should now be all good.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:transfer_public): 31.1 (-56%)
• avm_simulation_time_ms (FPC:pay_refund): 91.0 (+52%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_30_ms	11,820	3,178	1,446 (-1%)	1,462 (-10%)	1,533 (+4%)
proof_construction_time_sha256_100_ms	44,131	11,923 (+1%)	5,446	5,448 (+1%)	5,372
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (-2%)	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,526	419 (-4%)	200	227 (-2%)	268 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,772	1,576	723 (-2%)	785 (+2%)	797

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,460	9,476
l1_rollup_execution_gas	610,285	610,281	610,297
l2_block_processing_time_in_ms	752 (+1%)	1,413	2,676
l2_block_building_time_in_ms	25,419	51,066	99,895
l2_block_rollup_simulation_time_in_ms	25,322	50,764	99,541
l2_block_public_tx_process_time_in_ms	21,757	46,992	95,829

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	6,945 (-1%)	9,894 (+1%)
node_database_size_in_bytes	12,157,008	16,093,264
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	130	468 (-15%)	12,650 (-1%)	20,634	67,190	92,352	2,819	524,288
private-kernel-inner	391 (-1%)	946 (-1%)	49,375 (-4%)	94,902	67,190	92,352	2,819	2,097,152
private-kernel-tail	371	2,073 (+1%)	50,325 (-4%)	99,121	71,733	14,912	399	2,097,152
base-parity	6.24	1,807 (-3%)	2,720 (-4%)	128	64.0	2,208	2.00	131,072
root-parity	48.8	66.4 (+1%)	41,755 (+2%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,895	4,282 (-3%)	84,266 (-3%)	170,330	756	3,648	47.0	4,194,304
root-rollup	109 (-1%)	79.5	24,547 (+7%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	712 (-10%)	3,222 (-1%)	45,932 (-1%)	116,905	93,334	125,344	3,850	2,097,152
public-kernel-app-logic	614	4,012 (-5%)	47,073 (+2%)	116,905	93,334	125,344	3,850	2,097,152
public-kernel-tail	1,408 (-1%)	36,680	191,627 (-2%)	511,910	10,014	14,912	399	8,388,608
private-kernel-reset-small	593	1,899 (-15%)	45,438 (-6%)	123,313	67,190	92,352	2,819	2,097,152
public-kernel-teardown	616	4,073 (-2%)	46,219 (-2%)	116,905	93,334	125,344	3,850	2,097,152
merge-rollup	28.9	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	6,686 (-1%)	100,279 (-1%)	N/A	N/A	125,344	3,850	4,194,304
avm-circuit	N/A	N/A	3,861 (-6%)	N/A	N/A	87,734	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	401 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	40.0	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,773	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	944 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,417	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,832 (-1%)	16,768	55,604 (-3%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,640 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	349 (-1%)	16,768	11,147 (-3%)	524,288	457
Token:transfer	1,312	9,944	4,786 (-2%)	16,768	52,004 (-3%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,397	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	75.9 (-5%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,967 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,930 (-1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	70.0 (+4%)	13,873
GasToken:set_portal	16.7	3,495
Token:constructor	91.9 (-5%)	24,207
FPC:constructor	61.3	13,893
GasToken:mint_public	51.9 (-2%)	10,241
Token:mint_public	69.3 (+4%)	19,216
Token:assert_minter_and_mint	202 (-11%)	13,034
AuthRegistry:set_authorized	31.8 (-8%)	7,869
FPC:prepare_fee	82.2 (-4%)	15,187
Token:transfer_public	⚠️ 31.1 (-56%)	31,425
FPC:pay_refund	⚠️ 91.0 (+52%)	20,080
Benchmarking:increment_balance	2,682	15,465
Token:_increase_public_balance	55.4 (-21%)	15,089
FPC:pay_refund_with_shielded_rebate	50.4 (-1%)	21,167

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.183 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.512	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.9 (-4%)	75.8 (+1%)	131 (+1%)	245	468
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.489 (-4%)	0.465	0.449	0.443	0.437
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.0 (-4%)	111	182 (+1%)	353	688
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.500 (-4%)	0.500	0.481	0.478	0.472
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.4 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.516 (-2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	85,672	670,983

Transaction size based on fee payment method

| Metric | |
| - | |