Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: notify Noir team on changes to ACIR format #6582

Merged
merged 3 commits into from
May 29, 2024

Conversation

TomAFrench
Copy link
Member

Seeing as there's a release freeze going in, Noir team should be notified of any ACIR serialisation changes as this will block any syncing of our code.

@TomAFrench TomAFrench requested review from vezenovm and guipublic May 21, 2024 21:39
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 70628a3fc3fa57f3ec35719b0c9f77019792d7df, compared to commit: bd0ae422e9f1b7e955c9b68b4a5238b248e128d4

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base +9,914 ❌ +5.47% +29,611 ❌ +1.67%
private_kernel_tail -2 ✅ -0.00% -4 ✅ -0.00%
private_kernel_tail_to_public -4 ✅ -0.00% -8 ✅ -0.00%
public_kernel_teardown -160 ✅ -0.07% -300 ✅ -0.04%
public_kernel_setup -160 ✅ -0.07% -300 ✅ -0.04%
public_kernel_app_logic -200 ✅ -0.08% -360 ✅ -0.05%
private_kernel_tail_to_public_simulated 0 ➖ 0.00% -4 ✅ -0.11%
public_kernel_app_logic_simulated 0 ➖ 0.00% -4 ✅ -0.11%
public_kernel_setup_simulated 0 ➖ 0.00% -4 ✅ -0.11%
public_kernel_teardown_simulated 0 ➖ 0.00% -4 ✅ -0.11%
public_kernel_tail -2,126 ✅ -0.21% -4,928 ✅ -0.13%
private_kernel_tail_simulated 0 ➖ 0.00% -2 ✅ -0.75%
public_kernel_tail_simulated 0 ➖ 0.00% -2 ✅ -0.75%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base 191,041 (+9,914) +5.47% 1,806,511 (+29,611) +1.67%
private_kernel_tail 195,031 (-2) -0.00% 1,316,885 (-4) -0.00%
private_kernel_tail_to_public 621,552 (-4) -0.00% 2,147,286 (-8) -0.00%
public_kernel_teardown 223,363 (-160) -0.07% 667,581 (-300) -0.04%
public_kernel_setup 223,157 (-160) -0.07% 667,288 (-300) -0.04%
public_kernel_app_logic 251,697 (-200) -0.08% 796,596 (-360) -0.05%
private_kernel_tail_to_public_simulated 1 (0) 0.00% 3,584 (-4) -0.11%
public_kernel_app_logic_simulated 1 (0) 0.00% 3,584 (-4) -0.11%
public_kernel_setup_simulated 1 (0) 0.00% 3,584 (-4) -0.11%
public_kernel_teardown_simulated 1 (0) 0.00% 3,584 (-4) -0.11%
public_kernel_tail 1,027,305 (-2,126) -0.21% 3,704,913 (-4,928) -0.13%
private_kernel_tail_simulated 1 (0) 0.00% 265 (-2) -0.75%
public_kernel_tail_simulated 1 (0) 0.00% 265 (-2) -0.75%

@TomAFrench TomAFrench enabled auto-merge (squash) May 22, 2024 13:44
@TomAFrench TomAFrench merged commit b826310 into master May 29, 2024
85 checks passed
@TomAFrench TomAFrench deleted the TomAFrench-patch-1 branch May 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants