-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync from noir #6138
Merged
feat: Sync from noir #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn (noir-lang/noir#4949) feat!: use `distinct` return value witnesses by default (noir-lang/noir#4951) chore(docs): adding matomo tracking (noir-lang/noir#4898) chore: fix typo in `ResolverError::AbiAttributeOutsideContract` (noir-lang/noir#4933) chore: Add test for recursing a foldable function (noir-lang/noir#4948) feat: Handle `no_predicates` attribute (noir-lang/noir#4942) fix: ensure where clauses propagated to trait default definitions (noir-lang/noir#4894) chore: Remove unnecessary `pub(super)` in interpreter (noir-lang/noir#4939)
TomAFrench
approved these changes
May 1, 2024
Just realised I can approve these myself as the bot opened the PR not me 😆 |
vezenovm
reviewed
May 1, 2024
noir-projects/noir-protocol-circuits/crates/parity-root/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/private-kernel-init-simulated/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/private-kernel-init/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/private-kernel-inner-simulated/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/private-kernel-inner/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/public-kernel-setup/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/public-kernel-tail-simulated/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/public-kernel-tail/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/public-kernel-teardown-simulated/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/public-kernel-teardown/src/main.nr
Outdated
Show resolved
Hide resolved
…t-simulated/src/main.nr
…er-simulated/src/main.nr
…-simulated/src/main.nr
…down-simulated/src/main.nr
…l-simulated/src/main.nr
…l-to-public-simulated/src/main.nr
…l-to-public/src/main.nr
…logic-simulated/src/main.nr
…logic/src/main.nr
…p-simulated/src/main.nr
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
vezenovm
approved these changes
May 1, 2024
This was referenced May 1, 2024
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: Require for all foldable functions to use distinct return (noir-lang/noir#4949)
feat!: use
distinct
return value witnesses by default (noir-lang/noir#4951)chore(docs): adding matomo tracking (noir-lang/noir#4898)
chore: fix typo in
ResolverError::AbiAttributeOutsideContract
(noir-lang/noir#4933)chore: Add test for recursing a foldable function (noir-lang/noir#4948)
feat: Handle
no_predicates
attribute (noir-lang/noir#4942)fix: ensure where clauses propagated to trait default definitions (noir-lang/noir#4894)
chore: Remove unnecessary
pub(super)
in interpreter (noir-lang/noir#4939)END_COMMIT_OVERRIDE