Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6007

Merged
merged 5 commits into from
Apr 24, 2024
Merged

feat: Sync from noir #6007

merged 5 commits into from
Apr 24, 2024

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: Nested array equality (noir-lang/noir#4903)
feat: Handle BrilligCall opcodes in the debugger (noir-lang/noir#4897)
chore: Release Noir(0.28.0) (noir-lang/noir#4776)
feat: Sync from aztec-packages (noir-lang/noir#4902)
END_COMMIT_OVERRIDE

@TomAFrench TomAFrench enabled auto-merge (squash) April 24, 2024 18:26
@TomAFrench TomAFrench merged commit 3b91791 into master Apr 24, 2024
60 of 62 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch April 24, 2024 18:28
@AztecBot
Copy link
Collaborator Author

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,820 6,820 6,844
l1_rollup_execution_gas 587,301 587,301 587,325
l2_block_processing_time_in_ms 1,479 (+1%) 5,417 (-2%) 10,467 (-2%)
note_successful_decrypting_time_in_ms 161 (+5%) 586 (-1%) 1,147 (+8%)
note_trial_decrypting_time_in_ms 48.9 (+9%) 84.4 (-5%) 29.0 (+17%)
l2_block_building_time_in_ms 19,021 74,055 (+1%) 147,571
l2_block_rollup_simulation_time_in_ms 18,800 73,279 146,052
l2_block_public_tx_process_time_in_ms 8,625 33,593 67,068

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,444 (+1%) 31,042 (+2%)
note_history_successful_decrypting_time_in_ms 1,372 (-2%) 2,665 (+1%)
note_history_trial_decrypting_time_in_ms 85.4 (-35%) 130 (+62%)
node_database_size_in_bytes 19,152,976 35,860,560
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 157 47,763 31,978
private-kernel-inner 178 (+1%) 80,794 31,978
private-kernel-ordering 138 (+1%) 57,732 50,043
base-parity 74.2 128 265
root-parity 127 (-2%) 1,244 265
base-rollup 12,395 (+1%) 110,926 957
root-rollup 50.1 (+1%) 4,551 821
public-kernel-app-logic 1,664 (+1%) 62,017 52,067
public-kernel-tail 4,231 (-1%) 168,566 7,491
merge-rollup 3,190 (+1%) 2,760 957
public-kernel-teardown 112 62,017 52,067
public-kernel-setup 119 (+1%) 62,017 52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.1 17.9 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.642 0.551 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.3 (-2%) 81.2 260 (-2%) 505 (+1%) 987 (-1%) 1,955 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.525 (-2%) 0.501 0.473 (-2%) 0.472 (+1%) 0.469 (-2%) 0.466 (-2%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 60.7 (-1%) 120 (-1%) 383 (-1%) 738 1,477 (-1%) 2,935 (-2%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.534 (-1%) 0.538 (-1%) 0.517 (-1%) 0.508 0.511 (-2%) 0.510 (-2%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.7 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.589 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,411 543,524

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,301 (+3%) 874 (+1%) 3,580 (+1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 839 (+1%) 772 (+1%) 1,373 (+1%) 908 2,099 (+1%) 1,092

TomAFrench added a commit that referenced this pull request Apr 24, 2024
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: Nested array equality (noir-lang/noir#4903)
feat: Handle `BrilligCall` opcodes in the debugger
(noir-lang/noir#4897)
chore: Release Noir(0.28.0)
(noir-lang/noir#4776)
feat: Sync from aztec-packages
(noir-lang/noir#4902)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
TomAFrench added a commit that referenced this pull request Apr 24, 2024
* master:
  feat: Sync from noir (#6007)
  feat: AES oracle (#5996)
  hotfix: better docker prune
  feat: add the storage layout to the contract artifact (#5952)
  feat: serialize public kernel private inputs (#5971)
  fix: refuse to start sequencer without a prover (#6000)
  chore(ci): hotfix runners not starting
  fix: Use correct gates diff commit now that master has been reset (#6004)
  chore: Reset noir-gates-diff report on master  (#6003)
  feat: Sync from noir (#5999)
  fix: make discv5 test deterministic (#5968)
  chore: Clean up and clarify some translator flavor logic (#5965)
  chore(ci): back to on-demand (#5998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants