fix: Fix and reenable fees e2e tests

[spalladino]

Fixes fees, dapp subscription, and bench tx e2e tests, and reverts #5874 to reenable them on CI.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (8): 114 (-42%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,796	6,832
l1_rollup_execution_gas	587,313	587,277	587,313
l2_block_processing_time_in_ms	1,437	5,474 (+2%)	10,415 (-1%)
note_successful_decrypting_time_in_ms	⚠️ 114 (-42%)	394	776 (-4%)
note_trial_decrypting_time_in_ms	102 (+19%)	91.2 (-1%)	84.9 (-27%)
l2_block_building_time_in_ms	18,755 (-3%)	73,111 (-3%)	145,896 (-4%)
l2_block_rollup_simulation_time_in_ms	18,547 (-3%)	72,355 (-3%)	144,419 (-4%)
l2_block_public_tx_process_time_in_ms	8,519 (-4%)	33,177 (-4%)	66,511 (-5%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,938	30,713
note_history_successful_decrypting_time_in_ms	1,004 (+12%)	1,817
note_history_trial_decrypting_time_in_ms	122 (+1%)	128
node_database_size_in_bytes	19,136,592	35,835,984
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	157 (-1%)	47,815	31,978
private-kernel-inner	178 (-2%)	80,846	31,978
private-kernel-ordering	137 (-1%)	57,732	49,888
base-parity	72.5 (-3%)	128	265
root-parity	131 (+2%)	1,244	265
base-rollup	12,304 (-1%)	110,926	957
root-rollup	49.9	4,551	821
public-kernel-app-logic	1,649 (-5%)	62,069	52,067
public-kernel-tail	4,218 (-3%)	168,566	7,491
merge-rollup	3,136	2,760	957
public-kernel-teardown	112 (-8%)	62,069	52,067
public-kernel-setup	118 (-2%)	62,069	52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.1 (+1%)	17.8 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.644 (+1%)	0.550	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.0	80.3 (-1%)	260 (-1%)	505 (+1%)	977 (-1%)	1,941 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.532	0.495 (-1%)	0.475 (-1%)	0.471 (+1%)	0.465 (-1%)	0.465	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.6 (-1%)	119	375	746 (+1%)	1,462	2,911	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.535 (-1%)	0.539 (+1%)	0.511	0.512 (+1%)	0.507	0.507	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.8
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.591

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,450 (-1%)	537,961

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,236 (-4%)	870 (-3%)	3,539

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	838 (-4%)	695 (-1%)	1,357 (-2%)	909 (-2%)	2,089 (-2%)	1,165 (-1%)

[just-mitch]

Changes seem innocuos at a glance: why was there was a problem without these?

[spalladino]

Changes seem innocuos at a glance: why was there was a problem without these?

In #5828 I didn't wire all gas parameters, so I'm using defaults in several places. These include defaulting to about 1e9 gas for any gasLeft in public executions. This failed in these tests that set a total gasLimit below gasLeft, which should not be possible.