chore: nuking CLI

[benesjan]

Fixes #5894

[benesjan]

• chore: nuking CLI #5865 👈
• refactor: integrate new key store #5731
• feat: impl of missing functionality in new key store #5750
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://66261161ba35a763f12e455a--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 51.3 (+180%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,820	6,844
l1_rollup_execution_gas	587,313	587,301	587,325
l2_block_processing_time_in_ms	1,497 (-3%)	5,383 (-3%)	10,045 (-5%)
note_successful_decrypting_time_in_ms	164 (+21%)	468 (-3%)	697 (-12%)
note_trial_decrypting_time_in_ms	⚠️ 51.3 (+180%)	64.6 (-20%)	105 (+7%)
l2_block_building_time_in_ms	18,903	73,412	146,904
l2_block_rollup_simulation_time_in_ms	18,696	72,663	145,262
l2_block_public_tx_process_time_in_ms	8,544	33,245 (-1%)	66,548

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,580 (-3%)	30,051
note_history_successful_decrypting_time_in_ms	880 (-6%)	1,693 (-5%)
note_history_trial_decrypting_time_in_ms	34.3 (-29%)	113 (-14%)
node_database_size_in_bytes	19,132,496	35,774,544
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	156	47,815	31,978
private-kernel-inner	177	80,846	31,978
private-kernel-ordering	137	57,732	49,888
base-parity	73.8 (-4%)	128	265
root-parity	126 (-4%)	1,244	265
base-rollup	12,380 (+1%)	110,926	957
root-rollup	50.8 (+2%)	4,551	821
public-kernel-app-logic	1,659	62,069	52,067
public-kernel-tail	4,234	168,566	7,491
merge-rollup	3,186 (+2%)	2,760	957
public-kernel-teardown	117 (+4%)	62,069	52,067
public-kernel-setup	127 (+7%)	62,069	52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0	17.8 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.641	0.549 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.1 (-1%)	80.1 (-1%)	258	501	980 (-1%)	1,936	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.523 (-1%)	0.494	0.470	0.469	0.465	0.464	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.0 (-1%)	118 (-1%)	373 (-1%)	733 (-1%)	1,465 (-1%)	2,908 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.532	0.531 (-1%)	0.509	0.505 (-1%)	0.506 (-1%)	0.507 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.1 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.586 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,450	537,961

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,229 (-3%)	860 (-1%)	3,468 (-2%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	836 (-1%)	691 (-2%)	1,343 (-2%)	906 (-2%)	2,058 (-2%)	1,166 (-1%)

[sklppy88]

👍

[sklppy88]

Why was this added ? Is it necessary / desired ?

[benesjan]

This was a mistake. Nuked in 69e7317