refactor: nuking L2BlockContext

[benesjan]

Fixes #5534

[benesjan]

• refactor: nuking L2BlockContext #5569 👈
• feat: debugLog(...) in noir-protocol-circuits #5568
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (64): 107 (+230%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a07bb922 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,424	6,412 (+1%)
l1_rollup_execution_gas	585,745	585,757	585,745
l2_block_processing_time_in_ms	1,292 (-3%)	4,884 (-4%)	10,234 (+9%)
note_successful_decrypting_time_in_ms	249 (+9%)	638 (+2%)	988 (-3%)
note_trial_decrypting_time_in_ms	52.2 (+57%)	49.7 (+47%)	⚠️ 107 (+230%)
l2_block_building_time_in_ms	12,018	43,691 (+1%)	85,324
l2_block_rollup_simulation_time_in_ms	7,210 (+1%)	24,841 (+1%)	47,546 (+1%)
l2_block_public_tx_process_time_in_ms	4,771 (-1%)	18,725	37,508

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,947 (-1%)	27,497
note_history_successful_decrypting_time_in_ms	1,229	2,537 (+7%)
note_history_trial_decrypting_time_in_ms	70.1 (+5%)	121 (+11%)
node_database_size_in_bytes	18,636,880	34,889,808
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	180 (-2%)	44,377	26,164
private-kernel-ordering	162 (-2%)	50,830	39,325
base-parity	4,215 (+2%)	128	311
root-parity	1,146	1,244	311
base-rollup	14,492	116,608	861
root-rollup	50.3 (-1%)	4,359	725
private-kernel-inner	217 (-3%)	71,744	26,164
public-kernel-app-logic	120	47,695	40,661
public-kernel-tail	163	53,372	13,269
merge-rollup	10.2 (+5%)	2,568	861
public-kernel-teardown	117 (-1%)	47,695	40,661
public-kernel-setup	116 (-1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.3 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.588	0.500	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.1	72.5 (-1%)	232 (-1%)	450 (+1%)	879	1,740	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.472	0.446 (-1%)	0.422 (-2%)	0.420 (+1%)	0.417	0.415 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.6	108	340	667 (+1%)	1,320 (-1%)	2,642	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480	0.483 (-1%)	0.459 (-1%)	0.458 (+1%)	0.455 (-2%)	0.457	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.8
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.536

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,548	501,142

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,724 (+1%)	1,085 (-2%)	5,492 (+1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	578	442 (+2%)	1,081 (+2%)	538 (+3%)	1,775 (+2%)	595 (+2%)

[sklppy88]

Love this change, a super nit, but feel free to merge if disagree. 👍

[sklppy88]

Super nitty, but would rather explicitly check for 0, and not coerce to 0 here, and would put the no blocks case in front of the !== case, if this happens at at least a magnitude more often than the other.

[benesjan]

Makes sense to have there the explicit check for 0 but it doesn't make sense to have it before the other check because that other check detects an incorrect behavior in the system and it makes sense to check that even when the blocks length is 0.

1196ebc

[sklppy88]

Good call, I did not realize 👍