Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tell user they need to pip install clang. #5525

Closed
wants to merge 12 commits into from

Conversation

charlielye
Copy link
Contributor

Please read contributing guidelines and remove this line.

Copy link
Contributor Author

charlielye commented Apr 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @charlielye and the rest of your teammates on Graphite Graphite

@AztecBot
Copy link
Collaborator

AztecBot commented Apr 1, 2024

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (base-parity): 6,278 (+49%)
  • circuit_simulation_time_in_ms (root-parity): 1,997 (+80%)
  • circuit_simulation_time_in_ms (base-rollup): 17,192 (+19%)
  • circuit_input_size_in_bytes (base-rollup): 165,760 (+42%)
  • circuit_input_size_in_bytes (public-kernel-app-logic): 35,252 (-26%)
  • circuit_input_size_in_bytes (public-kernel-tail): 40,928 (-23%)
  • circuit_input_size_in_bytes (public-kernel-teardown): 35,252 (-26%)
  • circuit_input_size_in_bytes (public-kernel-setup): 35,252 (-26%)
  • circuit_output_size_in_bytes (private-kernel-ordering): 14,296 (-64%)
  • circuit_output_size_in_bytes (public-kernel-app-logic): 28,217 (-31%)
  • circuit_output_size_in_bytes (public-kernel-tail): 28,217 (+113%)
  • circuit_output_size_in_bytes (public-kernel-teardown): 28,217 (-31%)
  • circuit_output_size_in_bytes (public-kernel-setup): 28,217 (-31%)
  • tx_pxe_processing_time_ms (1): 1,252 (+16%)
  • tx_sequencer_processing_time_ms (5): 2,125 (+21%)
  • tx_size_in_bytes (0): 14,968 (-63%)
  • batch_insert_into_indexed_tree_20_depth_ms (64): 83.7 (+55%)
  • node_history_sync_time_in_ms (5): 98,977 (+586%)
  • node_history_sync_time_in_ms (10): 291,119 (+947%)
  • note_history_successful_decrypting_time_in_ms (5): 1,529 (+18%)
  • note_history_successful_decrypting_time_in_ms (10): 3,137 (+28%)
  • l2_block_rollup_simulation_time_in_ms (8): 8,369 (+18%)
  • l2_block_rollup_simulation_time_in_ms (32): 28,967 (+18%)
  • l2_block_rollup_simulation_time_in_ms (64): 56,648 (+20%)
  • note_trial_decrypting_time_in_ms (8): 98.9 (+156%)
  • note_trial_decrypting_time_in_ms (32): 121 (+191%)
  • note_trial_decrypting_time_in_ms (64): 151 (+286%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d531b259 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,400 6,388 (-1%) 6,400
l1_rollup_execution_gas 585,733 585,721 585,733
l2_block_processing_time_in_ms 1,192 (-14%) 4,475 (-5%) 8,930 (-6%)
note_successful_decrypting_time_in_ms 208 (-12%) 568 (-10%) 1,110 (+9%)
note_trial_decrypting_time_in_ms ⚠️ 98.9 (+156%) ⚠️ 121 (+191%) ⚠️ 151 (+286%)
l2_block_building_time_in_ms 13,231 (+11%) 48,032 (+11%) 94,326 (+11%)
l2_block_rollup_simulation_time_in_ms ⚠️ 8,369 (+18%) ⚠️ 28,967 (+18%) ⚠️ 56,648 (+20%)
l2_block_public_tx_process_time_in_ms 4,816 18,987 (+1%) 37,558

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms ⚠️ 98,977 (+586%) ⚠️ 291,119 (+947%)
note_history_successful_decrypting_time_in_ms ⚠️ 1,529 (+18%) ⚠️ 3,137 (+28%)
note_history_trial_decrypting_time_in_ms 40.4 (-68%) 93.5 (-13%)
node_database_size_in_bytes 18,636,880 35,110,992 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 184 (+2%) 44,379 28,214 (+8%)
private-kernel-ordering 172 (+7%) 52,880 (+4%) ⚠️ 14,296 (-64%)
base-parity ⚠️ 6,278 (+49%) 128 311
root-parity ⚠️ 1,997 (+80%) 1,244 311
base-rollup ⚠️ 17,192 (+19%) ⚠️ 165,760 (+42%) 861
root-rollup 49.7 4,359 725
private-kernel-inner 224 (+3%) 73,795 (+3%) 28,214 (+8%)
public-kernel-app-logic 94.9 (-20%) ⚠️ 35,252 (-26%) ⚠️ 28,217 (-31%)
public-kernel-tail 138 (-16%) ⚠️ 40,928 (-23%) ⚠️ 28,217 (+113%)
merge-rollup 7.57 (-26%) 2,568 861
public-kernel-teardown 93.2 (-21%) ⚠️ 35,252 (-26%) ⚠️ 28,217 (-31%)
public-kernel-setup 91.7 (-22%) ⚠️ 35,252 (-26%) ⚠️ 28,217 (-31%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 16.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.586 0.494 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 47.4 (+3%) 71.8 (-1%) 238 (+3%) 454 (+2%) 867 1,720 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.486 (+3%) 0.443 (-1%) 0.432 (+3%) 0.421 (+1%) 0.411 (-1%) 0.412 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A ⚠️ 83.7 (+55%) 109 (+2%) 357 (+6%) 665 (+1%) 1,380 (+5%) 2,767 (+5%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.480 0.480 0.455 (-1%) 0.456 (+1%) 0.452 (-1%) 0.454 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 74.7 (+22%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.536

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes ⚠️ 14,968 (-63%) 495,320 (-1%)

Transaction size based on fee payment method

Metric none fee payment method native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 773 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,804 (+6%) ⚠️ 1,252 (+16%) 5,785 (+7%)
Metric 0 public data writes 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 9.79 580 (+1%) 496 (-9%) 1,233 (+14%) 505 (-4%) ⚠️ 2,125 (+21%) 593 (+1%)

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Changes to circuit sizes

Generated at commit: aacd5ccea99da0477334d35adac900bc0dc51bcf, compared to commit: 77efd5ddaaad42e7ae364e9a0695fc49ffd88746

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup +26 ❌ +0.05% +83 ❌ +0.03%
public_kernel_teardown +26 ❌ +0.05% +83 ❌ +0.03%
public_kernel_app_logic +29 ❌ +0.04% +92 ❌ +0.03%
private_kernel_init +19 ❌ +0.04% +57 ❌ +0.02%
private_kernel_inner +17 ❌ +0.02% +56 ❌ +0.01%
private_kernel_tail_to_public +19 ❌ +0.00% +53 ❌ +0.01%
private_kernel_tail +9 ❌ +0.00% +27 ❌ +0.00%
public_kernel_tail +15 ❌ +0.00% +44 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup 54,813 (+26) +0.05% 261,848 (+83) +0.03%
public_kernel_teardown 54,924 (+26) +0.05% 261,959 (+83) +0.03%
public_kernel_app_logic 66,983 (+29) +0.04% 332,612 (+92) +0.03%
private_kernel_init 48,534 (+19) +0.04% 348,483 (+57) +0.02%
private_kernel_inner 95,798 (+17) +0.02% 519,926 (+56) +0.01%
private_kernel_tail_to_public 423,674 (+19) +0.00% 1,003,692 (+53) +0.01%
private_kernel_tail 239,914 (+9) +0.00% 589,180 (+27) +0.00%
public_kernel_tail 415,743 (+15) +0.00% 1,035,505 (+44) +0.00%

@charlielye charlielye changed the base branch from cl/mem_kv_store to cl/e2e_jest April 9, 2024 18:45
@charlielye charlielye force-pushed the cl/e2e_jest branch 3 times, most recently from 1a5b76b to 9c47572 Compare April 12, 2024 16:19
Base automatically changed from cl/e2e_jest to master April 12, 2024 17:34
@charlielye charlielye closed this Apr 30, 2024
@ludamad ludamad deleted the cl/bb_bindgen_help branch August 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants