refactor: clean up compute_next_accumulator

[lucasxia01]

Partially addresses AztecProtocol/barretenberg#881.

Cuts down on accumulator_update_round time by 300ms!

--------------------------------------------------------------------------------
Benchmark                      Time             CPU   Iterations UserCounters...
--------------------------------------------------------------------------------
ClientIVCBench/Full/6      22272 ms        17339 ms            1 Decider::construct_proof=1 Decider::construct_proof(t)=752.81M ECCVMComposer::compute_commitment_key=1 ECCVMComposer::compute_commitment_key(t)=3.74397M ECCVMComposer::compute_witness=1 ECCVMComposer::compute_witness(t)=131.409M ECCVMComposer::create_prover=1 ECCVMComposer::create_prover(t)=151.452M ECCVMComposer::create_proving_key=1 ECCVMComposer::create_proving_key(t)=16.0709M ECCVMProver::construct_proof=1 ECCVMProver::construct_proof(t)=1.76787G Goblin::merge=11 Goblin::merge(t)=144.332M GoblinTranslatorCircuitBuilder::constructor=1 GoblinTranslatorCircuitBuilder::constructor(t)=58.9093M GoblinTranslatorProver=1 GoblinTranslatorProver(t)=164.575M GoblinTranslatorProver::construct_proof=1 GoblinTranslatorProver::construct_proof(t)=958.34M ProtoGalaxyProver_::accumulator_update_round=10 ProtoGalaxyProver_::accumulator_update_round(t)=292.705M ProtoGalaxyProver_::combiner_quotient_round=10 ProtoGalaxyProver_::combiner_quotient_round(t)=5.96917G ProtoGalaxyProver_::perturbator_round=10 ProtoGalaxyProver_::perturbator_round(t)=1.30937G ProtoGalaxyProver_::preparation_round=10 ProtoGalaxyProver_::preparation_round(t)=4.18574G ProtogalaxyProver::fold_instances=10 ProtogalaxyProver::fold_instances(t)=11.757G ProverInstance(Circuit&)=11 ProverInstance(Circuit&)(t)=1.99482G batch_mul_with_endomorphism=30 batch_mul_with_endomorphism(t)=566.111M commit=426 commit(t)=4.0365G compute_combiner=10 compute_combiner(t)=5.96705G compute_perturbator=9 compute_perturbator(t)=1.30905G compute_univariate=48 compute_univariate(t)=1.42119G construct_circuits=6 construct_circuits(t)=4.49152G
Benchmarking lock deleted.
client_ivc_bench.json                                                            100% 3992   123.3KB/s   00:00    
function                                        ms     % sum
construct_circuits(t)                         4492    20.40%
ProverInstance(Circuit&)(t)                   1995     9.06%
ProtogalaxyProver::fold_instances(t)         11757    53.40%
Decider::construct_proof(t)                    753     3.42%
ECCVMComposer::create_prover(t)                151     0.69%
ECCVMProver::construct_proof(t)               1768     8.03%
GoblinTranslatorProver::construct_proof(t)     958     4.35%
Goblin::merge(t)                               144     0.66%

Total time accounted for: 22018ms/22272ms = 98.86%

Major contributors:
function                                        ms    % sum
commit(t)                                     4037   18.33%
compute_combiner(t)                           5967   27.10%
compute_perturbator(t)                        1309    5.95%
compute_univariate(t)                         1421    6.45%

Breakdown of ProtogalaxyProver::fold_instances:
ProtoGalaxyProver_::preparation_round(t)           4186    35.60%
ProtoGalaxyProver_::perturbator_round(t)           1309    11.14%
ProtoGalaxyProver_::combiner_quotient_round(t)     5969    50.77%
ProtoGalaxyProver_::accumulator_update_round(t)     293     2.49%

Please read contributing guidelines and remove this line.

[lucasxia01]

avoid calling default Instance and instead directly move the first instance

[AztecBot]

Benchmark results

Metrics with a significant change:

• tx_sequencer_processing_time_ms (2): 519 (+16%)
• note_successful_decrypting_time_in_ms (8): 261 (+31%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5d1fb44f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,412	6,412
l1_rollup_execution_gas	585,745	585,745	585,745
l2_block_processing_time_in_ms	1,323 (+2%)	4,732 (-1%)	9,405 (+3%)
note_successful_decrypting_time_in_ms	⚠️ 261 (+31%)	623	994 (-7%)
note_trial_decrypting_time_in_ms	67.0 (-35%)	42.5 (+8%)	125 (+39%)
l2_block_building_time_in_ms	12,288 (-1%)	44,816 (-1%)	90,724 (+2%)
l2_block_rollup_simulation_time_in_ms	7,498	26,021	51,846 (+1%)
l2_block_public_tx_process_time_in_ms	4,762 (-1%)	18,743 (-3%)	38,781 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,245 (+9%)	27,825 (+4%)
note_history_successful_decrypting_time_in_ms	1,294 (-1%)	2,453
note_history_trial_decrypting_time_in_ms	93.0 (+5%)	152 (+3%)
node_database_size_in_bytes	18,632,784	35,029,072
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	185 (+2%)	44,379	28,214
private-kernel-ordering	171 (+1%)	52,880	14,296
base-parity	3,700 (+3%)	128	311
root-parity	1,354 (+1%)	1,244	311
base-rollup	15,210 (+2%)	165,760	861
root-rollup	50.1 (+2%)	4,359	725
private-kernel-inner	229 (+1%)	73,795	28,214
public-kernel-app-logic	96.9 (+2%)	35,252	28,217
public-kernel-tail	140 (+1%)	40,928	28,217
merge-rollup	10.3 (+12%)	2,568	861
public-kernel-teardown	92.0 (-1%)	35,252	28,217
public-kernel-setup	90.5 (-1%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (+2%)	16.5 (+3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.597 (+2%)	0.509 (+3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.7 (+1%)	75.3 (+3%)	233 (-1%)	462 (+4%)	873 (-2%)	1,736 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.478 (+1%)	0.464 (+3%)	0.423 (-1%)	0.431 (+4%)	0.415 (-2%)	0.414 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.8 (+1%)	111 (+4%)	336	688 (+5%)	1,310 (-1%)	2,615	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.482 (+1%)	0.501 (+4%)	0.457	0.472 (+4%)	0.455	0.454	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	62.4 (+2%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.544 (+2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,320

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,860 (+3%)	1,217 (+1%)	5,648 (-1%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	9.76 (-2%)	590 (+2%)	⚠️ 519 (+16%)	1,164 (-1%)	593	2,013 (-1%)	562