feat: detect unknown note type ids in compute_note_hash

[nventuro]

Closes #4520.

I did some work adding tests for this, but ultimately decided to go back on it. We don't really have any tests for other parts of the addNotes flow (such as the checks for note existence, inclusion in the provided tx, non-nullification, etc.), and this didn't feel like the right place to work on those.

We definitely should however. Part of the problem is that writing a contract that allows for manual note creation, deletion and retrieval from a test is quite annoying - I did some of this in TestContract for #4238. For this we'd also need to have different functions for different note types, and even then some of these notes can only be added automatically via broadcast due to the random values in the note.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 717 (+32%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 507c374b and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,564	238,892	469,376
l1_rollup_execution_gas	674,027	979,713	1,388,150
l2_block_processing_time_in_ms	1,193	4,476	8,915
note_successful_decrypting_time_in_ms	203	⚠️ 717 (+32%)	1,020 (+3%)
note_trial_decrypting_time_in_ms	10.0 (-6%)	45.1 (-26%)	33.3 (-72%)
l2_block_building_time_in_ms	11,985	47,327 (-1%)	95,422 (-1%)
l2_block_rollup_simulation_time_in_ms	7,298	28,919 (-1%)	58,583 (-1%)
l2_block_public_tx_process_time_in_ms	4,658	18,347	36,703

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,182 (-5%)	28,100 (+5%)
note_history_successful_decrypting_time_in_ms	1,238 (+1%)	2,371 (-1%)
note_history_trial_decrypting_time_in_ms	87.2 (+8%)	100 (-31%)
node_database_size_in_bytes	18,780,240	35,549,264
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	252	44,736	28,001
private-kernel-ordering	196 (+1%)	52,625	14,627
base-rollup	656	177,932	997
root-rollup	69.2 (+1%)	4,320	825
private-kernel-inner	320	73,715	28,001
public-kernel-app-logic	164	34,920	27,972
public-kernel-tail	82.1	34,507	27,972
merge-rollup	8.54 (-8%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.72 (-1%)	10.5 (+2%)	14.7 (-13%)	16.4 (-1%)	21.8 (-1%)	35.6	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.565	0.581 (+2%)	0.625 (-12%)	0.508 (-1%)	0.457 (-1%)	0.442	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.6 (-2%)	71.9 (-5%)	230	452 (+1%)	865	1,729
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.468 (-2%)	0.444 (-5%)	0.419 (-1%)	0.423 (+1%)	0.412	0.414
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.6 (+2%)	106 (-5%)	342 (+1%)	663 (+1%)	1,304	2,600
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.487 (+2%)	0.479 (-5%)	0.464 (+1%)	0.457 (+1%)	0.454	0.452
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	60.9	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.533	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,701	1,377

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	6.43 (+14%)	574

[nventuro]

CI is failing due to imports on the boxes, which seems entirely unrelated.