Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update protogalaxy cmake dependencies #5066

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: update protogalaxy cmake dependencies #5066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/protogalaxy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
barretenberg_module(protogalaxy honk flavor relations sumcheck)
barretenberg_module(protogalaxy ultra_honk flavor relations sumcheck)
0 ...retenberg/ultra_honk/protogalaxy.test.cpp → ...etenberg/protogalaxy/protogalaxy.test.cpp
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/recursion/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
barretenberg_module(stdlib_recursion ecc proof_system stdlib_primitives stdlib_pedersen_commitment stdlib_blake3s ultra_honk eccvm translator_vm stdlib_poseidon2 circuit_checker)
barretenberg_module(stdlib_recursion ecc proof_system stdlib_primitives stdlib_pedersen_commitment stdlib_blake3s protogalaxy eccvm translator_vm stdlib_poseidon2 circuit_checker)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe could keep both in here. Is there no impact if we link ultra_honk twice?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no impact

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh, doesn't seem to matter that much, so I left it unchanged

2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/ultra_honk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
barretenberg_module(ultra_honk honk sumcheck protogalaxy)
barretenberg_module(ultra_honk honk sumcheck)
Loading