Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address warnings in noir test suite #4966

Merged
merged 2 commits into from
Mar 7, 2024
Merged

chore: address warnings in noir test suite #4966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc9f7d1
chore: address warnings in test suite
TomAFrench Mar 5, 2024
d09ec20
Update noir-projects/noir-protocol-circuits/crates/public-kernel-lib/…
TomAFrench Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion noir-projects/noir-protocol-circuits/crates/public-kernel-lib/src/common.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ fn propagate_new_nullifiers(
fn propagate_new_l2_to_l1_messages(public_call: PublicCallData, public_inputs: &mut PublicKernelCircuitPublicInputsBuilder) {
// new l2 to l1 messages
let public_call_public_inputs = public_call.call_stack_item.public_inputs;
let portal_contract_address = public_call.portal_contract_address;
let storage_contract_address = public_call_public_inputs.call_context.storage_contract_address;

let new_l2_to_l1_msgs = public_call_public_inputs.new_l2_to_l1_msgs;
Expand Down
4 changes: 2 additions & 2 deletions noir-projects/noir-protocol-circuits/crates/public-kernel-lib/src/public_kernel_setup.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,11 +412,11 @@ mod tests {

builder.public_call.append_update_requests(2);
let storage = builder.get_current_public_data_update_requests();
let update_requests = [storage[0], storage[1]];
let _update_requests = [storage[0], storage[1]];

builder.public_call.append_public_data_read_requests(3);
let storage = builder.get_current_public_data_reads();
let read_requests = [storage[0], storage[1], storage[2]];
let _read_requests = [storage[0], storage[1], storage[2]];

// Push the public call on top of the teardown call.
let setup_call = builder.public_call.finish();
Expand Down
2 changes: 2 additions & 0 deletions noir-projects/noir-protocol-circuits/crates/rollup-lib/src/base/base_rollup_inputs.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ impl BaseRollupInputs {

// Cpp code says calculate_contract_subtree, so I'm leaving it as is for now
fn calculate_contract_subtree_root(self, leaves: [Field; MAX_NEW_CONTRACTS_PER_TX]) -> Field {
// Silence warning for unused self, pending proper fix.
let _ = self;
assert_eq(leaves.len(), 1);
leaves[0]
}
Expand Down
2 changes: 2 additions & 0 deletions noir-projects/noir-protocol-circuits/crates/types/src/tests/merkle_tree_utils.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ impl<SUBTREE_ITEMS, TREE_HEIGHT, SUPERTREE_HEIGHT, SUBTREE_HEIGHT> NonEmptyMerkl
}

pub fn get_next_available_index(self) -> Field {
// Silence warning for unused self, pending proper fix.
let _ = self;
SUBTREE_ITEMS
}
}
Expand Down
Loading