Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address comments #4772

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ std::vector<ECCOpQueue::ECCVMOperation> parse_operations(const unsigned char* da
}

/**
* @brief Try to parse out the batching and evaluating challenges and then the ECCOpQUeue from the data
* @brief Try to parse out the batching and evaluating challenges and then the ECCOpQueue from the data
*
* @param data pointer to the buffer
* @param size size of the buffer
Expand Down Expand Up @@ -79,6 +79,6 @@ std::optional<std::tuple<Fq, Fq, std::shared_ptr<ECCOpQueue>>> parse_and_constru
ecc_op_queue->raw_ops = raw_ops;
ecc_op_queue->mul_accumulate(padding_element, padding_scalar);

// Create circuit builder and feed the queue inside
// Return the batching challenge, evaluation challenge and the constructed queue
return std::make_tuple(batching_challenge, x, ecc_op_queue);
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data, size_t size)
{
// Parse the queue and challenges
// TODO(Rumata888): composer generates the initial challenge through FS, so we have to do that, too
// TODO(https://github.com/AztecProtocol/barretenberg/issues/869): composer generates the initial challenge through
// FS, so we have to do that, too
auto parsing_result = parse_and_construct_opqueue(data, size);
if (!parsing_result.has_value()) {
return 0;
Expand Down
Loading