Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 block publisher #45

Merged
merged 12 commits into from
Mar 23, 2023
Merged

L2 block publisher #45

merged 12 commits into from
Mar 23, 2023

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Mar 14, 2023

Description

Initial version of the L2 block publisher (formerly rollup publisher), required for the Sequencer. The code is mostly ported from AC, which should be good for the local devnet. It uses aztec/ethereum.js for connecting to the chain, though it can be swapped out with other implementation.

I included a new l1-contracts project in the yarn-project workspace, which includes ts wrappers for the L1 contracts. So far there's only a wrapper for the Rollup contract, generated using contract_gen_def.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spalladino spalladino requested a review from PhilWindle March 14, 2023 20:15
Copy link
Collaborator

@PhilWindle PhilWindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@spalladino spalladino force-pushed the palla/rollup-publisher branch 2 times, most recently from a0d6708 to 32444aa Compare March 16, 2023 14:55
@spalladino spalladino marked this pull request as ready for review March 16, 2023 15:56
@@ -3,4 +3,8 @@ require('@rushstack/eslint-patch/modern-module-resolution');
module.exports = {
extends: ['@aztec/eslint-config'],
parserOptions: { tsconfigRootDir: __dirname },
rules: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather leave the defaults but change max warnings allowed in package.json

Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalladino spalladino force-pushed the palla/rollup-publisher branch from f5e7da3 to b1cb81b Compare March 22, 2023 16:35
@PhilWindle PhilWindle merged commit 6b97f73 into master Mar 23, 2023
@charlielye charlielye deleted the palla/rollup-publisher branch March 28, 2023 21:19
ludamad pushed a commit that referenced this pull request Jul 14, 2023
Added id and last and first lagrange polynomial to the proving key in honk
ludamad pushed a commit that referenced this pull request Jul 19, 2023
ludamad pushed a commit that referenced this pull request Jul 21, 2023
codygunton pushed a commit that referenced this pull request Jan 23, 2024
Added id and last and first lagrange polynomial to the proving key in honk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants