chore: nuked OptionallyRevealedData

[benesjan]

Nuked deprecated OptionallyRevealedData.

[benesjan]

Current dependencies on/for this PR:

• master
  • PR chore: nuked OptionallyRevealedData #4456 👈

This stack of pull requests is managed by Graphite.

[github-actions]

Changes to circuit sizes

Generated at commit: ea59d47842fd71027d2df52856f5dd21bf649e4b, compared to commit: 0a8905a46fba47d1a773fd9cf562ef6f51197236

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
rollup_base	-32 ✅	-0.02%	-35 ✅	-0.00%
private_kernel_inner	-76 ✅	-0.08%	-123 ✅	-0.02%
private_kernel_ordering	-76 ✅	-0.04%	-123 ✅	-0.02%
private_kernel_init	-44 ✅	-0.12%	-88 ✅	-0.03%
public_kernel_private_previous	-76 ✅	-0.16%	-123 ✅	-0.05%
public_kernel_public_previous	-76 ✅	-0.16%	-123 ✅	-0.05%
public_kernel_public_previous_simulated	-76 ✅	-6.39%	-123 ✅	-2.45%
private_kernel_inner_simulated	-76 ✅	-6.39%	-123 ✅	-2.45%
public_kernel_private_previous_simulated	-76 ✅	-6.39%	-123 ✅	-2.45%
private_kernel_init_simulated	-76 ✅	-6.39%	-123 ✅	-2.45%
private_kernel_ordering_simulated	-76 ✅	-9.78%	-123 ✅	-2.92%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
rollup_base	128,780 (-32)	-0.02%	1,364,528 (-35)	-0.00%
private_kernel_inner	92,626 (-76)	-0.08%	519,475 (-123)	-0.02%
private_kernel_ordering	196,167 (-76)	-0.04%	504,321 (-123)	-0.02%
private_kernel_init	36,344 (-44)	-0.12%	331,141 (-88)	-0.03%
public_kernel_private_previous	46,879 (-76)	-0.16%	250,709 (-123)	-0.05%
public_kernel_public_previous	46,871 (-76)	-0.16%	250,701 (-123)	-0.05%
public_kernel_public_previous_simulated	1,113 (-76)	-6.39%	4,890 (-123)	-2.45%
private_kernel_inner_simulated	1,113 (-76)	-6.39%	4,890 (-123)	-2.45%
public_kernel_private_previous_simulated	1,113 (-76)	-6.39%	4,890 (-123)	-2.45%
private_kernel_init_simulated	1,113 (-76)	-6.39%	4,890 (-123)	-2.45%
private_kernel_ordering_simulated	701 (-76)	-9.78%	4,093 (-123)	-2.92%

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 182 (+112%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 545b3341 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,636	180,516	720,036
l1_rollup_calldata_gas	222,576	870,984	3,465,672
l1_rollup_execution_gas	315,063	988,724	3,685,329
l2_block_processing_time_in_ms	1,157	4,354 (+1%)	17,192
note_successful_decrypting_time_in_ms	311 (+2%)	978 (+2%)	3,646 (+1%)
note_trial_decrypting_time_in_ms	21.2 (+5%)	106 (+15%)	142 (+1%)
l2_block_building_time_in_ms	17,800 (-1%)	70,450	282,144 (-1%)
l2_block_rollup_simulation_time_in_ms	13,075	51,683	207,641
l2_block_public_tx_process_time_in_ms	4,700 (-2%)	18,688 (-1%)	74,241 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,787 (-10%)	26,522 (-9%)
note_history_successful_decrypting_time_in_ms	2,302 (-5%)	4,532
note_history_trial_decrypting_time_in_ms	⚠️ 182 (+112%)	213 (+6%)
node_database_size_in_bytes	17,305,680	33,042,512
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	308 (-1%)	44,476	25,773 (-1%)
private-kernel-ordering	193 (-3%)	44,093 (-1%)	16,173 (-2%)
base-rollup	1,402	128,550	881
root-rollup	82.3	4,088	677
private-kernel-inner	437 (-2%)	71,227 (-1%)	25,773 (-1%)
public-kernel-private-input	239 (-3%)	32,183 (-1%)	25,773 (-1%)
public-kernel-non-first-iteration	239 (-2%)	32,225 (-1%)	25,773 (-1%)
merge-rollup	7.58	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.6 (+6%)	12.8 (+2%)	16.9 (-1%)	23.1 (+1%)	63.5 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.593	0.651 (+6%)	0.544 (+1%)	0.523 (-1%)	0.484 (+1%)	0.439 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.1	47.5	239	460	898	3,544
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.464	0.487	0.435	0.431	0.428	0.426
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103	56.6	352 (+1%)	688	1,362	5,408
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.491	0.496	0.475	0.474	0.472	0.472
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.4	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.577	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,807 (-2%)	39,611 (-1%)

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	547 (-1%)	1,298 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.499 (-17%)	575 (-2%)

[LHerskind]

Nice to see it nuked.