docs(yellow-paper): Update kernel with changes from contract deployment #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates private kernel inputs with changes from contract deployment.
spalladino
changed the title
LeilaWang
reviewed
Feb 6, 2024
| @@ -22,8 +22,6 @@ For the _[function_data](#functiondata)_ in _[private_call](#privatecall).[call_ | |||
|
|
|||
| - It must be a private function: | |||
| - _`function_data.function_type == private`_ | |||
| - It must not be an internal function: | |||
| - _`function_data.is_internal == false`_ | |||
There was a problem hiding this comment.
Why removing this check?
There was a problem hiding this comment.
The plan is to replace it with an app-level check inside a macro: #4449
There was a problem hiding this comment.
Oh nice! The is_internal flag in function_data struct and a reference to it still exist in the yp. Maybe they can be removed in this PR altogether? 😃
There was a problem hiding this comment.
Good catch! Just removed them in 910f0fe
LeilaWang
approved these changes
Feb 6, 2024
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this pull request
Feb 28, 2024
…nt (AztecProtocol#4432) Updates private kernel inputs with changes from contract deployment. These changes were implemented in AztecProtocol#4337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates private kernel inputs with changes from contract deployment.
These changes were implemented in #4337