Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Produce graph of internal Barretenberg dependencies #4225

Merged
merged 4 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions barretenberg/cpp/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ CMakeUserPresets.json
acir_tests
# we may download go in scripts/collect_heap_information.sh
go*.tar.gz
barretenberg_modules.dot
barretenberg_modules.png
24 changes: 24 additions & 0 deletions barretenberg/cpp/scripts/barretenberg_module_digraph.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/usr/bin/env bash
set -eu

TMP=tmp.dot;
RESULT_DOT=barretenberg_modules.dot;
RESULT_PNG=barretenberg_modules.png;

# initialize a directed graph for graphviz
echo digraph BarretenbergModules { > $TMP;
Copy link
Collaborator

@ludamad ludamad Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASH does not need a final semicolon, only if you want to do two lines on one line

e..g

#!/usr/bin/env bash
set -eu

TMP=tmp.dot
RESULT_DOT=barretenberg_modules.dot
RESULT_PNG=barretenberg_modules.png

# initialize a directed graph for graphviz
echo digraph BarretenbergModules { > $TMP
# populate the directed graph
for file in $(find ./src/barretenberg/ -iname CMakeLists.txt); do
  opening_chars=$(head -c 19 "$file")
  if [ "$opening_chars" == barretenberg_module ]; then
    awk -f ./scripts/barretenberg_module_digraph_edges.awk $file >> $TMP
  fi
done
echo } >> $TMP

# apply transitive reduction to remove dependcies that are implied by satisfied by other dependencies
cat $TMP | tred > $RESULT_DOT
rm $TMP

# produce a PNG of the graph
dot -Tpng $RESULT_DOT -o $RESULT_PNG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the semicolon finger fires automatically for me now;

# populate the directed graph
for file in $(find ./src/barretenberg/ -iname CMakeLists.txt); do
opening_chars=$(head -c 19 "$file");
if [ "$opening_chars" == barretenberg_module ]; then
awk -f ./scripts/barretenberg_module_digraph_edges.awk $file >> $TMP
fi;
done;
echo } >> $TMP;

# apply transitive reduction to remove dependcies that are implied by satisfied by other dependencies
cat $TMP | tred > $RESULT_DOT;
rm $TMP;

# produce a PNG of the graph
dot -Tpng $RESULT_DOT -o $RESULT_PNG
35 changes: 35 additions & 0 deletions barretenberg/cpp/scripts/barretenberg_module_digraph_edges.awk
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Function to extract words between parentheses
function extract_edges(line) {
match(line, /\(.*\)/); # Find the portion within parentheses
line = substr(line, RSTART + 1, RLENGTH - 2); # Extract the words
gsub(/^[ ]+/, "", line); # Remove leading spaces and tabs
gsub(/[ ]+$/, "", line); # Remove trailing spaces and tabs
gsub(/[ ]+/, " ", line); # Sub multiple spaces for a single space
split(line, modules, " ");

# If node has no dependencies, just add the node
if (length(modules)==1) {
print modules[1];
}
else { # add edges
for (i = 2; i <= length(modules); i++) {
print modules[1]" -> "modules[i];
}
}
}

# Main AWK script
{
# Concatenate lines if the opening parentheses is not closed
while (!/\)/) {
current_line = $0;
getline;
$0 = current_line $0;
}

# Check if the line begins with "barretenberg_module". If so, extact the digraph edges
function_name = "barretenberg_module";
if ($0 ~ "^" function_name "\\(") {
extract_edges($0);
}
}
Loading