-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Produce graph of internal Barretenberg dependencies #4225
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/usr/bin/env bash | ||
set -eu | ||
|
||
TMP=tmp.dot; | ||
RESULT_DOT=barretenberg_modules.dot; | ||
RESULT_PNG=barretenberg_modules.png; | ||
|
||
# initialize a directed graph for graphviz | ||
echo digraph BarretenbergModules { > $TMP; | ||
# populate the directed graph | ||
for file in $(find ./src/barretenberg/ -iname CMakeLists.txt); do | ||
opening_chars=$(head -c 19 "$file"); | ||
if [ "$opening_chars" == barretenberg_module ]; then | ||
awk -f ./scripts/barretenberg_module_digraph_edges.awk $file >> $TMP | ||
fi; | ||
done; | ||
echo } >> $TMP; | ||
|
||
# apply transitive reduction to remove dependcies that are implied by satisfied by other dependencies | ||
cat $TMP | tred > $RESULT_DOT; | ||
rm $TMP; | ||
|
||
# produce a PNG of the graph | ||
dot -Tpng $RESULT_DOT -o $RESULT_PNG |
35 changes: 35 additions & 0 deletions
35
barretenberg/cpp/scripts/barretenberg_module_digraph_edges.awk
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Function to extract words between parentheses | ||
function extract_edges(line) { | ||
match(line, /\(.*\)/); # Find the portion within parentheses | ||
line = substr(line, RSTART + 1, RLENGTH - 2); # Extract the words | ||
gsub(/^[ ]+/, "", line); # Remove leading spaces and tabs | ||
gsub(/[ ]+$/, "", line); # Remove trailing spaces and tabs | ||
gsub(/[ ]+/, " ", line); # Sub multiple spaces for a single space | ||
split(line, modules, " "); | ||
|
||
# If node has no dependencies, just add the node | ||
if (length(modules)==1) { | ||
print modules[1]; | ||
} | ||
else { # add edges | ||
for (i = 2; i <= length(modules); i++) { | ||
print modules[1]" -> "modules[i]; | ||
} | ||
} | ||
} | ||
|
||
# Main AWK script | ||
{ | ||
# Concatenate lines if the opening parentheses is not closed | ||
while (!/\)/) { | ||
current_line = $0; | ||
getline; | ||
$0 = current_line $0; | ||
} | ||
|
||
# Check if the line begins with "barretenberg_module". If so, extact the digraph edges | ||
function_name = "barretenberg_module"; | ||
if ($0 ~ "^" function_name "\\(") { | ||
extract_edges($0); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASH does not need a final semicolon, only if you want to do two lines on one line
e..g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the semicolon finger fires automatically for me now;