feat: Benchmark commit function #4178

codygunton · 2024-01-22T21:23:12Z

Straightforwardly added a benchmark of our fundamental commit function over BN254. Results:

% taskset -c 0-15 ./bin/commit_bench                                              1m 4s ~/barretenberg-cpp/build master + mainframe
2024-01-22T16:21:55+00:00
Running ./bin/commit_bench
Run on (128 X 2649.99 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x64)
  L1 Instruction 32 KiB (x64)
  L2 Unified 512 KiB (x64)
  L3 Unified 32768 KiB (x8)
Load Average: 6.56, 8.97, 11.08
------------------------------------------------------------------------
Benchmark                              Time             CPU   Iterations
------------------------------------------------------------------------
bench_commit<curve::BN254>/10      0.443 ms        0.351 ms         2010
bench_commit<curve::BN254>/11      0.853 ms        0.828 ms          833
bench_commit<curve::BN254>/12      0.900 ms        0.874 ms          860
bench_commit<curve::BN254>/13      0.845 ms        0.819 ms          788
bench_commit<curve::BN254>/14       1.06 ms        0.857 ms          822
bench_commit<curve::BN254>/15       1.32 ms        0.918 ms          744
bench_commit<curve::BN254>/16       2.08 ms         1.15 ms          606
bench_commit<curve::BN254>/17       3.42 ms         1.65 ms          421
bench_commit<curve::BN254>/18       5.21 ms         2.37 ms          300
bench_commit<curve::BN254>/19       10.2 ms         2.69 ms          200
bench_commit<curve::BN254>/20       21.4 ms         1.60 ms          331
bench_commit<curve::BN254>/21       53.9 ms         1.88 ms          100
bench_commit<curve::BN254>/22        103 ms         3.38 ms          100
bench_commit<curve::BN254>/23        225 ms         9.47 ms           55
bench_commit<curve::BN254>/24        505 ms         30.1 ms           10

ledwards2225

LG

ledwards2225 · 2024-01-22T21:56:11Z

barretenberg/cpp/src/barretenberg/benchmark/commit_bench/commit.bench.cpp

+}
+
+constexpr size_t MAX_LOG_NUM_POINTS = 24;
+constexpr size_t MAX_NUM_POINTS = 1 << 24;


Did you mean to use MAX_LOG_NUM_POINTS here instead of 24?

Oh yes should have done, thanks

AztecBot · 2024-01-22T22:29:45Z

Benchmark results

Metrics with a significant change:

batch_insert_into_indexed_tree_20_depth_ms (512): 377 (-22%)
note_history_trial_decrypting_time_in_ms (5): 297 (+103%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 38d262ed and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,620	866,848	3,446,992
l1_rollup_execution_gas	314,039	984,520	3,666,581
l2_block_processing_time_in_ms	1,436 (-8%)	5,406 (+2%)	21,025 (+1%)
note_successful_decrypting_time_in_ms	295 (+4%)	863 (+2%)	3,226 (+2%)
note_trial_decrypting_time_in_ms	103 (+10%)	95.6 (+37%)	146 (-3%)
l2_block_building_time_in_ms	16,185	64,116	255,525
l2_block_rollup_simulation_time_in_ms	11,757	46,692	186,315
l2_block_public_tx_process_time_in_ms	4,392 (+1%)	17,334	68,937

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,746 (-3%)	30,700 (+2%)
note_history_successful_decrypting_time_in_ms	1,945 (-1%)	3,845 (+1%)
note_history_trial_decrypting_time_in_ms	⚠️ 297 (+103%)	230 (-1%)
node_database_size_in_bytes	3,516,574	3,550,821
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	213	44,681	25,561
private-kernel-ordering	165	43,753	14,809
base-rollup	1,193	128,338	881
root-rollup	79.2	4,088	677
private-kernel-inner	291	71,208	25,561
public-kernel-private-input	206	31,863	25,561
public-kernel-non-first-iteration	203	31,905	25,561
merge-rollup	7.65 (+1%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	12.2	19.7 (+12%)	13.9 (+2%)	19.8 (+1%)	26.3 (+8%)	67.1	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.621	0.715 (+15%)	0.554	0.551	0.524 (+9%)	0.444	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	84.0 (-1%)	51.9	255 (-13%)	478	928 (+1%)	3,574
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.476 (+1%)	0.499	0.442 (-11%)	0.436	0.432 (+1%)	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	119 (-8%)	63.1 (+1%)	⚠️ 377 (-22%)	765 (-1%)	1,482 (+3%)	5,642
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.509 (-5%)	0.508 (+1%)	0.479 (-10%)	0.484 (-1%)	0.485 (+2%)	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	68.0 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.597	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,220

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	376	1,087

Metric	1 public data writes
tx_sequencer_processing_time_ms	537 (+1%)

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.20.0</summary> ## [0.20.0](aztec-packages-v0.19.0...aztec-packages-v0.20.0) (2024-01-22) ### ⚠ BREAKING CHANGES * nullifier key ([#4166](#4166)) * Unify ABIs between nargo and yarn-project ([#3989](#3989)) ### Features * **avm:** Add internal jump and return, adjust control flow ([#4140](#4140)) ([b77afb1](b77afb1)) * **avm:** Better field arithmetic ([#4142](#4142)) ([7308e31](7308e31)) * **avm:** Encode TS AVM instructions as bytecode, especially for testing ([#4115](#4115)) ([de6e2ed](de6e2ed)) * **avm:** Improve interpreter errors and tests ([#4173](#4173)) ([f0fb594](f0fb594)) * Benchmark commit function ([#4178](#4178)) ([ea84085](ea84085)) * Goblin acir composer ([#4112](#4112)) ([5e85b92](5e85b92)) * Nullifier key ([#4166](#4166)) ([7c07665](7c07665)) * **public-vm:** Avm journal ([#3945](#3945)) ([5658468](5658468)) * Publish block body separately ([#4118](#4118)) ([a04e1e3](a04e1e3)), closes [#3944](#3944) * Unify ABIs between nargo and yarn-project ([#3989](#3989)) ([d083438](d083438)) * Update noir ([#4082](#4082)) ([0e6037a](0e6037a)) * Updating L2 Block encoding and `Rollup.process` function ([#4015](#4015)) ([2d8eb37](2d8eb37)), closes [#3936](#3936) [#4010](#4010) [#4011](#4011) ### Bug Fixes * Bb.js version in yarn lockfile ([7b96760](7b96760)) * **build:** Publish bb.js from CCI ([#4151](#4151)) ([09dbfcd](09dbfcd)) * Make CMake version warning fatal ([#4144](#4144)) ([b1443fa](b1443fa)) * Misleading error message in `PublicState::read` ([#4149](#4149)) ([fa4d919](fa4d919)) * Nargo destination path in bootstrap cache ([#4103](#4103)) ([4901309](4901309)) * Reinstate Ultra arith rec verifier test ([#3886](#3886)) ([995973b](995973b)) * Upload_benchmarks_to_s3.sh missing exit ([#4046](#4046)) ([52a9327](52a9327)) ### Miscellaneous * Archiver store ([#3966](#3966)) ([af2be87](af2be87)) * **avm:** List avm opcodes in a (enum => class) map in TS ([#4113](#4113)) ([dee564a](dee564a)) * **bb:** More concise namespaces, plookup => bb::plookup ([#4146](#4146)) ([14d39ed](14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([#4117](#4117)) ([cd2f67f](cd2f67f)) * **bb:** Namespace proof_system=>bb ([#4116](#4116)) ([7438db3](7438db3)) * **docs:** Aztec-up doesnt need `latest`, remove warnings around sandbox/cli npm pkgs ([#4138](#4138)) ([2bbf7a9](2bbf7a9)) * **docs:** Update js release notes for 0.18.0 ([#4051](#4051)) ([bdbe963](bdbe963)) * **docs:** Update lsp install instructions ([#4110](#4110)) ([3138816](3138816)), closes [#4098](#4098) * Dont mirror build-system mirror_repos.yml ([#4067](#4067)) ([04f8e0d](04f8e0d)) * Fixes many broken urls ([#4109](#4109)) ([41ae75c](41ae75c)) * Remove dependency cycles in `sequencer-client` ([#4017](#4017)) ([fe4538b](fe4538b)) * Remove lodash times in favor of foundation fn ([#3877](#3877)) ([a10eef0](a10eef0)) * Remove mutex dependency ([#4160](#4160)) ([3b82be0](3b82be0)) * Remove unnecessary computation ([#4133](#4133)) ([f35bdb8](f35bdb8)) * Remove unused noir-version json ([#4105](#4105)) ([afca819](afca819)) * Remove unwanted submodules ([#4085](#4085)) ([dda7c9c](dda7c9c)) * Replace relative paths to noir-protocol-circuits ([59feeb5](59feeb5)) * Replace relative paths to noir-protocol-circuits ([44d9136](44d9136)) * Replace relative paths to noir-protocol-circuits ([84b0bad](84b0bad)) * Simplify and fix DocsExample contract, e2e singleton + codegen to not show internal methods ([#4169](#4169)) ([38d262e](38d262e)) * Update noir ([#4168](#4168)) ([d40ad06](d40ad06)) ### Documentation * Update migration notes ([#4175](#4175)) ([dbc8174](dbc8174)) * **yellow-paper:** Update circuit sections for nullifier keys and static calls ([#4155](#4155)) ([ed71a57](ed71a57)) * **yellowpaper:** Refresh of avm instruction set ([#4081](#4081)) ([52162ee](52162ee)) </details> <details><summary>barretenberg.js: 0.20.0</summary> ## [0.20.0](barretenberg.js-v0.19.0...barretenberg.js-v0.20.0) (2024-01-22) ### Features * Goblin acir composer ([#4112](#4112)) ([5e85b92](5e85b92)) </details> <details><summary>barretenberg: 0.20.0</summary> ## [0.20.0](barretenberg-v0.19.0...barretenberg-v0.20.0) (2024-01-22) ### Features * Benchmark commit function ([#4178](#4178)) ([ea84085](ea84085)) * Goblin acir composer ([#4112](#4112)) ([5e85b92](5e85b92)) ### Bug Fixes * Make CMake version warning fatal ([#4144](#4144)) ([b1443fa](b1443fa)) * Reinstate Ultra arith rec verifier test ([#3886](#3886)) ([995973b](995973b)) * Upload_benchmarks_to_s3.sh missing exit ([#4046](#4046)) ([52a9327](52a9327)) ### Miscellaneous * **bb:** More concise namespaces, plookup => bb::plookup ([#4146](#4146)) ([14d39ed](14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([#4117](#4117)) ([cd2f67f](cd2f67f)) * **bb:** Namespace proof_system=>bb ([#4116](#4116)) ([7438db3](7438db3)) * Remove mutex dependency ([#4160](#4160)) ([3b82be0](3b82be0)) * Remove unwanted submodules ([#4085](#4085)) ([dda7c9c](dda7c9c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Straightforwardly added a benchmark to our fundamental `commit` function over BN254. Results: ``` % taskset -c 0-15 ./bin/commit_bench 1m 4s ~/barretenberg-cpp/build master + mainframe 2024-01-22T16:21:55+00:00 Running ./bin/commit_bench Run on (128 X 2649.99 MHz CPU s) CPU Caches: L1 Data 32 KiB (x64) L1 Instruction 32 KiB (x64) L2 Unified 512 KiB (x64) L3 Unified 32768 KiB (x8) Load Average: 6.56, 8.97, 11.08 ------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------ bench_commit<curve::BN254>/10 0.443 ms 0.351 ms 2010 bench_commit<curve::BN254>/11 0.853 ms 0.828 ms 833 bench_commit<curve::BN254>/12 0.900 ms 0.874 ms 860 bench_commit<curve::BN254>/13 0.845 ms 0.819 ms 788 bench_commit<curve::BN254>/14 1.06 ms 0.857 ms 822 bench_commit<curve::BN254>/15 1.32 ms 0.918 ms 744 bench_commit<curve::BN254>/16 2.08 ms 1.15 ms 606 bench_commit<curve::BN254>/17 3.42 ms 1.65 ms 421 bench_commit<curve::BN254>/18 5.21 ms 2.37 ms 300 bench_commit<curve::BN254>/19 10.2 ms 2.69 ms 200 bench_commit<curve::BN254>/20 21.4 ms 1.60 ms 331 bench_commit<curve::BN254>/21 53.9 ms 1.88 ms 100 bench_commit<curve::BN254>/22 103 ms 3.38 ms 100 bench_commit<curve::BN254>/23 225 ms 9.47 ms 55 bench_commit<curve::BN254>/24 505 ms 30.1 ms 10 ```

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0) (2024-01-22) ### ⚠ BREAKING CHANGES * nullifier key ([#4166](AztecProtocol/aztec-packages#4166)) * Unify ABIs between nargo and yarn-project ([#3989](AztecProtocol/aztec-packages#3989)) ### Features * **avm:** Add internal jump and return, adjust control flow ([#4140](AztecProtocol/aztec-packages#4140)) ([b77afb1](AztecProtocol/aztec-packages@b77afb1)) * **avm:** Better field arithmetic ([#4142](AztecProtocol/aztec-packages#4142)) ([7308e31](AztecProtocol/aztec-packages@7308e31)) * **avm:** Encode TS AVM instructions as bytecode, especially for testing ([#4115](AztecProtocol/aztec-packages#4115)) ([de6e2ed](AztecProtocol/aztec-packages@de6e2ed)) * **avm:** Improve interpreter errors and tests ([#4173](AztecProtocol/aztec-packages#4173)) ([f0fb594](AztecProtocol/aztec-packages@f0fb594)) * Benchmark commit function ([#4178](AztecProtocol/aztec-packages#4178)) ([ea84085](AztecProtocol/aztec-packages@ea84085)) * Goblin acir composer ([#4112](AztecProtocol/aztec-packages#4112)) ([5e85b92](AztecProtocol/aztec-packages@5e85b92)) * Nullifier key ([#4166](AztecProtocol/aztec-packages#4166)) ([7c07665](AztecProtocol/aztec-packages@7c07665)) * **public-vm:** Avm journal ([#3945](AztecProtocol/aztec-packages#3945)) ([5658468](AztecProtocol/aztec-packages@5658468)) * Publish block body separately ([#4118](AztecProtocol/aztec-packages#4118)) ([a04e1e3](AztecProtocol/aztec-packages@a04e1e3)), closes [#3944](AztecProtocol/aztec-packages#3944) * Unify ABIs between nargo and yarn-project ([#3989](AztecProtocol/aztec-packages#3989)) ([d083438](AztecProtocol/aztec-packages@d083438)) * Update noir ([#4082](AztecProtocol/aztec-packages#4082)) ([0e6037a](AztecProtocol/aztec-packages@0e6037a)) * Updating L2 Block encoding and `Rollup.process` function ([#4015](AztecProtocol/aztec-packages#4015)) ([2d8eb37](AztecProtocol/aztec-packages@2d8eb37)), closes [#3936](AztecProtocol/aztec-packages#3936) [#4010](AztecProtocol/aztec-packages#4010) [#4011](AztecProtocol/aztec-packages#4011) ### Bug Fixes * Bb.js version in yarn lockfile ([7b96760](AztecProtocol/aztec-packages@7b96760)) * **build:** Publish bb.js from CCI ([#4151](AztecProtocol/aztec-packages#4151)) ([09dbfcd](AztecProtocol/aztec-packages@09dbfcd)) * Make CMake version warning fatal ([#4144](AztecProtocol/aztec-packages#4144)) ([b1443fa](AztecProtocol/aztec-packages@b1443fa)) * Misleading error message in `PublicState::read` ([#4149](AztecProtocol/aztec-packages#4149)) ([fa4d919](AztecProtocol/aztec-packages@fa4d919)) * Nargo destination path in bootstrap cache ([#4103](AztecProtocol/aztec-packages#4103)) ([4901309](AztecProtocol/aztec-packages@4901309)) * Reinstate Ultra arith rec verifier test ([#3886](AztecProtocol/aztec-packages#3886)) ([995973b](AztecProtocol/aztec-packages@995973b)) * Upload_benchmarks_to_s3.sh missing exit ([#4046](AztecProtocol/aztec-packages#4046)) ([52a9327](AztecProtocol/aztec-packages@52a9327)) ### Miscellaneous * Archiver store ([#3966](AztecProtocol/aztec-packages#3966)) ([af2be87](AztecProtocol/aztec-packages@af2be87)) * **avm:** List avm opcodes in a (enum => class) map in TS ([#4113](AztecProtocol/aztec-packages#4113)) ([dee564a](AztecProtocol/aztec-packages@dee564a)) * **bb:** More concise namespaces, plookup => bb::plookup ([#4146](AztecProtocol/aztec-packages#4146)) ([14d39ed](AztecProtocol/aztec-packages@14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([#4117](AztecProtocol/aztec-packages#4117)) ([cd2f67f](AztecProtocol/aztec-packages@cd2f67f)) * **bb:** Namespace proof_system=>bb ([#4116](AztecProtocol/aztec-packages#4116)) ([7438db3](AztecProtocol/aztec-packages@7438db3)) * **docs:** Aztec-up doesnt need `latest`, remove warnings around sandbox/cli npm pkgs ([#4138](AztecProtocol/aztec-packages#4138)) ([2bbf7a9](AztecProtocol/aztec-packages@2bbf7a9)) * **docs:** Update js release notes for 0.18.0 ([#4051](AztecProtocol/aztec-packages#4051)) ([bdbe963](AztecProtocol/aztec-packages@bdbe963)) * **docs:** Update lsp install instructions ([#4110](AztecProtocol/aztec-packages#4110)) ([3138816](AztecProtocol/aztec-packages@3138816)), closes [#4098](AztecProtocol/aztec-packages#4098) * Dont mirror build-system mirror_repos.yml ([#4067](AztecProtocol/aztec-packages#4067)) ([04f8e0d](AztecProtocol/aztec-packages@04f8e0d)) * Fixes many broken urls ([#4109](AztecProtocol/aztec-packages#4109)) ([41ae75c](AztecProtocol/aztec-packages@41ae75c)) * Remove dependency cycles in `sequencer-client` ([#4017](AztecProtocol/aztec-packages#4017)) ([fe4538b](AztecProtocol/aztec-packages@fe4538b)) * Remove lodash times in favor of foundation fn ([#3877](AztecProtocol/aztec-packages#3877)) ([a10eef0](AztecProtocol/aztec-packages@a10eef0)) * Remove mutex dependency ([#4160](AztecProtocol/aztec-packages#4160)) ([3b82be0](AztecProtocol/aztec-packages@3b82be0)) * Remove unnecessary computation ([#4133](AztecProtocol/aztec-packages#4133)) ([f35bdb8](AztecProtocol/aztec-packages@f35bdb8)) * Remove unused noir-version json ([#4105](AztecProtocol/aztec-packages#4105)) ([afca819](AztecProtocol/aztec-packages@afca819)) * Remove unwanted submodules ([#4085](AztecProtocol/aztec-packages#4085)) ([dda7c9c](AztecProtocol/aztec-packages@dda7c9c)) * Replace relative paths to noir-protocol-circuits ([59feeb5](AztecProtocol/aztec-packages@59feeb5)) * Replace relative paths to noir-protocol-circuits ([44d9136](AztecProtocol/aztec-packages@44d9136)) * Replace relative paths to noir-protocol-circuits ([84b0bad](AztecProtocol/aztec-packages@84b0bad)) * Simplify and fix DocsExample contract, e2e singleton + codegen to not show internal methods ([#4169](AztecProtocol/aztec-packages#4169)) ([38d262e](AztecProtocol/aztec-packages@38d262e)) * Update noir ([#4168](AztecProtocol/aztec-packages#4168)) ([d40ad06](AztecProtocol/aztec-packages@d40ad06)) ### Documentation * Update migration notes ([#4175](AztecProtocol/aztec-packages#4175)) ([dbc8174](AztecProtocol/aztec-packages@dbc8174)) * **yellow-paper:** Update circuit sections for nullifier keys and static calls ([#4155](AztecProtocol/aztec-packages#4155)) ([ed71a57](AztecProtocol/aztec-packages@ed71a57)) * **yellowpaper:** Refresh of avm instruction set ([#4081](AztecProtocol/aztec-packages#4081)) ([52162ee](AztecProtocol/aztec-packages@52162ee)) </details> <details><summary>barretenberg.js: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0) (2024-01-22) ### Features * Goblin acir composer ([#4112](AztecProtocol/aztec-packages#4112)) ([5e85b92](AztecProtocol/aztec-packages@5e85b92)) </details> <details><summary>barretenberg: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0) (2024-01-22) ### Features * Benchmark commit function ([#4178](AztecProtocol/aztec-packages#4178)) ([ea84085](AztecProtocol/aztec-packages@ea84085)) * Goblin acir composer ([#4112](AztecProtocol/aztec-packages#4112)) ([5e85b92](AztecProtocol/aztec-packages@5e85b92)) ### Bug Fixes * Make CMake version warning fatal ([#4144](AztecProtocol/aztec-packages#4144)) ([b1443fa](AztecProtocol/aztec-packages@b1443fa)) * Reinstate Ultra arith rec verifier test ([#3886](AztecProtocol/aztec-packages#3886)) ([995973b](AztecProtocol/aztec-packages@995973b)) * Upload_benchmarks_to_s3.sh missing exit ([#4046](AztecProtocol/aztec-packages#4046)) ([52a9327](AztecProtocol/aztec-packages@52a9327)) ### Miscellaneous * **bb:** More concise namespaces, plookup => bb::plookup ([#4146](AztecProtocol/aztec-packages#4146)) ([14d39ed](AztecProtocol/aztec-packages@14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([#4117](AztecProtocol/aztec-packages#4117)) ([cd2f67f](AztecProtocol/aztec-packages@cd2f67f)) * **bb:** Namespace proof_system=>bb ([#4116](AztecProtocol/aztec-packages#4116)) ([7438db3](AztecProtocol/aztec-packages@7438db3)) * Remove mutex dependency ([#4160](AztecProtocol/aztec-packages#4160)) ([3b82be0](AztecProtocol/aztec-packages@3b82be0)) * Remove unwanted submodules ([#4085](AztecProtocol/aztec-packages#4085)) ([dda7c9c](AztecProtocol/aztec-packages@dda7c9c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Straightforwardly added a benchmark to our fundamental `commit` function over BN254. Results: ``` % taskset -c 0-15 ./bin/commit_bench 1m 4s ~/barretenberg-cpp/build master + mainframe 2024-01-22T16:21:55+00:00 Running ./bin/commit_bench Run on (128 X 2649.99 MHz CPU s) CPU Caches: L1 Data 32 KiB (x64) L1 Instruction 32 KiB (x64) L2 Unified 512 KiB (x64) L3 Unified 32768 KiB (x8) Load Average: 6.56, 8.97, 11.08 ------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------ bench_commit<curve::BN254>/10 0.443 ms 0.351 ms 2010 bench_commit<curve::BN254>/11 0.853 ms 0.828 ms 833 bench_commit<curve::BN254>/12 0.900 ms 0.874 ms 860 bench_commit<curve::BN254>/13 0.845 ms 0.819 ms 788 bench_commit<curve::BN254>/14 1.06 ms 0.857 ms 822 bench_commit<curve::BN254>/15 1.32 ms 0.918 ms 744 bench_commit<curve::BN254>/16 2.08 ms 1.15 ms 606 bench_commit<curve::BN254>/17 3.42 ms 1.65 ms 421 bench_commit<curve::BN254>/18 5.21 ms 2.37 ms 300 bench_commit<curve::BN254>/19 10.2 ms 2.69 ms 200 bench_commit<curve::BN254>/20 21.4 ms 1.60 ms 331 bench_commit<curve::BN254>/21 53.9 ms 1.88 ms 100 bench_commit<curve::BN254>/22 103 ms 3.38 ms 100 bench_commit<curve::BN254>/23 225 ms 9.47 ms 55 bench_commit<curve::BN254>/24 505 ms 30.1 ms 10 ```

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0) (2024-01-22) ### ⚠ BREAKING CHANGES * nullifier key ([AztecProtocol#4166](AztecProtocol#4166)) * Unify ABIs between nargo and yarn-project ([AztecProtocol#3989](AztecProtocol#3989)) ### Features * **avm:** Add internal jump and return, adjust control flow ([AztecProtocol#4140](AztecProtocol#4140)) ([b77afb1](AztecProtocol@b77afb1)) * **avm:** Better field arithmetic ([AztecProtocol#4142](AztecProtocol#4142)) ([7308e31](AztecProtocol@7308e31)) * **avm:** Encode TS AVM instructions as bytecode, especially for testing ([AztecProtocol#4115](AztecProtocol#4115)) ([de6e2ed](AztecProtocol@de6e2ed)) * **avm:** Improve interpreter errors and tests ([AztecProtocol#4173](AztecProtocol#4173)) ([f0fb594](AztecProtocol@f0fb594)) * Benchmark commit function ([AztecProtocol#4178](AztecProtocol#4178)) ([ea84085](AztecProtocol@ea84085)) * Goblin acir composer ([AztecProtocol#4112](AztecProtocol#4112)) ([5e85b92](AztecProtocol@5e85b92)) * Nullifier key ([AztecProtocol#4166](AztecProtocol#4166)) ([7c07665](AztecProtocol@7c07665)) * **public-vm:** Avm journal ([AztecProtocol#3945](AztecProtocol#3945)) ([5658468](AztecProtocol@5658468)) * Publish block body separately ([AztecProtocol#4118](AztecProtocol#4118)) ([a04e1e3](AztecProtocol@a04e1e3)), closes [AztecProtocol#3944](AztecProtocol#3944) * Unify ABIs between nargo and yarn-project ([AztecProtocol#3989](AztecProtocol#3989)) ([d083438](AztecProtocol@d083438)) * Update noir ([AztecProtocol#4082](AztecProtocol#4082)) ([0e6037a](AztecProtocol@0e6037a)) * Updating L2 Block encoding and `Rollup.process` function ([AztecProtocol#4015](AztecProtocol#4015)) ([2d8eb37](AztecProtocol@2d8eb37)), closes [AztecProtocol#3936](AztecProtocol#3936) [AztecProtocol#4010](AztecProtocol#4010) [AztecProtocol#4011](AztecProtocol#4011) ### Bug Fixes * Bb.js version in yarn lockfile ([7b96760](AztecProtocol@7b96760)) * **build:** Publish bb.js from CCI ([AztecProtocol#4151](AztecProtocol#4151)) ([09dbfcd](AztecProtocol@09dbfcd)) * Make CMake version warning fatal ([AztecProtocol#4144](AztecProtocol#4144)) ([b1443fa](AztecProtocol@b1443fa)) * Misleading error message in `PublicState::read` ([AztecProtocol#4149](AztecProtocol#4149)) ([fa4d919](AztecProtocol@fa4d919)) * Nargo destination path in bootstrap cache ([AztecProtocol#4103](AztecProtocol#4103)) ([4901309](AztecProtocol@4901309)) * Reinstate Ultra arith rec verifier test ([AztecProtocol#3886](AztecProtocol#3886)) ([995973b](AztecProtocol@995973b)) * Upload_benchmarks_to_s3.sh missing exit ([AztecProtocol#4046](AztecProtocol#4046)) ([52a9327](AztecProtocol@52a9327)) ### Miscellaneous * Archiver store ([AztecProtocol#3966](AztecProtocol#3966)) ([af2be87](AztecProtocol@af2be87)) * **avm:** List avm opcodes in a (enum => class) map in TS ([AztecProtocol#4113](AztecProtocol#4113)) ([dee564a](AztecProtocol@dee564a)) * **bb:** More concise namespaces, plookup => bb::plookup ([AztecProtocol#4146](AztecProtocol#4146)) ([14d39ed](AztecProtocol@14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([AztecProtocol#4117](AztecProtocol#4117)) ([cd2f67f](AztecProtocol@cd2f67f)) * **bb:** Namespace proof_system=>bb ([AztecProtocol#4116](AztecProtocol#4116)) ([7438db3](AztecProtocol@7438db3)) * **docs:** Aztec-up doesnt need `latest`, remove warnings around sandbox/cli npm pkgs ([AztecProtocol#4138](AztecProtocol#4138)) ([2bbf7a9](AztecProtocol@2bbf7a9)) * **docs:** Update js release notes for 0.18.0 ([AztecProtocol#4051](AztecProtocol#4051)) ([bdbe963](AztecProtocol@bdbe963)) * **docs:** Update lsp install instructions ([AztecProtocol#4110](AztecProtocol#4110)) ([3138816](AztecProtocol@3138816)), closes [AztecProtocol#4098](AztecProtocol#4098) * Dont mirror build-system mirror_repos.yml ([AztecProtocol#4067](AztecProtocol#4067)) ([04f8e0d](AztecProtocol@04f8e0d)) * Fixes many broken urls ([AztecProtocol#4109](AztecProtocol#4109)) ([41ae75c](AztecProtocol@41ae75c)) * Remove dependency cycles in `sequencer-client` ([AztecProtocol#4017](AztecProtocol#4017)) ([fe4538b](AztecProtocol@fe4538b)) * Remove lodash times in favor of foundation fn ([AztecProtocol#3877](AztecProtocol#3877)) ([a10eef0](AztecProtocol@a10eef0)) * Remove mutex dependency ([AztecProtocol#4160](AztecProtocol#4160)) ([3b82be0](AztecProtocol@3b82be0)) * Remove unnecessary computation ([AztecProtocol#4133](AztecProtocol#4133)) ([f35bdb8](AztecProtocol@f35bdb8)) * Remove unused noir-version json ([AztecProtocol#4105](AztecProtocol#4105)) ([afca819](AztecProtocol@afca819)) * Remove unwanted submodules ([AztecProtocol#4085](AztecProtocol#4085)) ([dda7c9c](AztecProtocol@dda7c9c)) * Replace relative paths to noir-protocol-circuits ([59feeb5](AztecProtocol@59feeb5)) * Replace relative paths to noir-protocol-circuits ([44d9136](AztecProtocol@44d9136)) * Replace relative paths to noir-protocol-circuits ([84b0bad](AztecProtocol@84b0bad)) * Simplify and fix DocsExample contract, e2e singleton + codegen to not show internal methods ([AztecProtocol#4169](AztecProtocol#4169)) ([38d262e](AztecProtocol@38d262e)) * Update noir ([AztecProtocol#4168](AztecProtocol#4168)) ([d40ad06](AztecProtocol@d40ad06)) ### Documentation * Update migration notes ([AztecProtocol#4175](AztecProtocol#4175)) ([dbc8174](AztecProtocol@dbc8174)) * **yellow-paper:** Update circuit sections for nullifier keys and static calls ([AztecProtocol#4155](AztecProtocol#4155)) ([ed71a57](AztecProtocol@ed71a57)) * **yellowpaper:** Refresh of avm instruction set ([AztecProtocol#4081](AztecProtocol#4081)) ([52162ee](AztecProtocol@52162ee)) </details> <details><summary>barretenberg.js: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0) (2024-01-22) ### Features * Goblin acir composer ([AztecProtocol#4112](AztecProtocol#4112)) ([5e85b92](AztecProtocol@5e85b92)) </details> <details><summary>barretenberg: 0.20.0</summary> ## [0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0) (2024-01-22) ### Features * Benchmark commit function ([AztecProtocol#4178](AztecProtocol#4178)) ([ea84085](AztecProtocol@ea84085)) * Goblin acir composer ([AztecProtocol#4112](AztecProtocol#4112)) ([5e85b92](AztecProtocol@5e85b92)) ### Bug Fixes * Make CMake version warning fatal ([AztecProtocol#4144](AztecProtocol#4144)) ([b1443fa](AztecProtocol@b1443fa)) * Reinstate Ultra arith rec verifier test ([AztecProtocol#3886](AztecProtocol#3886)) ([995973b](AztecProtocol@995973b)) * Upload_benchmarks_to_s3.sh missing exit ([AztecProtocol#4046](AztecProtocol#4046)) ([52a9327](AztecProtocol@52a9327)) ### Miscellaneous * **bb:** More concise namespaces, plookup => bb::plookup ([AztecProtocol#4146](AztecProtocol#4146)) ([14d39ed](AztecProtocol@14d39ed)) * **bb:** Namespace plonk::stdlib => stdlib ([AztecProtocol#4117](AztecProtocol#4117)) ([cd2f67f](AztecProtocol@cd2f67f)) * **bb:** Namespace proof_system=>bb ([AztecProtocol#4116](AztecProtocol#4116)) ([7438db3](AztecProtocol@7438db3)) * Remove mutex dependency ([AztecProtocol#4160](AztecProtocol#4160)) ([3b82be0](AztecProtocol@3b82be0)) * Remove unwanted submodules ([AztecProtocol#4085](AztecProtocol#4085)) ([dda7c9c](AztecProtocol@dda7c9c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Benchmark commit function

9f8edab

codygunton changed the title ~~Benchmark commit function~~ feat: Benchmark commit function Jan 22, 2024

codygunton added 2 commits January 22, 2024 21:33

Use std::generate

544738d

No capture needed

8769418

codygunton self-assigned this Jan 22, 2024

ledwards2225 approved these changes Jan 22, 2024

View reviewed changes

Respond to review

8b0a84a

codygunton enabled auto-merge (squash) January 22, 2024 21:59

codygunton merged commit ea84085 into master Jan 22, 2024
79 of 81 checks passed

codygunton deleted the cg/bench-commit branch January 22, 2024 22:26

AztecBot mentioned this pull request Jan 22, 2024

chore(master): Release 0.20.0 #4086

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Benchmark commit function #4178

feat: Benchmark commit function #4178

codygunton commented Jan 22, 2024 •

edited

Loading

ledwards2225 left a comment

ledwards2225 Jan 22, 2024

codygunton Jan 22, 2024

AztecBot commented Jan 22, 2024

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

feat: Benchmark commit function #4178

feat: Benchmark commit function #4178

Conversation

codygunton commented Jan 22, 2024 • edited Loading

ledwards2225 left a comment

Choose a reason for hiding this comment

ledwards2225 Jan 22, 2024

Choose a reason for hiding this comment

codygunton Jan 22, 2024

Choose a reason for hiding this comment

AztecBot commented Jan 22, 2024

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

codygunton commented Jan 22, 2024 •

edited

Loading