Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: barretenberg => bb namespace shortening #4066

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jan 16, 2024

This is the first phase of namespace refactors planned. Just renames barretenberg=>bb.

The followups will mostly collapse long namespaces, e.g. bb::plonk::crypto::aes128 => bb::crypto

@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 307 (-26%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 432f6d1f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 220,992 866,312 3,444,668
l1_rollup_execution_gas 934,136 3,968,786 24,788,204
l2_block_processing_time_in_ms 1,327 5,095 21,155 (-1%)
note_successful_decrypting_time_in_ms ⚠️ 307 (-26%) 927 3,365
note_trial_decrypting_time_in_ms 16.7 (-26%) 52.0 (-7%) 130 (-3%)
l2_block_building_time_in_ms 16,011 63,467 254,242
l2_block_rollup_simulation_time_in_ms 11,631 46,164 185,207
l2_block_public_tx_process_time_in_ms 4,349 17,228 68,721

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,739 (-1%) 28,533 (-1%)
note_history_successful_decrypting_time_in_ms 2,183 (-1%) 4,259
note_history_trial_decrypting_time_in_ms 116 (+2%) 161 (-4%)
node_database_size_in_bytes 3,581,901 3,646,454
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 214 (+1%) 44,681 25,561
private-kernel-ordering 165 43,753 14,809
base-rollup 1,197 128,338 881
root-rollup 78.8 4,088 677
private-kernel-inner 290 (-1%) 71,208 25,561
public-kernel-private-input 205 31,863 25,561
public-kernel-non-first-iteration 203 31,905 25,561
merge-rollup 7.64 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.1 (-1%) 20.0 (+21%) 14.1 (+3%) 17.7 (-1%) 23.9 (+1%) 173 (-7%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 79.3 49.9 (-1%) 242 467 (-1%) 908 3,604
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 110 (-4%) 59.3 358 743 (+1%) 1,416 5,552
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 63.6 (-1%) N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,219

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 395 (+5%) 1,082
Metric 1 public data writes
tx_sequencer_processing_time_ms 534

@ludamad ludamad enabled auto-merge (squash) January 16, 2024 21:55
@codygunton codygunton self-requested a review January 16, 2024 21:58
Copy link
Contributor

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@@ -17,8 +17,8 @@ using Composer = proof_system::plonk::StandardComposer;

void generate_test_plonk_circuit(Builder& builder, size_t num_gates)
{
plonk::stdlib::field_t a(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element()));
plonk::stdlib::field_t b(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element()));
plonk::stdlib::field_t a(plonk::stdlib::witness_t(&builder, bb::fr::random_element()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-on: let's make this bb::bn254::fr, bb::grumpkin::fr etc

@@ -6,9 +6,9 @@
namespace proof_system::honk {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-on: we should put everything in bb namespace and remove unneeded qualifications.

@@ -70,6 +70,6 @@ class Bn254FrParams {

using fr = field<Bn254FrParams>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally in favor of calling this Fr but perhaps we should put it to a vote

@ludamad ludamad merged commit e6b66b8 into master Jan 16, 2024
84 checks passed
@ludamad ludamad deleted the refactor/barretenberg-to-bb branch January 16, 2024 23:11
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
This is the first phase of namespace refactors planned. Just renames
barretenberg=>bb.

The followups will mostly collapse long namespaces, e.g.
bb::plonk::crypto::aes128 => bb::crypto

---------

Co-authored-by: ludamad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants