Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resume CCI runs on release-please branch #4034

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

just-mitch
Copy link
Collaborator

Allow running CCI on release-please branch again.

This is not ideal, since it is wasted work, but presently there are required statuses from CCI on our github PRs, so when CCI doesn't run on release-please branch, it requires an admin for force merge.

# but doing so breaks github status checks:
# the PR spins as it waits for the status check to complete,
# which never happens because the branch is ignored.
# Long term solution would require the status checks
Copy link
Contributor

@alexghr alexghr Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing in the comment. WDYT?

Suggested change
# Long term solution would require the status checks
# Long term solution would require disabling the status checks on `master`

@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e28a6bf1 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 221,016 866,336 3,446,552
l1_rollup_execution_gas 934,160 3,968,810 24,790,088
l2_block_processing_time_in_ms 1,575 (+5%) 5,128 21,113 (-1%)
note_successful_decrypting_time_in_ms 306 (-2%) 940 (+2%) 3,420
note_trial_decrypting_time_in_ms 13.9 (-40%) 65.1 (+32%) 137 (+1%)
l2_block_building_time_in_ms 14,884 59,255 237,632
l2_block_rollup_simulation_time_in_ms 10,506 41,913 168,394
l2_block_public_tx_process_time_in_ms 4,345 17,262 68,818

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,314 (+2%) 29,277 (+2%)
note_history_successful_decrypting_time_in_ms 2,289 (+5%) 4,481 (+4%)
note_history_trial_decrypting_time_in_ms 162 (+40%) 192 (+13%)
node_database_size_in_bytes 3,626,793 3,723,537
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 213 44,681 25,561
private-kernel-ordering 166 (+1%) 43,753 14,809
base-rollup 1,066 128,338 881
root-rollup 79.5 (-1%) 4,088 677
private-kernel-inner 292 (+1%) 71,208 25,561
public-kernel-private-input 206 31,863 25,561
public-kernel-non-first-iteration 204 31,905 25,561
merge-rollup 7.71 (-7%) 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.1 22.4 15.4 18.0 23.8 64.9 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 96.2 50.2 243 472 919 3,567
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 111 59.8 360 767 1,410 5,579
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 64.6 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,224

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 376 (-1%) 1,089 (+1%)
Metric 1 public data writes
tx_sequencer_processing_time_ms 538

@just-mitch just-mitch merged commit fd58251 into master Jan 16, 2024
83 checks passed
@just-mitch just-mitch deleted the fix-run-cci-on-release-please branch January 16, 2024 14:28
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
Allow running CCI on release-please branch again.

This is not ideal, since it is wasted work, but presently there are
required statuses from CCI on our github PRs, so when CCI doesn't run on
release-please branch, it requires an admin for force merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants