chore: merge avm main #3874
Merged
chore: merge avm main #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #3632 ### Description A list of positive and negative unit tests for the arithmetic operations of finite field type. Each operation (add, sub, mul, div) is positively and negatively tested.
Replacing the toy_avm with a pil version that defines a permutation in
pil.
```
pol commit q_tuple_set;
// Set 1
pol commit set_1_column_1;
pol commit set_1_column_2;
// Set 2
pol commit set_2_column_1;
pol commit set_2_column_2;
// This is a column based tuple permutation
#[two_column_perm] // the name of the inverse polynomial
q_tuple_set { set_1_column_1, set_1_column_2 } is { set_2_column_1, set_2_column_2 };
```
Syntax is as shown.
- Add missing check that program counter advanced in call opcode ( oops
)
- Moved return storing to intermediate register b
- jump dest goes on register a
- Implement trivial jump opcode ( subset of call )
Resolves #3834 Moving all AVM memory related trace building functions into a dedicated class. Furthermore, all AVM related trace files were moved into a dedicated folder in vm. The following files: - AvmMini_common.hpp - AvmMini_helper.cpp - AvmMini_helper.hpp - AvmMini_mem_trace.cpp - AvmMini_mem_trace.hpp - AvmMini_trace.cpp - AvmMini_trace.hpp were moved from barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/ to barretenberg/cpp/src/barretenberg/vm/avm_trace/ Finally, the namespace for these files were migrating from proof_system to avm_trace.
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
|
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this pull request
Feb 28, 2024
…sync chore: merge avm main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges feature branch avm-main into master
note: this was turned into a feature branch as bb interfaces were under alot of change, but they have been stable for some time so we shall merge