-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: l1 to l2 messaging #385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
force-pushed
the
md/l1-l2-messaging
branch
from
April 26, 2023 17:24
50621e1
to
ea59f3b
Compare
temp commented out fix: pedersen segfault issue
Maddiaa0
force-pushed
the
md/l1-l2-messaging
branch
from
May 2, 2023 10:28
9014edc
to
999200f
Compare
LHerskind
reviewed
May 3, 2023
circuits/cpp/src/aztec3/circuits/abis/rollup/root/root_rollup_inputs.hpp
Show resolved
Hide resolved
circuits/cpp/src/aztec3/circuits/abis/rollup/root/root_rollup_public_inputs.hpp
Show resolved
Hide resolved
circuits/cpp/src/aztec3/circuits/rollup/root/native_root_rollup_circuit.cpp
Outdated
Show resolved
Hide resolved
yarn-project/sequencer-client/src/block_builder/circuit_block_builder.ts
Outdated
Show resolved
Hide resolved
yarn-project/sequencer-client/src/block_builder/circuit_block_builder.ts
Outdated
Show resolved
Hide resolved
yarn-project/sequencer-client/src/block_builder/circuit_block_builder.test.ts
Show resolved
Hide resolved
yarn-project/sequencer-client/src/block_builder/circuit_block_builder.ts
Show resolved
Hide resolved
LHerskind
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
ludamad
added a commit
that referenced
this pull request
May 3, 2023
* partial import refactor commit * partial import refactor commit * partial import refactor commit * add new export to foundation, partial import refactor * partial import reformat * add DebugLogger import * adjust additional imports * L1 contracts: readme + docker update (#422) * chore: readme + docker update * Apply suggestions from code review Co-authored-by: Maddiaa <[email protected]> --------- Co-authored-by: Maddiaa <[email protected]> * feat: l1 to l2 messaging (#385) * feat: initial decoder contact changes * feat: add message snapshot to l2 block * feat(world_state): add l2 merkle tree * feat: add l1ToL2 roots tree to ts * feat: historic l2 tree in l2 block * feat: add l1->l2 messages types to root rollup * feat: add to circuit powered block builder * feat: add types to root rollup inputs * feat: update root rollup circuit * feat: add l1tol2 messages to the rollup calldata * soldoc * fix: pedersen segfault issue temp commented out fix: pedersen segfault issue * clean: fix native root tests * Add messages hash test * feat: stub l1_to_l2_messages in block builder * fix: update snaphshots in circuits.js * fix: activate sim tree checking in rollup builder * fix: update snapshot * feat: add l2 block utilities * fix: rebase cpp build issues * feat: update l1 contract after rebase * fix: update ts tests * chore: update viem scripts * chore: update ethjs helpers * fix * feat: update decoder.t.sol * fix: re skip `l2-block-publisher.test.ts` * chore: clang tidy fix * fix: clang tidy * run prettier * fix: remove done todos * fix: re introduce test initialiser lost in merge * fix: move custom typing to its own file in the sequencer * fix: add negative tests, cleanup * chore: forge fmt * fix: rename updateRootsTree -> updateHistoricRootsTree * fix: update contract doc comment * fix: update cpp test and naming nits * fix: update trailing mock --------- Co-authored-by: cheethas <[email protected]> * Readme file for the world state package (#436) * Readme file for the worl state package * Review updates * Review change * Fixed linter errors + docs in archiver (#440) * chore: enabled strict linter checks * docs: fixed linting errors * refactor: fixed inconsistent naming * docs: updated readme * Fixed linter errors + docs in types (#443) * chore: enabled strict linter checks * chore: fixed linter errors * docs: udpated readme * Pw/merkle tree readme (#441) * Added readme file to Merkle Trees package * Readme update * update makeImport function ins ethereum.js --------- Co-authored-by: Lasse Herskind <[email protected]> Co-authored-by: Maddiaa <[email protected]> Co-authored-by: cheethas <[email protected]> Co-authored-by: PhilWindle <[email protected]> Co-authored-by: Jan Beneš <[email protected]> Co-authored-by: ludamad <[email protected]>
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
…straint` (#385) * feat: replace `MerkleMembershipConstraint` with`ComputeMerkleRootConstraint` * Update acir_format.cpp
This was referenced Jul 25, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
…straint` (#385) * feat: replace `MerkleMembershipConstraint` with`ComputeMerkleRootConstraint` * Update acir_format.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #348
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist: