feat: copy constructors for builders

[ledwards2225]

This work removes all reference data members from the circuit builders so that they can be trivially copy constructed.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (10): 233 (-31%)
• note_trial_decrypting_time_in_ms (32): 47.3 (+39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit fd6eefe3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,008	867,884	3,449,588
l1_rollup_execution_gas	842,095	3,594,992	22,204,957
l2_block_processing_time_in_ms	2,207 (+1%)	8,651 (+3%)	35,124
note_successful_decrypting_time_in_ms	314 (-2%)	921 (+1%)	3,338
note_trial_decrypting_time_in_ms	25.4 (-15%)	⚠️ 47.3 (+39%)	199
l2_block_building_time_in_ms	20,094	79,721 (-1%)	321,594
l2_block_rollup_simulation_time_in_ms	16,571	65,853 (-1%)	265,928
l2_block_public_tx_process_time_in_ms	3,492	13,796	55,423

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	25,242 (+1%)	48,023 (+2%)
note_history_successful_decrypting_time_in_ms	2,231 (+4%)	4,341 (+4%)
note_history_trial_decrypting_time_in_ms	164 (+2%)	⚠️ 233 (-31%)
node_database_size_in_bytes	3,622,397	3,922,145
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	199	43,109	20,441
private-kernel-ordering	115 (+1%)	25,833	9,689
base-rollup	2,958	667,692	873
root-rollup	84.7	4,072	881
private-kernel-inner	260	64,516	20,441
public-kernel-private-input	171	25,203	20,441
public-kernel-non-first-iteration	168	25,245	20,441
merge-rollup	10.8	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	25,938

[ludamad]

LGTM