P2P module #36
Merged
P2P module #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Mar 13, 2023
| * Helper to tranform Buffer IDs to a bigint. | ||
| */ | ||
| // TODO: place in/use from foundation repo | ||
| const toBigInt = (buf: Buffer): bigint => { |
There was a problem hiding this comment.
We should probably make an eslint rule for this, but I'm recommending we import {Buffer} from "buffer" as the rules for how modules are poly-filled is clearer than for globals
There was a problem hiding this comment.
Interesting, that actually sounds nice as I'm often fighting with the IDE to recognise that Buffer is a node env global.
This particular case will be removed shortly as I'm moving these into the foundation repo but I think this is a good idea 👍
PhilWindle
added a commit
that referenced
this pull request
Mar 23, 2023
* Initial work on synching world state * WIP * WIP * WIP * WIP * docs: fixed memory_fifo docs * refactor+docs: updated naming + fixed docs in L2BlockDownloader * refactor+docs: updated naming + fixed docs in Synchronizer * docs: fixed Semaphore docs * docs: fixed SerialQueue docs * docs: fixed docs in InterruptableSleep * docs: fixed WorldStateSynchroniser interface * docs: fixed WorldStatedB docs * docs: finished fixing world state docs * docs: fixed StandardMerkleTree docs * docs: fixed SiblingPath docs * docs: fixed docs of serialise.ts * docs: fixed MerkleTree docs * docs: fixed IndexedTree docs * docs: other merkle tree fixes * docs: fixed archiver * docs: fixed running promise docs * WIP * P2P module (#36) * add basic p2p client declarations for starting * WIP adding basic properties to p2p client * basic in-memory tx pool * super high-level implementation of p2p client initial sync * add public stop function to p2p client * add txPool to p2p client constructor * add functions to get all txs from tx pool & p2p client * add base p2p test * add yarn start - start:dev * consolidate some temp types etc * reject txs after being stopped * p2p running sync promise * add client state to status response * tx pool tests + cleanup * add world-state to yarn-project-base dockerfile * add merkle-tree to yarn-project-base-dockerfile * update project references + VERY BASIC implementation of Accumulated Tx Data * use types from data-archiver * merge fixes * update to use l2 blocks from archiver * WIP * WIP * WIP * WIP * WIP * WIP * WIP * Renamed public client * Removed serialisation code from merkle tree project * WIP * WIP * WIP --------- Co-authored-by: benesjan <[email protected]> Co-authored-by: spypsy <[email protected]>
ludamad
pushed a commit
that referenced
this pull request
Apr 14, 2023
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
P2PClientand in-memory implementationP2PMemoryClientEngineer can start the P2P module #3
Checklist: