Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Aztec CI files in Noir #3430

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat: Aztec CI files in Noir #3430

merged 3 commits into from
Nov 27, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Nov 27, 2023

This is a dual-list commit in both Noir and aztec repo. In this PR, Aztec gets the code to make a mirror, and the mirror action pushes to our aztec branch in Noir. The aztec branch features this as the first commit, to then be pushed one by one from master as Noir changes come in.

@ludamad ludamad force-pushed the ad/sync-noir branch 9 times, most recently from 03545d1 to 0d5fafd Compare November 27, 2023 21:52
@ludamad ludamad changed the title feat: mirror noir subrepo to branch feat: Aztec CI files in Noir Nov 27, 2023
@ludamad ludamad requested a review from charlielye November 27, 2023 21:59
@AztecBot
Copy link
Collaborator

AztecBot commented Nov 27, 2023

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (private-kernel-init): 399 (-48%)
  • circuit_simulation_time_in_ms (base-rollup): 3,178 (+81%)
  • circuit_simulation_time_in_ms (root-rollup): 90.7 (-46%)
  • circuit_simulation_time_in_ms (public-kernel-private-input): 418 (-27%)
  • circuit_input_size_in_bytes (private-kernel-init): 43,077 (-30%)
  • circuit_input_size_in_bytes (private-kernel-inner): 64,484 (-21%)
  • circuit_input_size_in_bytes (public-kernel-private-input): 25,203 (-39%)
  • circuit_input_size_in_bytes (public-kernel-non-first-iteration): 25,245 (-39%)
  • circuit_output_size_in_bytes (private-kernel-ordering): 9,689 (+19%)
  • tx_size_in_bytes (0): 10,323 (+17%)
  • l2_block_building_time_in_ms (8): 25,227 (+22%)
  • l2_block_building_time_in_ms (32): 100,631 (+23%)
  • l2_block_building_time_in_ms (128): 403,101 (+23%)
  • l2_block_rollup_simulation_time_in_ms (8): 17,647 (+48%)
  • l2_block_rollup_simulation_time_in_ms (32): 70,507 (+49%)
  • l2_block_rollup_simulation_time_in_ms (128): 281,251 (+49%)
  • note_trial_decrypting_time_in_ms (8): 11.4 (+97%)
  • note_trial_decrypting_time_in_ms (32): 13.8 (-85%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 2001d474 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,972 867,884 3,447,836
l1_rollup_execution_gas 842,059 3,594,992 22,203,205
l2_block_processing_time_in_ms 2,021 7,655 (-1%) 30,103
note_successful_decrypting_time_in_ms 308 (+3%) 903 (+2%) 3,301 (+2%)
note_trial_decrypting_time_in_ms ⚠️ 11.4 (+97%) ⚠️ 13.8 (-85%) 142 (+1%)
l2_block_building_time_in_ms ⚠️ 25,227 (+22%) ⚠️ 100,631 (+23%) ⚠️ 403,101 (+23%)
l2_block_rollup_simulation_time_in_ms ⚠️ 17,647 (+48%) ⚠️ 70,507 (+49%) ⚠️ 281,251 (+49%)
l2_block_public_tx_process_time_in_ms 7,535 (-13%) 29,975 (-13%) 121,291 (-13%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 21,858 42,645
note_history_successful_decrypting_time_in_ms 2,096 (+2%) 4,093 (+2%)
note_history_trial_decrypting_time_in_ms 126 157 (+1%)
node_database_size_in_bytes 1,631,962 1,101,038
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init ⚠️ 399 (-48%) ⚠️ 43,077 (-30%) 20,441 (+8%)
private-kernel-ordering 126 (-1%) 25,833 (+6%) ⚠️ 9,689 (+19%)
base-rollup ⚠️ 3,178 (+81%) 659,500 873
root-rollup ⚠️ 90.7 (-46%) 4,072 1,097
private-kernel-inner 825 (+4%) ⚠️ 64,484 (-21%) 20,441 (+8%)
public-kernel-private-input ⚠️ 418 (-27%) ⚠️ 25,203 (-39%) 20,441 (+8%)
public-kernel-non-first-iteration 412 (+1%) ⚠️ 25,245 (-39%) 20,441 (+8%)
merge-rollup 10.9 (-29%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes ⚠️ 10,323 (+17%) 29,083 (+6%)

@ludamad ludamad enabled auto-merge (squash) November 27, 2023 22:25
@ludamad ludamad disabled auto-merge November 27, 2023 22:27
@ludamad ludamad force-pushed the ad/sync-noir branch 5 times, most recently from 520e46c to e959427 Compare November 27, 2023 22:53
@ludamad ludamad enabled auto-merge (squash) November 27, 2023 23:10
@ludamad ludamad merged commit 1621f3a into master Nov 27, 2023
80 of 82 checks passed
@ludamad ludamad deleted the ad/sync-noir branch November 27, 2023 23:55
spypsy pushed a commit that referenced this pull request Nov 28, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.1</summary>

##
[0.16.1](aztec-packages-v0.16.0...aztec-packages-v0.16.1)
(2023-11-28)


### Features

* Added poseidon2 hash function to barretenberg/crypto
([#3118](#3118))
([d47782b](d47782b))
* Aztec CI files in Noir
([#3430](#3430))
([1621f3a](1621f3a))
* Persistent archiver store
([#3410](#3410))
([4735bde](4735bde)),
closes
[#3361](#3361)


### Bug Fixes

* **ci:** Don't leave DRY_DEPLOY unset
([#3449](#3449))
([454e316](454e316))
* **ci:** Publishing dockerhub manifests
([#3451](#3451))
([a59e7f0](a59e7f0))
* Hotfix noir sync
([#3436](#3436))
([c4e4745](c4e4745))


### Miscellaneous

* **docs:** Core concepts page in getting-started
([#3401](#3401))
([1a62f73](1a62f73))
* Point acir tests at noir master branch
([#3440](#3440))
([106e690](106e690))


### Documentation

* Further updates to the gas and fees whitepaper
([#3448](#3448))
([4152ba6](4152ba6))
* Updates to gas and fees yellow paper
([#3438](#3438))
([5f0e1ca](5f0e1ca))
</details>

<details><summary>barretenberg.js: 0.16.1</summary>

##
[0.16.1](barretenberg.js-v0.16.0...barretenberg.js-v0.16.1)
(2023-11-28)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.1</summary>

##
[0.16.1](barretenberg-v0.16.0...barretenberg-v0.16.1)
(2023-11-28)


### Features

* Added poseidon2 hash function to barretenberg/crypto
([#3118](#3118))
([d47782b](d47782b))


### Miscellaneous

* Point acir tests at noir master branch
([#3440](#3440))
([106e690](106e690))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Nov 29, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.1</summary>

##
[0.16.1](AztecProtocol/aztec-packages@aztec-packages-v0.16.0...aztec-packages-v0.16.1)
(2023-11-28)


### Features

* Added poseidon2 hash function to barretenberg/crypto
([#3118](AztecProtocol/aztec-packages#3118))
([d47782b](AztecProtocol/aztec-packages@d47782b))
* Aztec CI files in Noir
([#3430](AztecProtocol/aztec-packages#3430))
([1621f3a](AztecProtocol/aztec-packages@1621f3a))
* Persistent archiver store
([#3410](AztecProtocol/aztec-packages#3410))
([4735bde](AztecProtocol/aztec-packages@4735bde)),
closes
[#3361](AztecProtocol/aztec-packages#3361)


### Bug Fixes

* **ci:** Don't leave DRY_DEPLOY unset
([#3449](AztecProtocol/aztec-packages#3449))
([454e316](AztecProtocol/aztec-packages@454e316))
* **ci:** Publishing dockerhub manifests
([#3451](AztecProtocol/aztec-packages#3451))
([a59e7f0](AztecProtocol/aztec-packages@a59e7f0))
* Hotfix noir sync
([#3436](AztecProtocol/aztec-packages#3436))
([c4e4745](AztecProtocol/aztec-packages@c4e4745))


### Miscellaneous

* **docs:** Core concepts page in getting-started
([#3401](AztecProtocol/aztec-packages#3401))
([1a62f73](AztecProtocol/aztec-packages@1a62f73))
* Point acir tests at noir master branch
([#3440](AztecProtocol/aztec-packages#3440))
([106e690](AztecProtocol/aztec-packages@106e690))


### Documentation

* Further updates to the gas and fees whitepaper
([#3448](AztecProtocol/aztec-packages#3448))
([4152ba6](AztecProtocol/aztec-packages@4152ba6))
* Updates to gas and fees yellow paper
([#3438](AztecProtocol/aztec-packages#3438))
([5f0e1ca](AztecProtocol/aztec-packages@5f0e1ca))
</details>

<details><summary>barretenberg.js: 0.16.1</summary>

##
[0.16.1](AztecProtocol/aztec-packages@barretenberg.js-v0.16.0...barretenberg.js-v0.16.1)
(2023-11-28)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.1</summary>

##
[0.16.1](AztecProtocol/aztec-packages@barretenberg-v0.16.0...barretenberg-v0.16.1)
(2023-11-28)


### Features

* Added poseidon2 hash function to barretenberg/crypto
([#3118](AztecProtocol/aztec-packages#3118))
([d47782b](AztecProtocol/aztec-packages@d47782b))


### Miscellaneous

* Point acir tests at noir master branch
([#3440](AztecProtocol/aztec-packages#3440))
([106e690](AztecProtocol/aztec-packages@106e690))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants