Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deterministically deduplicate cached_partial_non_native_field_multiplication across wasm32 and native compilations #3425

Merged
merged 6 commits into from
Nov 27, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,31 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename Arithmetization:
if (a < other.a) {
return true;
}
if (a == other.a) {
if (b < other.b) {
return true;
}
if (other.a < a) {
return false;
}
if (b < other.b) {
return true;
}
if (other.b < b) {
return false;
}

if (uint256_t(lo_0) < uint256_t(other.lo_0)) {
return true;
}
return false;
kevaundray marked this conversation as resolved.
Show resolved Hide resolved
if (uint256_t(other.lo_0) < uint256_t(lo_0)) {
return false;
}

if (uint256_t(hi_0) < uint256_t(other.hi_0)) {
return true;
}
if (uint256_t(other.hi_0) < uint256_t(hi_0)) {
return false;
}

return uint256_t(hi_1) < uint256_t(other.hi_1);
}
};

Expand Down