Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more logs relevant for debugging failures of 2 pixies test #3370

Merged
merged 4 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions yarn-project/aztec.js/src/contract/sent_tx.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FieldsOf } from '@aztec/circuits.js';
import { FieldsOf, MAX_NEW_NULLIFIERS_PER_TX } from '@aztec/circuits.js';
import { retryUntil } from '@aztec/foundation/retry';
import { ExtendedNote, GetUnencryptedLogsResponse, PXE, TxHash, TxReceipt, TxStatus } from '@aztec/types';

Expand Down Expand Up @@ -66,7 +66,34 @@ export class SentTx {
}
const receipt = await this.waitForReceipt(opts);
if (receipt.status !== TxStatus.MINED) {
throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}`);
// ############## Temporary code start ##############
// A few logs placed here temporarily to help me (@benesjan) debug an issue with intermittent failure of
// 2 pixies test.
// https://github.com/AztecProtocol/aztec-packages/issues/3357
// For whatever reason (according to logs) the tx which appears here as dropped seems to be correctly included
// in a block and the block built and submitted on-chain. I will try to fetch the latest block here and see
// which txs it contains to check if the block source used here has the relevant block. If it doesn't then
// the test is probably misconfigured and an incorrect block source is used (pxe pointing to a different aztec
// node or smt like that) or there is some bigger issue with block sync somewhere.
const blockNum = await this.pxe.getBlockNumber();
const block = await this.pxe.getBlock(blockNum);
if (block) {
const txHashes = [];
for (let txIndex = 0; txIndex < block!.numberOfTxs; txIndex++) {
const txHash = block!.newNullifiers[MAX_NEW_NULLIFIERS_PER_TX * txIndex];
txHashes.push(txHash.toString());
}
throw new Error(
`Transaction ${await this.getTxHash()} was ${
receipt.status
}.\nTx hashes of txs included in the last synced block ${block?.number} are: ${txHashes}`,
);
} else {
throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}. Block ${blockNum} not found.`);
}
// ############## Temporary code end ##############

// throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}`);
}
if (opts?.debug) {
const txHash = await this.getTxHash();
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/src/e2e_2_pxes.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe('e2e_2_pxes', () => {
);
};

it('transfers fund from user A to B via PXE A followed by transfer from B to A via PXE B', async () => {
it('transfers funds from user A to B via PXE A followed by transfer from B to A via PXE B', async () => {
const initialBalance = 987n;
const transferAmount1 = 654n;
const transferAmount2 = 323n;
Expand Down