Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ECCVM changes for integration in Goblin #3328

Closed
wants to merge 5 commits into from

Conversation

codygunton
Copy link
Contributor

As part of Goblin, the ECCVM needs to prove openings of five prover polynomials when regarded as univariates. We also need pass the BN254 commitments of the ecc operation queue's ultra ops vectors to the ECC Transcript. This PR does this plus some small cleanup, most notably removing the BN254 instantiation of the ECCVM.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@AztecBot
Copy link
Collaborator

AztecBot commented Nov 16, 2023

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4229173e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,972 868,088 3,449,564
l1_rollup_execution_gas 842,059 3,595,196 22,204,933
l2_block_processing_time_in_ms 1,993 (-1%) 7,546 (-2%) 29,898
note_successful_decrypting_time_in_ms 293 (-1%) 870 (-2%) 3,146 (-2%)
note_trial_decrypting_time_in_ms 96.7 (-3%) 78.9 (-14%) 133
l2_block_building_time_in_ms 20,592 81,341 (-1%) 325,085 (-1%)
l2_block_rollup_simulation_time_in_ms 11,985 47,199 (-1%) 187,923 (-1%)
l2_block_public_tx_process_time_in_ms 8,567 (-1%) 34,012 (-1%) 136,667

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 22,041 42,590 (+1%)
note_history_successful_decrypting_time_in_ms 2,091 (+3%) 4,057 (+2%)
note_history_trial_decrypting_time_in_ms 122 (+2%) 145
node_database_size_in_bytes 1,629,952 1,099,052
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 760 61,697 18,905
private-kernel-ordering 125 24,297 8,153
base-rollup 1,767 656,428 873
root-rollup 172 (+2%) 4,072 1,097
private-kernel-inner 786 81,568 18,905
public-kernel-private-input 566 41,519 18,905
public-kernel-non-first-iteration 404 41,561 18,905
merge-rollup 15.2 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,787 27,547

@codygunton codygunton changed the title feat: ECCVM changes for integratioin in Goblin feat: ECCVM changes for integration in Goblin Nov 16, 2023
@codygunton
Copy link
Contributor Author

codygunton commented Nov 17, 2023

Handed off to @ledwards2225, became #3330 and #3331

@codygunton codygunton closed this Nov 17, 2023
@codygunton codygunton deleted the cg/eccvm-changes-for-full-goblin branch June 2, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants