Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add noir-protocol-circuits to deploy_npm #3268

Merged
merged 3 commits into from
Nov 7, 2023
Merged

chore: Add noir-protocol-circuits to deploy_npm #3268

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3f5037
chore: add noir-protocol-circuits to deploy_npm
sirasistant Nov 7, 2023
a3d945b
chore: move circuits after merkle tree
sirasistant Nov 7, 2023
1aa00a5
docs: add comment regarding ordering
sirasistant Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions yarn-project/deploy_npm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ deploy_package l1-artifacts
deploy_package ethereum
deploy_package noir-compiler
deploy_package noir-contracts
deploy_package noir-protocol-circuits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be after merkle-tree since noir-protocol-circuits depends on that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes correct, I didn't look at devDependencies

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm It's a devDependency but I'll move it just in case!

deploy_package cli
deploy_package merkle-tree
deploy_package acir-simulator
Expand Down