feat: nuking `Pokeable` contract #2939

benesjan · 2023-10-20T09:55:01Z

Fixes #2938

fixed the camel case naming in the Test contract

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2023-10-20T11:50:50Z

Benchmark results

Metrics with a significant change:

node_history_sync_time_in_ms (5): 14,110 (+19%)
node_history_sync_time_in_ms (10): 27,440 (+21%)
note_history_successful_decrypting_time_in_ms (5): 3,099 (+27%)
note_history_successful_decrypting_time_in_ms (10): 6,338 (+31%)
l2_block_building_time_in_ms (8): 8,952 (-19%)
l2_block_building_time_in_ms (32): 35,953 (-19%)
l2_block_building_time_in_ms (128): 158,422 (-20%)
l2_block_rollup_simulation_time_in_ms (8): 6,597 (-20%)
l2_block_rollup_simulation_time_in_ms (32): 26,518 (-20%)
l2_block_rollup_simulation_time_in_ms (128): 105,305 (-20%)
l2_block_public_tx_process_time_in_ms (8): 2,312 (-16%)
l2_block_public_tx_process_time_in_ms (32): 9,306 (-16%)
l2_block_public_tx_process_time_in_ms (128): 52,443 (-22%)
l2_block_processing_time_in_ms (8): 1,012 (-19%)
l2_block_processing_time_in_ms (128): 15,495 (-17%)
note_successful_decrypting_time_in_ms (32): 1,026 (-20%)
note_successful_decrypting_time_in_ms (128): 4,047 (-19%)
note_trial_decrypting_time_in_ms (8): 37.0 (-62%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit eaa3d4e3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,852	868,184	3,447,980
l1_rollup_execution_gas	841,939	3,595,292	22,203,349
l2_block_processing_time_in_ms	⚠️ 1,012 (-19%)	4,064 (-15%)	⚠️ 15,495 (-17%)
note_successful_decrypting_time_in_ms	334 (-15%)	⚠️ 1,026 (-20%)	⚠️ 4,047 (-19%)
note_trial_decrypting_time_in_ms	⚠️ 37.0 (-62%)	107 (-3%)	138 (-4%)
l2_block_building_time_in_ms	⚠️ 8,952 (-19%)	⚠️ 35,953 (-19%)	⚠️ 158,422 (-20%)
l2_block_rollup_simulation_time_in_ms	⚠️ 6,597 (-20%)	⚠️ 26,518 (-20%)	⚠️ 105,305 (-20%)
l2_block_public_tx_process_time_in_ms	⚠️ 2,312 (-16%)	⚠️ 9,306 (-16%)	⚠️ 52,443 (-22%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	⚠️ 14,110 (+19%)	⚠️ 27,440 (+21%)
note_history_successful_decrypting_time_in_ms	⚠️ 3,099 (+27%)	⚠️ 6,338 (+31%)
note_history_trial_decrypting_time_in_ms	127 (+3%)	158 (-24%)
node_database_size_in_bytes	1,661,765	1,202,136
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	52.8	61,697	18,841
private-kernel-ordering	26.1 (+1%)	24,233	8,089
base-rollup	940 (-1%)	639,797	811
root-rollup	44.4 (+8%)	4,072	1,097
private-kernel-inner	46.8 (-1%)	81,504	18,841
public-kernel-private-input	53.0 (-2%)	41,455	18,841
public-kernel-non-first-iteration	34.7 (-2%)	41,497	18,841
merge-rollup	1.00 (-7%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,508

This reverts commit 2f05b6d.

LHerskind

Mini nits. If you address the merge issue its fine to merge for me.

LHerskind · 2023-10-20T14:18:01Z

docs/docs/concepts/foundation/accounts/main.md

@@ -90,7 +90,8 @@ A side-effect of not having nonces at the protocol level is that it is not possi

 Since the `entrypoint` interface is not enshrined, there is nothing that differentiates an account contract from an application one in the protocol. This means that a transaction can be initiated in any contract. This allows implementing functions that do not need to be called by any particular user and are just intended to advance the state of a contract.

-As an example, we can think of a lottery contract, where at some point a prize needs to be paid out to its winners. This `pay` action does not require authentication and does not need to be executed by any user in particular, so anyone could submit a transaction that defines the lottery contract itself as `origin` and `pay` as entrypoint function.  For an example implementation of a different use case, refer to the [`pokeable_token_contract`](https://github.com/AztecProtocol/aztec-packages/blob/master/yarn-project/noir-contracts/src/contracts/pokeable_token_contract/src/main.nr) in the repository.
+As an example, we can think of a lottery contract, where at some point a prize needs to be paid out to its winners. This `pay` action does not require authentication and does not need to be executed by any user in particular, so anyone could submit a transaction that defines the lottery contract itself as `origin` and `pay` as entrypoint function.  For an example of this behavior see our [non_contract_account test](https://github.com/AztecProtocol/aztec-packages/blob/master/yarn-project/end-to-end/src/e2e_non_contract_account.test.ts) and the [SignerLess wallet](https://github.com/AztecProtocol/aztec-packages/blob/master/yarn-project/aztec.js/src/wallet/signerless_wallet.ts) implementation.


Should probably have a note on what is used as msg_sender. Not sure if @iAmMichaelConnor figured out what he desired the value to be? 👀

Mike's response in my DMs:

I think it should be 0 if no entrypoint is called.
There’s a separate topic about what the msg sender should be for a private -> public call, and I think we’ll use some clever stealth address ideas for that

yarn-project/acir-simulator/src/client/private_execution.test.ts

LHerskind · 2023-10-20T14:21:00Z

yarn-project/end-to-end/src/e2e_non_contract_account.test.ts


-    await expectsNumOfEncryptedLogsInTheLastBlockToBe(aztecNode, 1);
+    expect(siloedNullifier.equals(expectedSiloedNullifier)).toBeTruthy();


Why not expect(siloedNullifier).toEqual(expectedSiloedNullifier)?

It didn't work and I assume it was because TS was comparing object identity and not its values.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.10.0</summary> ## [0.10.0](aztec-packages-v0.9.0...aztec-packages-v0.10.0) (2023-10-24) ### ⚠ BREAKING CHANGES * Emitting encrypted log by default ([#2926](#2926)) ### Features * Added register-account command to cli ([#2980](#2980)) ([0977a90](0977a90)) * **docs:** Fix portals tutorial formatting ([#2929](#2929)) ([ab19b67](ab19b67)) * Emitting encrypted log by default ([#2926](#2926)) ([1ea2d4f](1ea2d4f)), closes [#2912](#2912) * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](#2871)) ([c4d8d96](c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](#2982)) ([a1592fd](a1592fd)) * Incorporate docs feedback and add "intermediate" level intros to some pages ([#2598](#2598)) ([78f9f52](78f9f52)) * Nuking `Pokeable` contract ([#2939](#2939)) ([583d6fb](583d6fb)) * Protogalaxy Combiner ([#2436](#2436)) ([a60c70d](a60c70d)) * Protogalaxy perturbator! ([#2624](#2624)) ([509dee6](509dee6)) * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) * Widget benchmarking ([#2897](#2897)) ([0e927e9](0e927e9)) ### Bug Fixes * Add @jest/types to box deps ([#2903](#2903)) ([db3fa62](db3fa62)) * Add lint rule for focused tests ([#2901](#2901)) ([fd1a1a8](fd1a1a8)) * Avoid tsc OOM by unignoring an old contract artifact ([#2932](#2932)) ([7310600](7310600)) * Bad it.only in tests ([#2900](#2900)) ([a1f3af1](a1f3af1)) * Boxes boostrap dont use ts-node directly and add .prettierignore ([#2890](#2890)) ([a3b1804](a3b1804)) * Confusing "Unknown complete address" error ([#2967](#2967)) ([3a8f54a](3a8f54a)) * Force jest to quit, otherwise CI can rack up to 3hrs of credits per job. ([#2899](#2899)) ([ba2f671](ba2f671)) * Honk sumcheck performance ([#2925](#2925)) ([5fbfe6e](5fbfe6e)) * Pending commitments contract using the wrong number of arguments ([#2959](#2959)) ([655c322](655c322)) * Prettierignore in boxes ([#2902](#2902)) ([8f7a200](8f7a200)) * Randomness in `AddressNote` ([#2965](#2965)) ([4dc49a9](4dc49a9)) * Yarn lock ([#2923](#2923)) ([7042bc6](7042bc6)) ### Miscellaneous * `Private Data Tree` --> `Note Hash Tree` ([#2945](#2945)) ([abaec9c](abaec9c)), closes [#2906](#2906) * Apply hash abstraction over aztec-nr ([#2958](#2958)) ([52f01ae](52f01ae)) * **docs:** Add Singleton and ImmutableSingleton `view_note` methods ([#2934](#2934)) ([c1497f8](c1497f8)) * Fix box frontend styling ([#2919](#2919)) ([7e9e8cc](7e9e8cc)) * Less noisy benchmark reports ([#2916](#2916)) ([0df166c](0df166c)) * Remove unused nix files ([#2933](#2933)) ([3174f84](3174f84)) * Run all e2e tests against sandbox ([#2891](#2891)) ([6c4e26c](6c4e26c)) * Token box copies noir source files from noir-contracts on bootstrap ([#2940](#2940)) ([a467b96](a467b96)) ### Documentation * Fix: update cheat codes to connect to ethRpcUrl ([#2922](#2922)) ([4ffe9be](4ffe9be)) </details> <details><summary>barretenberg.js: 0.10.0</summary> ## [0.10.0](barretenberg.js-v0.9.0...barretenberg.js-v0.10.0) (2023-10-24) ### Features * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) </details> <details><summary>barretenberg: 0.10.0</summary> ## [0.10.0](barretenberg-v0.9.0...barretenberg-v0.10.0) (2023-10-24) ### Features * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](#2871)) ([c4d8d96](c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](#2982)) ([a1592fd](a1592fd)) * Protogalaxy Combiner ([#2436](#2436)) ([a60c70d](a60c70d)) * Protogalaxy perturbator! ([#2624](#2624)) ([509dee6](509dee6)) * Refactor pedersen hash standard ([#2592](#2592)) ([3085676](3085676)) * Widget benchmarking ([#2897](#2897)) ([0e927e9](0e927e9)) ### Bug Fixes * Honk sumcheck performance ([#2925](#2925)) ([5fbfe6e](5fbfe6e)) ### Miscellaneous * Remove unused nix files ([#2933](#2933)) ([3174f84](3174f84)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@aztec-packages-v0.9.0...aztec-packages-v0.10.0) (2023-10-24) ### ⚠ BREAKING CHANGES * Emitting encrypted log by default ([#2926](AztecProtocol/aztec-packages#2926)) ### Features * Added register-account command to cli ([#2980](AztecProtocol/aztec-packages#2980)) ([0977a90](AztecProtocol/aztec-packages@0977a90)) * **docs:** Fix portals tutorial formatting ([#2929](AztecProtocol/aztec-packages#2929)) ([ab19b67](AztecProtocol/aztec-packages@ab19b67)) * Emitting encrypted log by default ([#2926](AztecProtocol/aztec-packages#2926)) ([1ea2d4f](AztecProtocol/aztec-packages@1ea2d4f)), closes [#2912](AztecProtocol/aztec-packages#2912) * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](AztecProtocol/aztec-packages#2871)) ([c4d8d96](AztecProtocol/aztec-packages@c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](AztecProtocol/aztec-packages#2982)) ([a1592fd](AztecProtocol/aztec-packages@a1592fd)) * Incorporate docs feedback and add "intermediate" level intros to some pages ([#2598](AztecProtocol/aztec-packages#2598)) ([78f9f52](AztecProtocol/aztec-packages@78f9f52)) * Nuking `Pokeable` contract ([#2939](AztecProtocol/aztec-packages#2939)) ([583d6fb](AztecProtocol/aztec-packages@583d6fb)) * Protogalaxy Combiner ([#2436](AztecProtocol/aztec-packages#2436)) ([a60c70d](AztecProtocol/aztec-packages@a60c70d)) * Protogalaxy perturbator! ([#2624](AztecProtocol/aztec-packages#2624)) ([509dee6](AztecProtocol/aztec-packages@509dee6)) * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) * Widget benchmarking ([#2897](AztecProtocol/aztec-packages#2897)) ([0e927e9](AztecProtocol/aztec-packages@0e927e9)) ### Bug Fixes * Add @jest/types to box deps ([#2903](AztecProtocol/aztec-packages#2903)) ([db3fa62](AztecProtocol/aztec-packages@db3fa62)) * Add lint rule for focused tests ([#2901](AztecProtocol/aztec-packages#2901)) ([fd1a1a8](AztecProtocol/aztec-packages@fd1a1a8)) * Avoid tsc OOM by unignoring an old contract artifact ([#2932](AztecProtocol/aztec-packages#2932)) ([7310600](AztecProtocol/aztec-packages@7310600)) * Bad it.only in tests ([#2900](AztecProtocol/aztec-packages#2900)) ([a1f3af1](AztecProtocol/aztec-packages@a1f3af1)) * Boxes boostrap dont use ts-node directly and add .prettierignore ([#2890](AztecProtocol/aztec-packages#2890)) ([a3b1804](AztecProtocol/aztec-packages@a3b1804)) * Confusing "Unknown complete address" error ([#2967](AztecProtocol/aztec-packages#2967)) ([3a8f54a](AztecProtocol/aztec-packages@3a8f54a)) * Force jest to quit, otherwise CI can rack up to 3hrs of credits per job. ([#2899](AztecProtocol/aztec-packages#2899)) ([ba2f671](AztecProtocol/aztec-packages@ba2f671)) * Honk sumcheck performance ([#2925](AztecProtocol/aztec-packages#2925)) ([5fbfe6e](AztecProtocol/aztec-packages@5fbfe6e)) * Pending commitments contract using the wrong number of arguments ([#2959](AztecProtocol/aztec-packages#2959)) ([655c322](AztecProtocol/aztec-packages@655c322)) * Prettierignore in boxes ([#2902](AztecProtocol/aztec-packages#2902)) ([8f7a200](AztecProtocol/aztec-packages@8f7a200)) * Randomness in `AddressNote` ([#2965](AztecProtocol/aztec-packages#2965)) ([4dc49a9](AztecProtocol/aztec-packages@4dc49a9)) * Yarn lock ([#2923](AztecProtocol/aztec-packages#2923)) ([7042bc6](AztecProtocol/aztec-packages@7042bc6)) ### Miscellaneous * `Private Data Tree` --> `Note Hash Tree` ([#2945](AztecProtocol/aztec-packages#2945)) ([abaec9c](AztecProtocol/aztec-packages@abaec9c)), closes [#2906](AztecProtocol/aztec-packages#2906) * Apply hash abstraction over aztec-nr ([#2958](AztecProtocol/aztec-packages#2958)) ([52f01ae](AztecProtocol/aztec-packages@52f01ae)) * **docs:** Add Singleton and ImmutableSingleton `view_note` methods ([#2934](AztecProtocol/aztec-packages#2934)) ([c1497f8](AztecProtocol/aztec-packages@c1497f8)) * Fix box frontend styling ([#2919](AztecProtocol/aztec-packages#2919)) ([7e9e8cc](AztecProtocol/aztec-packages@7e9e8cc)) * Less noisy benchmark reports ([#2916](AztecProtocol/aztec-packages#2916)) ([0df166c](AztecProtocol/aztec-packages@0df166c)) * Remove unused nix files ([#2933](AztecProtocol/aztec-packages#2933)) ([3174f84](AztecProtocol/aztec-packages@3174f84)) * Run all e2e tests against sandbox ([#2891](AztecProtocol/aztec-packages#2891)) ([6c4e26c](AztecProtocol/aztec-packages@6c4e26c)) * Token box copies noir source files from noir-contracts on bootstrap ([#2940](AztecProtocol/aztec-packages#2940)) ([a467b96](AztecProtocol/aztec-packages@a467b96)) ### Documentation * Fix: update cheat codes to connect to ethRpcUrl ([#2922](AztecProtocol/aztec-packages#2922)) ([4ffe9be](AztecProtocol/aztec-packages@4ffe9be)) </details> <details><summary>barretenberg.js: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@barretenberg.js-v0.9.0...barretenberg.js-v0.10.0) (2023-10-24) ### Features * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) </details> <details><summary>barretenberg: 0.10.0</summary> ## [0.10.0](AztecProtocol/aztec-packages@barretenberg-v0.9.0...barretenberg-v0.10.0) (2023-10-24) ### Features * Goblin translator non-native field relation (Goblin Translator part 6) ([#2871](AztecProtocol/aztec-packages#2871)) ([c4d8d96](AztecProtocol/aztec-packages@c4d8d96)) * Honk profiling by pass, tsan preset ([#2982](AztecProtocol/aztec-packages#2982)) ([a1592fd](AztecProtocol/aztec-packages@a1592fd)) * Protogalaxy Combiner ([#2436](AztecProtocol/aztec-packages#2436)) ([a60c70d](AztecProtocol/aztec-packages@a60c70d)) * Protogalaxy perturbator! ([#2624](AztecProtocol/aztec-packages#2624)) ([509dee6](AztecProtocol/aztec-packages@509dee6)) * Refactor pedersen hash standard ([#2592](AztecProtocol/aztec-packages#2592)) ([3085676](AztecProtocol/aztec-packages@3085676)) * Widget benchmarking ([#2897](AztecProtocol/aztec-packages#2897)) ([0e927e9](AztecProtocol/aztec-packages@0e927e9)) ### Bug Fixes * Honk sumcheck performance ([#2925](AztecProtocol/aztec-packages#2925)) ([5fbfe6e](AztecProtocol/aztec-packages@5fbfe6e)) ### Miscellaneous * Remove unused nix files ([#2933](AztecProtocol/aztec-packages#2933)) ([3174f84](AztecProtocol/aztec-packages@3174f84)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan marked this pull request as draft October 20, 2023 09:55

benesjan added 5 commits October 20, 2023 11:49

updated non contract account test

d1f2e99

removing the contract

a2361e1

fix

c46c176

better test

9addbb8

updated docs

2785b2f

benesjan added 2 commits October 20, 2023 12:01

fixed camel case

43e167b

updated artifacts

2f05b6d

benesjan force-pushed the janb/poker_nuke branch from f30ef95 to 2f05b6d Compare October 20, 2023 12:02

Revert "updated artifacts"

db89ff3

This reverts commit 2f05b6d.

benesjan marked this pull request as ready for review October 20, 2023 12:15

benesjan added 2 commits October 20, 2023 12:29

fix

85d8d1a

fix

1aedc9b

LHerskind approved these changes Oct 20, 2023

View reviewed changes

benesjan mentioned this pull request Oct 20, 2023

Test msg_sender is 0 when no entrypoint is called #2949

Closed

benesjan added 2 commits October 20, 2023 15:37

docs: noting that msg_sender is 0 when no entrypoint is used

5c64d1f

Merge branch 'master' into janb/poker_nuke

cc975b8

benesjan enabled auto-merge (squash) October 20, 2023 15:41

benesjan merged commit 583d6fb into master Oct 20, 2023
2 checks passed

benesjan deleted the janb/poker_nuke branch October 20, 2023 15:43

AztecBot mentioned this pull request Oct 20, 2023

chore(master): Release 0.10.0 #2893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: nuking `Pokeable` contract #2939

feat: nuking `Pokeable` contract #2939

benesjan commented Oct 20, 2023 •

edited

Loading

AztecBot commented Oct 20, 2023 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

LHerskind left a comment

LHerskind Oct 20, 2023

benesjan Oct 20, 2023

LHerskind Oct 20, 2023

benesjan Oct 20, 2023


		await expectsNumOfEncryptedLogsInTheLastBlockToBe(aztecNode, 1);
		expect(siloedNullifier.equals(expectedSiloedNullifier)).toBeTruthy();

feat: nuking Pokeable contract #2939

feat: nuking Pokeable contract #2939

Conversation

benesjan commented Oct 20, 2023 • edited Loading

Checklist:

AztecBot commented Oct 20, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind Oct 20, 2023

Choose a reason for hiding this comment

benesjan Oct 20, 2023

Choose a reason for hiding this comment

LHerskind Oct 20, 2023

Choose a reason for hiding this comment

benesjan Oct 20, 2023

Choose a reason for hiding this comment

feat: nuking `Pokeable` contract #2939

feat: nuking `Pokeable` contract #2939

benesjan commented Oct 20, 2023 •

edited

Loading

AztecBot commented Oct 20, 2023 •

edited

Loading