-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix check_circuit in goblin translator (resulted in flimsy test) #2827
fix: Fix check_circuit in goblin translator (resulted in flimsy test) #2827
Conversation
Benchmark resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
|
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.13</summary> ## [0.8.13](aztec-packages-v0.8.12...aztec-packages-v0.8.13) (2023-10-13) ### Features * **docs_tutorials:** Token Portal & Uniswap Tutorial ([#2726](#2726)) ([dbef55f](dbef55f)) ### Bug Fixes * Added registry contract address to node terraform ([#2851](#2851)) ([bfc5feb](bfc5feb)) * Create canary dockerhub manifest ([#2849](#2849)) ([1d7bd26](1d7bd26)) * Fix check_circuit in goblin translator (resulted in flimsy test) ([#2827](#2827)) ([98b1679](98b1679)) </details> <details><summary>barretenberg.js: 0.8.13</summary> ## [0.8.13](barretenberg.js-v0.8.12...barretenberg.js-v0.8.13) (2023-10-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.13</summary> ## [0.8.13](barretenberg-v0.8.12...barretenberg-v0.8.13) (2023-10-13) ### Bug Fixes * Fix check_circuit in goblin translator (resulted in flimsy test) ([#2827](#2827)) ([98b1679](98b1679)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.13</summary> ## [0.8.13](AztecProtocol/aztec-packages@aztec-packages-v0.8.12...aztec-packages-v0.8.13) (2023-10-13) ### Features * **docs_tutorials:** Token Portal & Uniswap Tutorial ([#2726](AztecProtocol/aztec-packages#2726)) ([dbef55f](AztecProtocol/aztec-packages@dbef55f)) ### Bug Fixes * Added registry contract address to node terraform ([#2851](AztecProtocol/aztec-packages#2851)) ([bfc5feb](AztecProtocol/aztec-packages@bfc5feb)) * Create canary dockerhub manifest ([#2849](AztecProtocol/aztec-packages#2849)) ([1d7bd26](AztecProtocol/aztec-packages@1d7bd26)) * Fix check_circuit in goblin translator (resulted in flimsy test) ([#2827](AztecProtocol/aztec-packages#2827)) ([98b1679](AztecProtocol/aztec-packages@98b1679)) </details> <details><summary>barretenberg.js: 0.8.13</summary> ## [0.8.13](AztecProtocol/aztec-packages@barretenberg.js-v0.8.12...barretenberg.js-v0.8.13) (2023-10-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.13</summary> ## [0.8.13](AztecProtocol/aztec-packages@barretenberg-v0.8.12...barretenberg-v0.8.13) (2023-10-13) ### Bug Fixes * Fix check_circuit in goblin translator (resulted in flimsy test) ([#2827](AztecProtocol/aztec-packages#2827)) ([98b1679](AztecProtocol/aztec-packages@98b1679)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes a small issue in check_circuit of goblin translator that was causing tests to fail with probability ~ 1/100
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.