Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix check_circuit in goblin translator (resulted in flimsy test) #2827

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Oct 12, 2023

Fixes a small issue in check_circuit of goblin translator that was causing tests to fail with probability ~ 1/100

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@Rumata888 Rumata888 self-assigned this Oct 12, 2023
@Rumata888 Rumata888 added the crypto cryptography label Oct 12, 2023
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 13, 2023

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5585075f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,912 868,112 3,449,612
l1_rollup_execution_gas 841,999 3,595,220 22,204,981
l2_block_processing_time_in_ms 1,004 (-2%) 3,891 (-1%) 15,665 (+3%)
note_successful_decrypting_time_in_ms 320 (-1%) 977 (-2%) 3,721 (+4%)
note_trial_decrypting_time_in_ms 25.0 (-4%) ⚠️ 86.0 (-13%) 137 (-1%)
l2_block_building_time_in_ms 8,899 35,903 152,669 (+3%)
l2_block_rollup_simulation_time_in_ms 6,608 26,646 106,745 (+2%)
l2_block_public_tx_process_time_in_ms 2,252 (-1%) 9,131 (+1%) 45,453 (+5%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,609 (+4%) 32,301 (+5%)
note_history_successful_decrypting_time_in_ms 2,399 (+5%) 4,897 (+10%)
note_history_trial_decrypting_time_in_ms 123 (+2%) ⚠️ 146 (-29%)
node_database_size_in_bytes 1,648,115 1,192,019
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 44.3 (+2%) 56,577 14,745
private-kernel-ordering 21.7 (+2%) 20,137 8,089
base-rollup 855 631,605 811
root-rollup 38.1 (-1%) 4,072 1,097
private-kernel-inner 37.1 (+4%) 72,288 14,745
public-kernel-private-input 47.5 (+1%) 37,359 14,745
public-kernel-non-first-iteration 28.5 (+1%) 37,401 14,745
merge-rollup 0.913 (+5%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,094

@Rumata888 Rumata888 merged commit 98b1679 into master Oct 13, 2023
2 checks passed
@Rumata888 Rumata888 deleted the is/goblin_translator_circuit_builder_quick_fix branch October 13, 2023 15:10
PhilWindle pushed a commit that referenced this pull request Oct 13, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.13</summary>

##
[0.8.13](aztec-packages-v0.8.12...aztec-packages-v0.8.13)
(2023-10-13)


### Features

* **docs_tutorials:** Token Portal & Uniswap Tutorial
([#2726](#2726))
([dbef55f](dbef55f))


### Bug Fixes

* Added registry contract address to node terraform
([#2851](#2851))
([bfc5feb](bfc5feb))
* Create canary dockerhub manifest
([#2849](#2849))
([1d7bd26](1d7bd26))
* Fix check_circuit in goblin translator (resulted in flimsy test)
([#2827](#2827))
([98b1679](98b1679))
</details>

<details><summary>barretenberg.js: 0.8.13</summary>

##
[0.8.13](barretenberg.js-v0.8.12...barretenberg.js-v0.8.13)
(2023-10-13)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.8.13</summary>

##
[0.8.13](barretenberg-v0.8.12...barretenberg-v0.8.13)
(2023-10-13)


### Bug Fixes

* Fix check_circuit in goblin translator (resulted in flimsy test)
([#2827](#2827))
([98b1679](98b1679))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 14, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.13</summary>

##
[0.8.13](AztecProtocol/aztec-packages@aztec-packages-v0.8.12...aztec-packages-v0.8.13)
(2023-10-13)


### Features

* **docs_tutorials:** Token Portal & Uniswap Tutorial
([#2726](AztecProtocol/aztec-packages#2726))
([dbef55f](AztecProtocol/aztec-packages@dbef55f))


### Bug Fixes

* Added registry contract address to node terraform
([#2851](AztecProtocol/aztec-packages#2851))
([bfc5feb](AztecProtocol/aztec-packages@bfc5feb))
* Create canary dockerhub manifest
([#2849](AztecProtocol/aztec-packages#2849))
([1d7bd26](AztecProtocol/aztec-packages@1d7bd26))
* Fix check_circuit in goblin translator (resulted in flimsy test)
([#2827](AztecProtocol/aztec-packages#2827))
([98b1679](AztecProtocol/aztec-packages@98b1679))
</details>

<details><summary>barretenberg.js: 0.8.13</summary>

##
[0.8.13](AztecProtocol/aztec-packages@barretenberg.js-v0.8.12...barretenberg.js-v0.8.13)
(2023-10-13)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.8.13</summary>

##
[0.8.13](AztecProtocol/aztec-packages@barretenberg-v0.8.12...barretenberg-v0.8.13)
(2023-10-13)


### Bug Fixes

* Fix check_circuit in goblin translator (resulted in flimsy test)
([#2827](AztecProtocol/aztec-packages#2827))
([98b1679](AztecProtocol/aztec-packages@98b1679))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto cryptography
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants