Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l1-contracts): remove remappings of @aztec #2797

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

rahul-kothari
Copy link
Contributor

Currently you can't use the npm package @aztec/l1-contracts due to these remappings. npx hardhat compile would fail with unable to find module @aztec/core/package.json. Install it with npm

I have left @oz remappings since that is only used in the tests. Happy to remove it too though

@rahul-kothari rahul-kothari changed the title remove remappings of @aztec feat(l1-contracts): remove remappings of @aztec Oct 11, 2023
@rahul-kothari rahul-kothari enabled auto-merge (squash) October 11, 2023 12:55
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the remapping but fine with sacrificing them to make it work.

@rahul-kothari rahul-kothari merged commit aac8b37 into master Oct 11, 2023
2 of 3 checks passed
@rahul-kothari rahul-kothari deleted the rk/l1_s_rel_imports branch October 11, 2023 13:25
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45444 179588 716132
l1_rollup_calldata_gas 222852 868052 3449444
l1_rollup_execution_gas 841939 3595160 22204813
l2_block_processing_time_in_ms 1043 3951 15680
note_successful_decrypting_time_in_ms 332 1017 3794
note_trial_decrypting_time_in_ms 34 107 138
l2_block_building_time_in_ms 9033 36189 151317
l2_block_rollup_simulation_time_in_ms 6693 26871 106460
l2_block_public_tx_process_time_in_ms 2299 9186 44386

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 10 blocks 20 blocks 30 blocks
node_history_sync_time_in_ms 35091 81592 140434
note_history_successful_decrypting_time_in_ms 6095 18087 28266
note_history_trial_decrypting_time_in_ms 156 366 281
node_database_size_in_bytes 1189974 1901483 2754527
pxe_database_size_in_bytes 54187 108338 162578

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 74.3872699386503 56577 14745
private-kernel-ordering 37.62193251533742 20137 8089
base-rollup 1009 631604 810
root-rollup 44.073170731707314 4072 1097
private-kernel-inner 71.8395061728395 72288 14745
public-kernel-private-input 64.36728395061728 37359 14745
public-kernel-non-first-iteration 38.348765432098766 37401 14745
merge-rollup 1.189922480620155 2592 873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants