Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removal of setting private data root in kernel prover #2671

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: removal of setting private data root in kernel prover #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ void initialise_end_values(PrivateKernelInputsInit<NT> const& private_inputs,
auto const& private_call_public_inputs = private_inputs.private_call.call_stack_item.public_inputs;
auto const constants = CombinedConstantData<NT>{
.block_data = private_call_public_inputs.historic_block_data,
// TODO(dbanks12): remove historic root from app circuit public inputs and
// add it to PrivateCallData: https://github.com/AztecProtocol/aztec-packages/issues/778
// Then use this:
// .private_data_tree_root = private_inputs.private_call.historic_private_data_tree_root,
.tx_context = private_inputs.tx_request.tx_context,
};

Expand Down
5 changes: 0 additions & 5 deletions yarn-project/pxe/src/kernel_prover/kernel_prover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,6 @@ export class KernelProver {
);

if (firstIteration) {
// TODO(https://github.com/AztecProtocol/aztec-packages/issues/778): remove historic root
// from app circuit public inputs and add it to PrivateCallData
privateCallData.callStackItem.publicInputs.historicBlockData.privateDataTreeRoot =
await this.oracle.getPrivateDataRoot();

output = await this.proofCreator.createProofInit(new PrivateKernelInputsInit(txRequest, privateCallData));
} else {
const previousVkMembershipWitness = await this.oracle.getVkMembershipWitness(previousVerificationKey);
Expand Down