Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes in deploy scripts #2659

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore: Fixes in deploy scripts #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-system/scripts/deploy_dockerhub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ echo "Deploying to dockerhub: $IMAGE_DEPLOY_URI"
# Login.
retry ensure_repo $REPOSITORY $ECR_DEPLOY_REGION

# Login to dockerhub.
# Login to dockerhub and ecr
dockerhub_login
ecr_login

echo "Pulling $IMAGE_COMMIT_URI"
# Pull image.
Expand Down
4 changes: 2 additions & 2 deletions yarn-project/deploy_npm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function deploy_package() {
TMP=$(mktemp)
jq --arg v $VERSION '.version = $v' package.json > $TMP && mv $TMP package.json

if [ -z "$STANDALONE" ]; then
if [ -z "${STANDALONE:-}" ]; then
# Update each dependent @aztec package version in package.json.
for PKG in $(jq --raw-output ".dependencies | keys[] | select(contains(\"@aztec/\"))" package.json); do
jq --arg v $VERSION ".dependencies[\"$PKG\"] = \$v" package.json > $TMP && mv $TMP package.json
Expand All @@ -49,7 +49,7 @@ function deploy_package() {
package.json > $TMP && mv $TMP package.json

# Publish
if [ -n "$COMMIT_TAG" ] ; then
if [ -n "${COMMIT_TAG:-}" ] ; then
npm publish $TAG_ARG --access public
else
npm publish --dry-run $TAG_ARG --access public
Expand Down