Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove -u from build_wasm script so that we can skip the build when SKIP_CPP_BUILD is unset #2649

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

kevaundray
Copy link
Contributor

The build wasm script uses set -u so if SKIP_CPP_BUILD is not set, then the script will error

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@kevaundray
Copy link
Contributor Author

Actually -z will check if the string is empty or unset, so I think the -u was not meant to be there.

For example, the following will not skip the build:

SKIP_CPP_BUILD=0

if [ -z "$SKIP_CPP_BUILD" ]; then
    echo "SKIP_CPP_BUILD is unset or empty"
else
    echo "SKIP_CPP_BUILD is set and not empty"
fi

whereas

SKIP_CPP_BUILD="" will skip the build. Not setting SKIP_CPP_BUILD will result in a failure due to set -u

…ol/aztec-packages into kw/skip-cpp-build-on-publish
@kevaundray kevaundray changed the title fix: add a flag to specify whether we want to skip the cpp build when publishing fix: remove -u from build_wasm script so that we can skip the build when SKIP_CPP_BUILD is unset Oct 3, 2023
@kevaundray kevaundray merged commit 84b8ff4 into master Oct 3, 2023
2 checks passed
@kevaundray kevaundray deleted the kw/skip-cpp-build-on-publish branch October 3, 2023 18:29
kevaundray pushed a commit that referenced this pull request Oct 3, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 5, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))
* Benchmark script fixes for master branch
([#2638](AztecProtocol/aztec-packages#2638))
([0a161a4](AztecProtocol/aztec-packages@0a161a4))
* Redirect sunset instructions
([#2646](AztecProtocol/aztec-packages#2646))
([9253442](AztecProtocol/aztec-packages@9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](AztecProtocol/aztec-packages#2637))
([d11343f](AztecProtocol/aztec-packages@d11343f))
* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
…hen SKIP_CPP_BUILD is unset (#2649)

The build wasm script uses set -u so if SKIP_CPP_BUILD is not set, then
the script will error

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants