Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: historic access data tree #2585

Closed
wants to merge 10 commits into from
Closed

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Sep 28, 2023

Fixes #2584 as part of #2572

  • Updates the pedersen hash_multiple to follow the version used in noir (plookup_commit).
    • This is essentially a work around just to allow testing the feature.
  • Unifies the naming of getCommitmentIndex and findCommitmentIndex to findCommitmentIndex
  • Adds getMembershipWitness oracle which currently provides both index and path. It only works for the data tree atm, but as part of Use historic roots from noir #2572 should be made to work with the other trees.

Uses an AlmostValueNote as input since the macro is using the serialize function, which for ValueNote don't include the header so it is invalid.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@dan-aztec dan-aztec linked an issue Sep 28, 2023 that may be closed by this pull request
@LHerskind LHerskind force-pushed the lh/historic_storage_access branch from 0439971 to c56ea1c Compare September 29, 2023 10:52
@LHerskind LHerskind force-pushed the lh/historic_storage_access branch from 9a255d1 to 445b628 Compare September 29, 2023 12:34
@kevaundray
Copy link
Contributor

Updates the pedersen hash_multiple to follow the version used in noir (plookup_commit).
This is essentially a work around just to allow testing the feature.

This change can now be reverted since we have now migrated over to the new pedersen implementation

@benesjan
Copy link
Contributor

Closed in favor of #3159

@benesjan benesjan closed this Oct 31, 2023
@benesjan benesjan mentioned this pull request Oct 31, 2023
4 tasks
@ludamad ludamad deleted the lh/historic_storage_access branch August 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Prove inclusion in historic data root L1ToL2Message membership check.
3 participants