fix: add contract flag to noirup #2431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ayo brother imma steal this in #2434! |
rahul-kothari
added a commit
that referenced
this pull request
Sep 21, 2023
First up - most things are just copy-paste so don't fret!
**Breaking changes:**
* Create a section on Tutorials and move everything there
* Only have two things in Getting started - it is getting started after
all! It should have a quickstart and interacting w sandbox
* Delete aztec.nr setup
* Move the token tutorial into /tutorials/
**Changes:**
Make updates proposed in #2431
* Sandbox getting started -
* is slightly cleaner and shorter. Santiago mentioned we should just use
the preloaded contracts.
* And add links to the code repo at the top!
* Fix e2e_sandbox_examples.test.ts appropriately.
* Contracts:
* make the main page better and point to tutorials. Fix link (would tell
people to install nargo from Noir website)
* Create a section on setting up -> can delete getting started this way.
* make syntax/main cleaner to focus only on syntax and remove wrong
references to it
* Wallets:
* section on creation
* cli -> no more a folder. Just a page
* sandbox errors -> no more a folder. Just a page
New docs -
<img width="296" alt="image"
src="https://github.com/AztecProtocol/aztec-packages/assets/35169918/69d1f87c-a852-4582-ae9f-dc77dab1dc5d">
---------
Co-authored-by: Josh Crites <[email protected]>
Co-authored-by: josh crites <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the toml location for aztec-nr, tells people to use the contract flag when making a new project