fix: Update aztec sandbox getting started markdown #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-kothari
requested changes
Sep 18, 2023
| @@ -107,6 +99,7 @@ describe('e2e_sandbox_example', () => { | |||
| // Create the contract abstraction and link to Alice's wallet for future signing | |||
| const tokenContractAlice = await TokenContract.at(contract.address, await accounts[0].getWallet()); | |||
|
|
|||
| // Initialize the contract and add Bob as a minter | |||
There was a problem hiding this comment.
Would it be cleaner to use withWallet() on tokenContract instead of what this file does here (instantiating tokenContract twice (for Alice and Bob each)?
| @@ -180,6 +180,7 @@ contract Token { | |||
| 1 | |||
| } | |||
|
|
|||
| // docs:start:transfer | |||
| #[aztec(public)] | |||
| fn transfer_public( | |||
There was a problem hiding this comment.
getting started talks about sending tokens privately. Looks like here we are showing the public transfer though?
rahul-kothari
approved these changes
Sep 18, 2023
Maddiaa0
reviewed
Sep 18, 2023
| buffer: <Buffer cf 7e d3 ac ca 5a 46 7e 9e 70 4c 70 3e 8d 87 f6 34 fb 0f c9> | ||
| }, | ||
| client: '[email protected]', | ||
| compatibleNargoVersion: '0.11.1-aztec.0' |
There was a problem hiding this comment.
Not really. Would want it to be depending on the tests, but not sure what the best way is for that right now and just wanted it fixed in this case as people need it shortly
| 1. The sender. | ||
| 2. The recipient. | ||
| 3. The quantity of tokens to be transferred. | ||
| 4. The nonce for the AuthWit, or 0 if msg.sender equal sender. |
There was a problem hiding this comment.
Remember to link to AuthWit docs if there are any, or use the full Auth Witness, this is a tutorial and i have no context to what this is yet
There was a problem hiding this comment.
Expanded it for authentication witness and added a link.
PhilWindle
pushed a commit
that referenced
this pull request
Sep 19, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.7.8</summary> ## [0.7.8](aztec-packages-v0.7.7...aztec-packages-v0.7.8) (2023-09-19) ### Features * `NodeInfo` cleanup ([#2370](#2370)) ([89fe978](89fe978)) * Allow custom ports in sandbox ([#2393](#2393)) ([41ef378](41ef378)) * Allow tracing build system with [debug ci] ([#2389](#2389)) ([ce311a9](ce311a9)) * **docs:** Show current noir version for aztec in docs ([#2379](#2379)) ([5c7b2ab](5c7b2ab)) ### Bug Fixes * Build script exiting on failed grep ([#2384](#2384)) ([e70a781](e70a781)) * Bump e2e_sandbox_example.test.ts timeout ([#2391](#2391)) ([9a1bb62](9a1bb62)) * Compile script for the unboxed project ([#2380](#2380)) ([2801da2](2801da2)) * Force_deploy_build error ([#2375](#2375)) ([4d1cbf9](4d1cbf9)) * Update aztec sandbox getting started markdown ([#2374](#2374)) ([a3c6bcf](a3c6bcf)) ### Miscellaneous * Adds on-brand design to private token project ([#2355](#2355)) ([072e313](072e313)) * Docs restructure ([#2322](#2322)) ([1368b55](1368b55)) ### Documentation * Updated noirup command ([#2339](#2339)) ([5308c21](5308c21)) </details> <details><summary>barretenberg.js: 0.7.8</summary> ## [0.7.8](barretenberg.js-v0.7.7...barretenberg.js-v0.7.8) (2023-09-19) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.7.8</summary> ## [0.7.8](barretenberg-v0.7.7...barretenberg-v0.7.8) (2023-09-19) ### Features * Allow tracing build system with [debug ci] ([#2389](#2389)) ([ce311a9](ce311a9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half the snippets were stale or pointing to wrong files.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.