Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add retry around docker login and revive spot_run_test_script #2346

Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix: add retry around docker login and revive spot_run_test_script #2346

merged 4 commits into from
Sep 15, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 15, 2023 •
edited
Loading

  • couldn't use retry directly as I didn't want the password to be part of a bash -c command, and otherwise couldnt pass the full string to retry
  • deleted script was still used

@ludamad ludamad changed the title fix: add retry and revive spot_run_test_script fix: add retry around docker login and revive spot_run_test_script Sep 15, 2023
@ludamad ludamad merged commit 79e5f05 into master Sep 15, 2023
2 checks passed
@ludamad ludamad deleted the ad/fix-docker-retry branch September 15, 2023 20:30
@AztecBot AztecBot mentioned this pull request Sep 15, 2023
Merged
ludamad pushed a commit that referenced this pull request Sep 15, 2023
@AztecBot
chore(master): Release 0.7.5 (#2345)
869b282 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.7.5</summary>

##
[0.7.5](aztec-packages-v0.7.4...aztec-packages-v0.7.5)
(2023-09-15)


### Features

* Protogalaxy interfaces
([#2125](#2125))
([b45dd26](b45dd26))
* Renamed `nargoVersion` as `compatibleNargoVersion`
([#2338](#2338))
([6f9e0f1](6f9e0f1))


### Bug Fixes

* Add retry around docker login and revive spot_run_test_script
([#2346](#2346))
([79e5f05](79e5f05))
* Unbox command.
([#2337](#2337))
([e9bc9c6](e9bc9c6))


### Miscellaneous

* Increase guides-dapp-testing test timeout
([#2343](#2343))
([1cebe2c](1cebe2c))
* Use retries by default on rpc client fetch
([#2342](#2342))
([f4ffd68](f4ffd68))
</details>

<details><summary>barretenberg.js: 0.7.5</summary>

##
[0.7.5](barretenberg.js-v0.7.4...barretenberg.js-v0.7.5)
(2023-09-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.7.5</summary>

##
[0.7.5](barretenberg-v0.7.4...barretenberg-v0.7.5)
(2023-09-15)


### Features

* Protogalaxy interfaces
([#2125](#2125))
([b45dd26](b45dd26))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ludamad