fix: export $CONTRACT var in end to end test #2344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
reviewed
Sep 15, 2023
Maddiaa0
reviewed
Sep 16, 2023
| @@ -16,36 +16,39 @@ aztec-cli deploy \ | |||
| # docs:end:deploy | |||
|
|
|||
| aztec-cli check-deploy --contract-address 0x03b030d48607ba8a0562f0f1f82be26c3f091e45e10f74c2d8cebb80d526a69f | |||
| # docs:start:declare-contract | |||
There was a problem hiding this comment.
This tag is created but i dont see where it is used
There was a problem hiding this comment.
This should actually be part of this PR: #2322
EDIT: I will move this changes to that PR since it's where it's relevant.
4 tasks
|
Moving these changes to this PR (#2322) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves the deployed contract address to CONTRACT, so that it can be referenced as $CONTRACT in the remainder of the test, and these command can be referenced in the docs.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.