Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update instructions #2297
docs: update instructions #2297
Changes from 15 commits
b8a6743
7500208
523c609
29f00e9
53b1379
fa3e151
ceb671a
7faa014
a0044b3
4683bf8
de94765
daea076
ef17a14
1c9fe84
42643d0
476c089
e0f155a
534a73e
e783331
999b17b
e3e73ff
644a519
0e480ad
5e18c6a
3467cfc
3561503
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we assert that the returned text from the command matches this? It's a bit annoying since we need to load the versions from the release-please-manifest and the noir-version jsons. Or we can just parse it manually, and use an
expect.anything()
for those values.