Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(circuits): hints nullifier transient commitments #2056

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

jeanmon
Copy link
Contributor

@jeanmon jeanmon commented Sep 6, 2023

Resolves #837

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@jeanmon jeanmon force-pushed the jm/837-hints-nullifier-transient-commitments branch 2 times, most recently from 59dfe9f to 9ccf223 Compare September 6, 2023 12:46
@jeanmon jeanmon marked this pull request as ready for review September 6, 2023 12:50
@jeanmon jeanmon force-pushed the jm/837-hints-nullifier-transient-commitments branch from 9ccf223 to 9f29b60 Compare September 6, 2023 13:00
@jeanmon jeanmon requested review from dbanks12 and suyash67 September 6, 2023 13:03
@jeanmon jeanmon force-pushed the jm/837-hints-nullifier-transient-commitments branch from 9f29b60 to 0f7dba3 Compare September 6, 2023 13:12
@jeanmon jeanmon force-pushed the jm/837-hints-nullifier-transient-commitments branch from 0f7dba3 to 14cf9eb Compare September 6, 2023 13:52
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Very clean.

@jeanmon jeanmon merged commit 725b550 into master Sep 6, 2023
@jeanmon jeanmon deleted the jm/837-hints-nullifier-transient-commitments branch September 6, 2023 14:29
PhilWindle pushed a commit that referenced this pull request Sep 6, 2023
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha62](v0.1.0-alpha61...v0.1.0-alpha62)
(2023-09-06)


### Features

* **circuits:** hints nullifier transient commitments
([#2056](#2056))
([725b550](725b550))
* **docs:** Testing guide and getPrivateStorage method
([#1992](#1992))
([5a8c571](5a8c571))


### Bug Fixes

* **build:** Use semver version in docker version tag
([#2065](#2065))
([b3db0d0](b3db0d0))


### Documentation

* Link to local ethereum nodes in testing guide
([#2061](#2061))
([e29148b](e29148b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[TS, C++] Provide hint to private kernel circuit on matching transient nullifiers with their commitments
2 participants