Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined safety in master part 5 #2034

Merged
merged 11 commits into from
Sep 5, 2023
Merged

fix: undefined safety in master part 5 #2034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c7b8b76
Fix deploy_ecr
ludamad Sep 5, 2023
cce0a8a
More deploy fixes
ludamad Sep 5, 2023
cf492db
More deploy fixes
ludamad Sep 5, 2023
6e1f1f5
Fix more undefined safety.
ludamad Sep 5, 2023
9ea734f
Fix more undefined safety.
ludamad Sep 5, 2023
7da4561
Merge remote-tracking branch 'origin/master' into fix/deploy_ecr
ludamad Sep 5, 2023
dc9c9f3
Fix more undefined safety.
ludamad Sep 5, 2023
80acd29
Fix commit tag version.
ludamad Sep 5, 2023
f169917
Fix more undefined safety.
ludamad Sep 5, 2023
3d9e487
Fix more undefined safety.
ludamad Sep 5, 2023
648a276
Merge branch 'master' into fix/deploy_ecr
ludamad Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions build-system/scripts/deploy_dockerhub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ REPOSITORY=$1
IMAGE_TAG=$COMMIT_TAG_VERSION
IMAGE_COMMIT_URI=$ECR_DEPLOY_URL/$REPOSITORY:$COMMIT_HASH
IMAGE_LATEST_URI=aztecprotocol/$REPOSITORY:latest

COMMIT_TAG_VERSION=$COMMIT_TAG # default unless repo-specific
# Check if it's a repo-specific tag
if [[ "$COMMIT_TAG" == *"/"* ]]; then
REPO_NAME="${COMMIT_TAG%%/*}"
Expand All @@ -23,8 +23,6 @@ if [[ "$COMMIT_TAG" == *"/"* ]]; then
echo "REPO_NAME ($REPO_NAME) does not match REPOSITORY ($REPOSITORY). Exiting..."
exit 1
fi
else
COMMIT_TAG_VERSION=$COMMIT_TAG
fi
IMAGE_TAG=$COMMIT_TAG_VERSION
IMAGE_DEPLOY_URI=aztecprotocol/$REPOSITORY:$IMAGE_TAG
Expand Down
1 change: 1 addition & 0 deletions build-system/scripts/deploy_npm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ fi

# If the commit tag itself has a dist-tag (e.g. v2.1.0-testnet.123), extract the dist-tag.
TAG=$(echo "$VERSION" | grep -oP ".*-\K(.*)(?=\.\d+)" || true)
TAG_ARG=""
if [ -n "$TAG" ]; then
TAG_ARG="--tag $TAG"
fi
Expand Down