Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Option to fail silently when retrying #2015

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Sep 5, 2023

Fixes #1783
Add failSilently option to retry function.
This means that nothing will be printed until we run out of retries, at which point the error will be thrown.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@spypsy spypsy merged commit 453c9c1 into master Sep 5, 2023
@spypsy spypsy deleted the sp/silent-retry branch September 5, 2023 15:34
PhilWindle pushed a commit that referenced this pull request Sep 5, 2023
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha52](v0.1.0-alpha51...v0.1.0-alpha52)
(2023-09-05)


### Features

* **docs:** set up noir contracts in getting-started
([#1770](#1770))
([33eb99d](33eb99d))


### Bug Fixes

* Complete JS call stacks across ACVM wasm boundaries
([#2013](#2013))
([8e84e46](8e84e46))
* deploy_ecr calculating CONTENT_HASH
([#2024](#2024))
([edee198](edee198))
* Option to fail silently when retrying
([#2015](#2015))
([453c9c1](453c9c1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

FETCH FAILED: socket error when creating accounts
2 participants