refactor: protogalaxy relations #1897
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| add_subdirectory(decrypt_bench) | ||
| add_subdirectory(pippenger_bench) | ||
| add_subdirectory(plonk_bench) | ||
| add_subdirectory(honk_bench) | ||
| add_subdirectory(relations_bench) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Each source represents a separate benchmark suite | ||
| set(BENCHMARK_SOURCES | ||
| barycentric.bench.cpp | ||
| relations.bench.cpp | ||
| ) | ||
|
|
||
| # Required libraries for benchmark suites | ||
| set(LINKED_LIBRARIES | ||
| polynomials | ||
| benchmark::benchmark | ||
| ) | ||
|
|
||
| # Add executable and custom target for each suite, e.g. standard_honk_bench | ||
| foreach(BENCHMARK_SOURCE ${BENCHMARK_SOURCES}) | ||
| get_filename_component(BENCHMARK_NAME ${BENCHMARK_SOURCE} NAME_WE) # extract name without extension | ||
| add_executable(${BENCHMARK_NAME}_bench main.bench.cpp ${BENCHMARK_SOURCE}) | ||
| target_link_libraries(${BENCHMARK_NAME}_bench ${LINKED_LIBRARIES}) | ||
| add_custom_target(run_${BENCHMARK_NAME} COMMAND ${BENCHMARK_NAME} WORKING_DIRECTORY ${CMAKE_BINARY_DIR}) | ||
| endforeach() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #include "barretenberg/ecc/curves/bn254/fr.hpp" | ||
| #include "barretenberg/polynomials/barycentric.hpp" | ||
| #include <benchmark/benchmark.h> | ||
|
|
||
| using namespace benchmark; | ||
|
|
||
| namespace { | ||
| auto& engine = numeric::random::get_debug_engine(); | ||
| } | ||
|
|
||
| using FF = barretenberg::fr; | ||
| using barretenberg::Univariate; | ||
| using barretenberg::BarycentricData; | ||
|
|
||
|
|
||
| namespace proof_system::benchmark { | ||
|
|
||
| void extend_2_to_6(State& state) noexcept | ||
| { | ||
| auto univariate = Univariate<FF, 2>::get_random(); | ||
| BarycentricData<FF, 2, 6> barycentric_2_to_6; | ||
| for (auto _ : state) | ||
| { | ||
| DoNotOptimize(barycentric_2_to_6.extend(univariate)); | ||
|
There was a problem hiding this comment. what's the purpose of this There was a problem hiding this comment. From https://github.com/google/benchmark/blob/main/docs/user_guide.md#preventing-optimization
Since the result of |
||
| } | ||
| } | ||
| BENCHMARK(extend_2_to_6); | ||
|
|
||
| } // namespace proof_system::benchmark | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include <benchmark/benchmark.h> | ||
|
|
||
| BENCHMARK_MAIN(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| #include "barretenberg/honk/flavor/goblin_ultra.hpp" | ||
| #include "barretenberg/honk/flavor/standard.hpp" | ||
| #include "barretenberg/honk/flavor/ultra.hpp" | ||
| #include "barretenberg/proof_system/relations/arithmetic_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/auxiliary_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/ecc_op_queue_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/elliptic_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/gen_perm_sort_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/lookup_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/permutation_relation.hpp" | ||
| #include "barretenberg/proof_system/relations/ultra_arithmetic_relation.hpp" | ||
| #include <benchmark/benchmark.h> | ||
|
|
||
| namespace { | ||
| auto& engine = numeric::random::get_debug_engine(); | ||
| } | ||
|
|
||
| namespace proof_system::benchmark::relations { | ||
|
|
||
| using FF = barretenberg::fr; | ||
|
|
||
| template <typename Flavor, typename Relation> void execute_relation(::benchmark::State& state) | ||
| { | ||
| // Generate beta and gamma | ||
| auto beta = FF::random_element(); | ||
| auto gamma = FF::random_element(); | ||
| auto public_input_delta = FF::random_element(); | ||
|
|
||
| RelationParameters<FF> params{ | ||
| .beta = beta, | ||
| .gamma = gamma, | ||
| .public_input_delta = public_input_delta, | ||
| }; | ||
|
|
||
| using ClaimedEvaluations = typename Flavor::ClaimedEvaluations; | ||
| using RelationValues = typename Relation::RelationValues; | ||
|
|
||
| // Extract an array containing all the polynomial evaluations at a given row i | ||
| ClaimedEvaluations new_value; | ||
| // Define the appropriate RelationValues type for this relation and initialize to zero | ||
| RelationValues accumulator; | ||
| // Evaluate each constraint in the relation and check that each is satisfied | ||
|
|
||
| Relation relation; | ||
| for (auto _ : state) { | ||
| relation.add_full_relation_value_contribution(accumulator, new_value, params); | ||
| } | ||
| } | ||
|
|
||
| void arithmetic_relation(::benchmark::State& state) noexcept | ||
|
There was a problem hiding this comment. We'll want to measure how the relations improve as we optimize. |
||
| { | ||
| execute_relation<honk::flavor::Standard, ArithmeticRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(arithmetic_relation); | ||
|
|
||
| void auxiliary_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Ultra, AuxiliaryRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(auxiliary_relation); | ||
|
|
||
| void elliptic_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Ultra, EllipticRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(elliptic_relation); | ||
|
|
||
| void ecc_op_queue_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::GoblinUltra, EccOpQueueRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(ecc_op_queue_relation); | ||
|
|
||
| void gen_perm_sort_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Ultra, GenPermSortRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(gen_perm_sort_relation); | ||
|
|
||
| void lookup_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Ultra, LookupRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(lookup_relation); | ||
|
|
||
| void permutation_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Standard, PermutationRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(permutation_relation); | ||
|
|
||
| void ultra_arithmetic_relation(::benchmark::State& state) noexcept | ||
| { | ||
| execute_relation<honk::flavor::Ultra, UltraArithmeticRelation<FF>>(state); | ||
| } | ||
| BENCHMARK(ultra_arithmetic_relation); | ||
|
|
||
| } // namespace proof_system::benchmark::relations | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used this to compare the optimization I put in
BarycentricDatato make extension from degree 2 very efficient. It gives approximately a 10x improvement, in one measurement, 417ns to 40ns.