update typings to merge related changes in circuits #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
requested changes
Apr 5, 2023
yarn-project/circuits.js/src/structs/__snapshots__/base_rollup.test.ts.snap
Outdated
Show resolved
Hide resolved
yarn-project/circuits.js/src/structs/__snapshots__/base_rollup.test.ts.snap
Outdated
Show resolved
Hide resolved
yarn-project/circuits.js/src/structs/__snapshots__/root_rollup.test.ts.snap
Outdated
Show resolved
Hide resolved
rahul-kothari
force-pushed
the
rk/merge_struct_updates
branch
from
cf9b7cb to
6c6d7ea
Compare
|
@rahul-kothari I think this has been superseded by @PhilWindle's work on #198, right? Should we close this PR? |
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
* pcs updated to new paradigm; still many duplicate functions * removing redundant functions, renaming etc * some gemini cleanup * general cleanup * update gemini interface to take batched polys * update gemini verifier to take batched commiitments * general cleanup and comment correction * send batched evaluation to gemini * removing some types, evaluate a pos directly in prover, cleanup * woops, missed commented out include
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* pcs updated to new paradigm; still many duplicate functions * removing redundant functions, renaming etc * some gemini cleanup * general cleanup * update gemini interface to take batched polys * update gemini verifier to take batched commiitments * general cleanup and comment correction * send batched evaluation to gemini * removing some types, evaluate a pos directly in prover, cleanup * woops, missed commented out include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AztecProtocol/aztec3-circuits#153 adds merge rollup into the circuits repo. It changes a lot of the structs and types. One of the major changes is the fact that BasePublicInputs and MergePublicInputs are the same struct now.
Wanted to reflect these changes here.
Checklist: