Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manual cp from Dockerfiles #184

Closed
wants to merge 4 commits into from
Closed

remove manual cp from Dockerfiles #184

wants to merge 4 commits into from

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Apr 5, 2023

Description

  • add build:link as part of building bb.js and circuits.js so no manual cp step is needed in Dockerfiles that depend on them

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spalladino
Copy link
Collaborator

@spypsy I think we can close this after #229, right?

@ludamad ludamad closed this Apr 14, 2023
@ludamad ludamad deleted the sp/ci-wasm branch July 14, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants